Hello Kristis,

I'm referring to Integration.pm.in (process_activity_tag). I think we should call integration_tag_exists for $TAG_OPERATION_DELETE too.

integration_tag_exists does all the checks for addition and removal of a tag. So we could remove redundant checks in integration_add_tag/ integration_delete_tag in the future (e.g. check for existence of the product), or not? This has an impact on other bugtrackers too, and it's just redundant, so we might don't change these methods for now.

At least we should do integration_tag_exists in TAG_OPERATION_DELETE, see attached fix (tested with SVN+Bugzilla).

Attachment: Integration.pm.in.patch
Description: Binary data



--
Oliver




_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to