Kristis, Yes, I tested with my large commit message. The regex I sent you works for both the simple single line log message with a trailing bug # and the 300KB log message from svnmerge with a trailing bug #.
I'll try your suggestions and let you know what I find. Regards, Mike -----Original Message----- From: Kristis Makris [mailto:[EMAIL PROTECTED] Sent: Monday, January 21, 2008 11:11 AM To: Brown, Mike Cc: '[email protected]' Subject: RE: [scmbug-users] very large commit comments break scmbug + bugz illa On Mon, 2008-01-21 at 10:55 -0600, Brown, Mike wrote: > I changed the regex instead of changing all of my repositories to use a non > default property. This simpler regex appears to work for the default > subversion + TortoiseSVN configuration I use. Have you tested it with a long log message ? > log_bugid_regex => 'Issue:\s(\d+?)$', > log_body_regex => '(.*)\s*Issue:\s\d+?$', > > Let me know if this simplified regex will break something else in scmbug. I think the regexes will work, but may lead to long processing times on long log messages again. You essentially expect log messages to be of the format: ++++++++++++++++++++++ My log message goes here Issue: 345,7654,88 ++++++++++++++++++++++ The regex you supplied allows for that,. But the long processing times were caused due to the regex evaluation taking too long to match. We had made the regex more restrictive in the example I had sent you and you tried by changing: log_bugid_regex => 'bug\s*([\d|\s|,|#]*?):', to log_bugid_regex => '^bug\s*([\d|\s|,|#]*?):', essentially adding the "^" character in the beginning. This forces the regex to match from the beginning of a line, drastically reducing evaluation time. To still accomplish that, and maintain your requirement that the issue numbers are listed after the log message, I would recommend you change them to something like: log_bugid_regex => '^.*\s*Issue:\s(\d+?)$', log_body_regex => '^(.*)\s*Issue:\s\d+?$', Or if these fail, at least manage to sneak a "^" in the beginning of both regexes. Let me know how this works, Kristis _______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
