by "this hack" i mean "your hack", because my proposal is not a hack, but is the correct way to return an error code from a batch file, AFAIK. you should use hacks when there is no "right" way (e.g. with published API) to achieve something. but the fact that the hack works, doesn't mean you should use it. hacks are by nature not supported, and their behavior may change in future versions without notice. so they should in general be used as a last resort.
finally, i hope you are not seriously suggesting someone will run a software management system on Windows 98. besides, i didn't check how exit is implemented on Win9x. it may very well be that it works just like on Win2k. i don't have access to Win9x these days. perhaps it's possible to find something on the microsoft web site. Tsahi -- The day Micro$oft sells something that doesn't SUCK is the day they start selling vacuum cleaners. http://www.geocities.com/tsahi_75 ----- Original Message ---- > From: Kristis Makris <[EMAIL PROTECTED]> > To: Tsahi Asher <[EMAIL PROTECTED]> > Cc: scmbug-users <[email protected]> > Sent: Tuesday, February 19, 2008 1:37:54 PM > Subject: Re: [scmbug-users] SCMBug should use exit /b 1 and not goto non > existant label hack > > On Tue, 2008-02-19 at 01:32 -0800, Tsahi Asher wrote: > > currently, scmbug adds this hack to pre-commit.bat in windows: > > > > REM Do not define label scmbug_script_failed. This will result in the batch > > REM file to fail without terminating the command interpreter > > if NOT %ERRORLEVEL% == 0 goto scmbug_script_failed 2>nul > > > > in order to exit with error. instead, using > > > > exit /b 1 > > > > will exit the batch file without exiting the command interpreter, with exit > code 1. > > > > it's possible that this works on NT systems only, but considering even > Microsoft doesn't support Win9x, i think it's safe enough to require Win2k as > a > minimum. > > http://bugzilla.mkgnu.net/show_bug.cgi?id=1126 > > I'm afraid I don't understand what you mean. > > First, when you refer to "this", do you mean "this hack" or "this hack > you propose in exchange" ? > > Second, why should "this hack" be changed ? Does it not work ? > > Third, Microsoft not supporting Win9x does not mean Win9x is not in use > in the real-world. > ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping _______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
