On Mon, 2009-03-09 at 13:21 -0400, Matt Adams wrote: > Kristis Makris wrote: > > > Also, I wanted to ask, shouldn't we sending email notifications for all > > activities ? Meaning, do we expect the bug-tracker to be responsible for > > figuring out if email should be sent ? If we request email notifications > > when a tag is applied would that be desireable ? > > I wrote a (rather ugly) patch a while ago to integrate Scmbug with > Bugzilla's native email notification. > > I think Scmbug should leave email notification up to the bug tracker.
How do we do that ? If we call Send() when nothing changed on the bug, I would assume the right thing would happen: no email would be sent. With that reasoning, calling Send() during every Scmbug activity that modifies the bugtracker, which are activity_commit and activity_tag, then the right thing should happen. My point being, we should call it on activity_tag, too, not just activity_commit per Javor's patch. What is the bug-tracker API that figures out which emails should be sent ? In your patch, you simply call contrib/sendbugmail.pl with the bug-ids, and this effectively calls BugMail::Send(). > Bugzilla has a very configurable set of rules that dictate when it sends > email and to whom. Trying to duplicate or override these native rules > would be an absolute mess. In Javor's patch, BugMail::Send() is issued directly. After looking at Send(), it seems the configurable set of rules that dictate when it sends email and to whom are implemented in that function.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
