Hey Simon, It's great you'll get some time to work on these things. What I would advise is always... run the testsuite! Things break in more subtle ways you can imagine.
I know that I won't merge any patches unless testcases are built that cover these changes. On Tue, 2009-03-10 at 17:38 +0000, Simon Brooke wrote: > I now have a list of issues with scmbug which my users want me to fix, and > I'm negotiating with management to get some resource (i.e. my time, not > someone else's, but at least official time I can dedicate) to fix them. > However, if I'm going to have a decent run at it, I need documentation I have > not yet found, especially of the communication protocol between the glue and > the daemon. > > Does this exist anywhere? No, it's not documented. It's isolated in Connection.pm.in and Process.pm.in in the source, and it's fairly easy to read through. > For what it's worth the issues are all to do with CVS integration and are: > > Correctly identifying products (bug 2701) > > The author of Scumbug, Kristis Makris, has never implemented the system to > identify different products in a single CVS repository, and it clearly isn't > a problem for him. His advice is don't keep multiple products in a single CVS > repository, but that isn't an option we have. It isn't essentially hard to > fix this - I did have it working at one stage - but the fix has been lost in > subsequent upgrades, because I didn't take the time to write it up and > package up a patch. True. You need to add some testcases for that and run the full testsuite after you make a change. > Listing changed files (bug 2702) > > Scumbug is supposed to list, in its report which is appended to a bug on > Bugzilla, each file which has changed with a from version and a to version. > Ours doesn't do this. The author is extremely surprised ours doesn't, and > says just do a clean reinstall and it will work. I have done a clean > reinstall, and it doesn't work. Clearly something is broken here because it > is working for other users on other sites. It's probably related to > 'Correctly identifying products', above. Probably related to your changes in correctly identifying products. > Avoiding repeating reports (bug 2703) > > Scumbug is supposed to consolidate bug reports from a single CVS commit. Ours > doesn't do that; it frequently generates repeated reports. It appears likely > that these repeated reports are one per affected directory, e.g. (bug 2655): Try setting consolidate_cvs_activities to 0 (switch it off). I am 100% sure this feature misbehaves. I had to disable it in my installation. The unexpected behavior I had seen, and I may not recall this correctly, was a little worse: comments would not be added at all (in additional affected directories) Update: Yes, I recall this correctly: http://bugzilla.mkgnu.net/show_bug.cgi?id=1043#c10 > ------- Comment #5 From Simon Brooke 2009-03-04 16:48:58 0 [reply] ------- > > I've fixed this by making the RueOutput field non-persistable; I've exercised > all the functions which make use of this field, and the fix seems to work. I'm > not 100% confident. When this fix is installed the field in the database must > be made nullable, or things WILL break. > > > Branch: b_VERSION-3 > Affected files: > --------------- > %{Vvs} --> Bugzilla-CVS-Wiki integrion:ESA-McIntosh-CADLink/Backend/Entities/ > > ------- Comment #4 From Simon Brooke 2009-03-04 16:48:57 0 [reply] ------- > > I've fixed this by making the RueOutput field non-persistable; I've exercised > all the functions which make use of this field, and the fix seems to work. I'm > not 100% confident. When this fix is installed the field in the database must > be made nullable, or things WILL break. > > > Branch: b_VERSION-3 > Affected files: > --------------- > %{Vvs} --> Bugzilla-CVS-Wiki integrion:ESA-McIntosh-CADLink/Backend/ > > > > Simon Brooke, Software Specialist > Cygnet Solutions Ltd > Registered office: Swan House, Darvel, Ayrshire, Scotland, KA17 0LP > Registered in Scotland No. SC158059 > mail: [email protected] > www: http://www.cygnets.co.uk > tel: +44(0)1560 323444 > fax: +44(0)1560 323432 > > _______________________________________________ > scmbug-users mailing list > [email protected] > http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
