In Activity.pm there's a method prepare_product_name(). If this detects that a
product name should be auto-detected it calls autodetect_product_name once for
each file in the activity.
However, in the changes I'm trying to make to CVS.pm and
CVSConsolidatedActivities.pm, autodetect_product_name is never called, although
the debug message:
Scmbug notice: Preparing for VERIFICATION
Scmbug DEBUG> Activity.pm:200:Scmbug::Activity::prepare_product_name - Must
autodetect the product name.
does get printed. This seems to be because there are no files in the activity;
and this in turn seems to be because during commit the files are added to the
activity by the method prepare_activity_commit_latest(), and there's no
equivalent method in the verify path; this contrasts with the Subversion class,
where there's a method prepare_activity_verify_or_commit(), which, inter alia,
sets up the files in the stanza starting at line 253.
The verifymsg CVS hook appears to be able to use the same %{Vvs} macro as
loginfo, and I'm beginning to wonder whether the best option is to write a
method prepare_activity_verify_or_commit_latest(), called by both
prepare_activity_commit() and prepare_activity_verify() if the version is
1.12.X.
Comments?
Simon Brooke, Software Specialist
Cygnet Solutions Ltd
Registered office: Swan House, Darvel, Ayrshire, Scotland, KA17 0LP
Registered in Scotland No. SC158059
mail: [email protected]
www: http://www.cygnets.co.uk
tel: +44(0)1560 323444
fax: +44(0)1560 323432
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
