Hi Kristis, I don't think this will be the official patch at all but if other ran into this problem upgrading to 3.4.x, they can use this on 26_16 to make it work while waiting for your official code. There's too many developers at my company who make used of the resolution status for me to leave it not working.
The main problem with the code is it is missing locking which is not good but, otoh, how many people could be modifying a bug while you're sending in a checkin. Again, thanks for the product and we'll be waiting for the official fix to this. --Alex ________________________________________ From: Kristis Makris [[email protected]] Sent: Saturday, December 19, 2009 10:47 AM To: Alex Huang Cc: [email protected] Subject: Re: [scmbug-users] Getting bugzilla 3.4.4 to work... Hi Alex, Thanks for the patch. You seem to have put a lot of effort into it; you picked-up writing Perl code so easily! It's great that you got it to work. It seems that you adopted the previous patch for status changes for Bugzilla 3.0.x. I was hoping to have a patch merged that uses the Bugzilla API to apply status changes, rather than issue queries to the database directly. So I'm not sure what to do with the patch yet. Kristis On Thu, 2009-12-17 at 06:47 -0800, Alex Huang wrote: > Hi All, > > I finally was able to cobble together a working system with Bugzilla 3.4.4 > with full status resolution. Here's what I did. > > 1. Download and installed 26_16. > 2. Patch the Daemon/Bugzilla.pm with the patch file I've attached. > 3. Change /etc/scmbug/daemon.conf to use bugzilla version 3.2.2 > 4. restart scmbug-server > > I got all of the fixes from contributors to bug 1073 and 1024. Thanks so > much for helping! > > A few things to note here. > > 1. The patch only applies to Bugzilla.pm in 26_16. The main reason being > there's a nice check for is_version_latest() in change_bug_resolution which > allows me to put specifically the code for 3.4.4 in there. > 2. I had to comment out the bz_lock_tables and bz_unlock_tables calls because > they're no longer supported in bugzilla. I think the main reason is because > bugzilla switched over to innodb and is probably using row locks now. I > looked all over the bugzilla code and I can't find them any more. If someone > know what I should use, I would love to try it. > 3. I had to put the version at 3.2.2 because scmbug rejects 3.4.x. And > anything less that 3.1.2 (iirc) goes a different path in the scmbug code. > > Thanks. > > --Alex > > _______________________________________________ > scmbug-users mailing list > [email protected] > http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users _______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
