Hi Yavor, Thanks a lot for the detailed feedback and for investigating a fix. The fix passes the testsuite, and I merged your patch.
http://bugzilla.mkgnu.net/show_bug.cgi?id=1465 On Sat, 2010-03-20 at 15:07 +0200, Yavor Nikolov wrote: > Here is my patch supposed to fix the described problem. Seems to work > fine for now. > > Best regards, > Yavor > > On Sat, Mar 20, 2010 at 13:02, Yavor Nikolov <[email protected]> > wrote: > Hi all, > > I'd like to report a problem which I'm facing with scmbug > v0.26.17, subversion 1.6.6, bugzilla 3.4.6 (also reproduced > with 3.4.4). > > When I commit to svn a change related to a private bug - I get > an error after change is commited. As result the bug is not > updated in bugzilla at all. > + The same works fine when the bug is defined as public one in > bugzilla (not restricted to particular group). > + The same works fine with Bugzilla 3.0.8 > > We make the bug private as follows (in bugzilla bug): > " > Restrict Group Visibility: > Only users in all of the selected groups can view this bug: > (Unchecking all boxes makes this a more public bug.) > <Our Developers group checkbox is here checked> > " > The group itself is defined in Bugzilla administration - the > user to which my commit is being mapped is the correct one: > member of this group and also member of admin group (bug's > group is subgroup of admin). Updating bug with that user via > Bugzilla interface works fine. > > > Here is a fraction of the daemon log illustrating where does > the error come from: > 2010/03/20 12:10:26 Scmbug WARN> > Daemon.pm:568:Scmbug::Daemon::Daemon::spawn_child - > 127.0.0.1:36678 Processing connection from > localhost.localdomain > 2010/03/20 12:10:26 Scmbug WARN> > Process.pm:868:Scmbug::Daemon::Process::process_activity_commit - > 127.0.0.1:36678 Processing an 'activity_commit' for bug id '283' from SCM > user 'myuser' > 2010/03/20 12:10:26 Scmbug DEBUG> > > Integration.pm:83:Scmbug::Daemon::Integration::process_activity_commit - > 127.0.0.1:36678 In process_activity_commit. > 2010/03/20 12:10:26 Scmbug DEBUG> > Integration.pm:423:Scmbug::Daemon::Integration::add_comment_to_all - > 127.0.0.1:36678 Entering add_comment_to_all. > 2010/03/20 12:10:26 Scmbug DEBUG> > Integration.pm:427:Scmbug::Daemon::Integration::add_comment_to_all - > 127.0.0.1:36678 User '[email protected]' will append to bug id > '283' the comment 'This is test 12 to investigate scmbug integration issue > > > Branch: MyProject/trunk > Affected files: > --------------- > 524 --> 525 > MyProject:MyProject/trunk/src/dw_admin/plsql/utl_tablespaces.spc > '. > 2010/03/20 12:10:26 Scmbug ERROR> > Error.pm:102:Bugzilla::Error::_throw_error - You are not > authorized to access bug #283. To see this bug, you must > first log in to an account with the appropriate permissions. > 2010/03/20 12:10:26 Scmbug DEBUG> > Daemon.pm:467:Scmbug::Daemon::Daemon::reaper - reaped 23606 > with exit 2304 > > * * * > Digging a little bit further appears that the error is raised > in Bugzilla.pm:570 > sub integration_add_comment { > ... > ... > > } else { > # Since Bugzilla 3.1.3 AppendComment has been replaced > by add_comment > my $userid = Bugzilla::User::login_to_id( $username ); > # This seems to finish with no errors (userid is returned > correctly) > if ( $userid > 0 ) { > my $bug = Bugzilla::Bug->check($bugid); # THIS > FAILS! > my $user = new Bugzilla::User($userid); # Never > reached in the problematic scenario since above aborts > processing > Bugzilla->set_user($user); > .... > > Best regards, > Yavor > > _______________________________________________ > scmbug-users mailing list > [email protected] > http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
