I don't know which patch you are referring to. You submitted a few, and I don't see a Version->create() call in any of the ones tracked in http://bugzilla.mkgnu.net/show_bug.cgi?id=1466
Can you provide a new patch ? On Thu, 2010-06-24 at 19:49 +0300, Yavor Nikolov wrote: > Hi Kristis, > > Yes, I think so. If you look at my original patch - you'll see > Version->create() is inside the eval block. > > Regards, > Yavor > > On Thu, Jun 24, 2010 at 19:22, Kristis Makris <[email protected]> wrote: > Hi Yavor, > > On Wed, 2010-06-23 at 15:53 +0300, Yavor Nikolov wrote: > > My patch for that on top of scmbug 0.26.17 worked fine in > general but > > I can see you've modified it when merging to scmbug in order > to allow > > private branching. > > > Yes, that was the intention. > > > I took the code for my patch from Bugzilla's cgi scripts and > version > > create is anyway executed by the name of the given user > (with the > > relevant permissions). So I suspect calling > > $user->check_can_admin_product doesn't pose any additional > > restrictions (just performs a check which Version->create > will perform > > anyway when called). > > > It sounds like the appropriate course of action is to have > Version->create() be inside an eval, since it will perform > that check > anyway. What do you think ? >
signature.asc
Description: This is a digitally signed message part
_______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
