Hi,
In Integration::add_comment_to_all we have a test for
bugtracker()->integration_add_comment(...) result. However - in case we have
multiple bugs processed in the foreach bug - only the return code of last
processed one is considered when determining whether add_comment_to_all
complete cleanly or not. Which means user may remain uninformed about
*_add_comment failures of some bugs.
Here is the section of code which I'm talking about:
sub add_comment_to_all {
...
...
# For each bug id, append a comment to the bug
foreach my $id ( @{ $bugs_list } ) {
log_daemon_debug( $self->request(), "User '$username' will append to
bug id '$id' the comment '$comment'.\n" );
( $comment_addition_retval, $comment_addition_retval_string ) =
$self->bugtracker()->integration_add_comment( $id, $username, $comment );
$appended = 1;
}
if ( $comment_addition_retval == 1 ) {
...
return 2;
} else {
...
return 1;
}
}
Issue has been observed in 0.26.18 and 0.26.17 - maybe exists in earlier
releases too.
Impact is low since issue won't appear when all provided data is valid and
when all the rest is working fine.
Best regards,
Yavor
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
