Hi Kristis,
if ( $self->is_version_gte( $VERSION_2_20_0 ) ) {
Means version is greater or equal to 2.20.0. So it does capture 2.20.0=2.20
(which seems to be equivalent to up_to_2_20 in this case). This is in fact
what the comment says "# In Bugzilla 2.20 AppendComment was moved to
Bugzilla::Bug"
I can't see what do you mean is incorrect - I suppose you have a good point
but I'm missing it?
***
Yes, set_version_type result is to much extent ignored:
- these up_to_*** strings used to cause those very long expressions which I
wanted to avoid
- I didn't want to change existing meaning of "$self->{ version_type }"
yet.
- set_version_type still has it's role to guard against unsupported
versions.
***
Yes, checks in other bugtrackers are not addressed (yet). I don't think
that's a bad thing - would be better to finish with Bugzilla first.
Regards,
Yavor
On Fri, Mar 4, 2011 at 04:49, Kristis Makris <[email protected]> wrote:
> Hi Yavor,
>
> I suspect the version comparison patch is incorrect. Can you have a
> look?
>
> http://bugzilla.mkgnu.net/show_bug.cgi?id=1485#c5
>
> Frankly, I don't think me reviewing this patch further, and you working
> on it further, actually saves time.
>
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
