So this is a little more interesting than I'd thought. I can fix the current issue (spurious rebuilds when LIBPATH changes) by using LIBS in the varlist rather than SHLINKCOM, which initially makes sense. But as I added a test for this, along the way thought I'd make sure that changing other random linker options does cause a rebuild as it's supposed to; it doesn't! It didn't in 2.3.0 either. But 2.2.0 is OK in that way, so I bisected that: that problem was introduced in abded0675444, which added versioned shared libs.
I'll keep looking into this and plan to submit a fix for both bugs. With tests. -- Gary On Fri, Oct 25, 2013 at 8:24 AM, Gary Oberbrunner <[email protected]>wrote: > [this was sent to the old obsolete SCons dev list, btw. Forwarding to the > new one.] > > > > On Thu, Oct 24, 2013 at 11:22 PM, William Deegan < > [email protected]> wrote: > >> Gary, >> >> I see this merge: >> >> https://bitbucket.org/scons/scons/pull-request/86/fix-http-sconstigrisorg-issues/diff >> >> I did a hg bisect on failure of test/Libs/LIBPATH.py and it tracks down >> to that checkin. >> >> The failing test in LIBPATH changes the LIBPATH and expects that no >> rebuild will be caused by it. >> Prior build was same library with same library sources. >> So it shouldn't have been rebuilt. >> >> I think: >> a) no new test was added with the merge. >> b) Likely using SHLINKCOM was too broad to resolve the problem in >> question, and is thus causing this rebuild. >> >> Or am I misunderstanding the issue? >> > > No, you're exactly right. I noticed the same thing you did; SHLINKCOM is > too broad. I agree that's the commit that causes the test failure. I've > got some code on my machine at home that does better, but it still not > perfect. (I don't have full access here but I thought I did add a test > after the merge?) > > -- > Gary > -- Gary
_______________________________________________ Scons-dev mailing list [email protected] http://two.pairlist.net/mailman/listinfo/scons-dev
