Hi I think the patch has been updated to a pattern that can be applied to tools in general.
I don’t think I answered you question yesterday well below. So let me try again. The idea to move the link action to a var that can be easy to override is an idea I agree with. I think we need to update all the tools ( SCons and Parts) to do this. Allowing the user to do this is a great idea, however, it is very advance. Advance in that most users doesn't know what all the _XXX stuff does special value like _concat. I have found that when you can allow the users a common pattern to do common things, it greatly reduces the complexity and make it easier for people to want to use the tool. From my experience, it is a common pattern for people to want or need to do this addition of items to the end. I tend to want to keep full action replacement to advance unique special cases as when the user tends to do this it is more likely the something will break or not work as expected in the future. If any of the core SCon dev have any thought I would greatly appreciate it. I should note get this to work correctly we need to tweak the scanner, which is a reason why I tend to find that full user overrides as suggested can have unwanted side effects. Jason From: Scons-dev [mailto:[email protected]] On Behalf Of Bill Deegan Sent: Friday, February 24, 2017 12:15 PM To: SCons developer list <[email protected]> Subject: Re: [Scons-dev] I have a pull request Parts I think we might want to sync with SCons Jason, Interesting. Seems like the patch could be avoided if the string provided -shlibLinkAction = SCons.Action.Action('${TEMPFILE("$SHLINK $SHLINKFLAGS $_SHLINK_TARGETS $_LIBDIRFLAGS $_LIBFLAGS $_PDB $_SHLINK_SOURCES")}') was something like: -shlibLinkAction = SCons.Action.Action('$SHLINKACTION') That would allow the user to do this independent of the tool's code? _Bill On Fri, Feb 24, 2017 at 8:41 AM, Jason Kenny <[email protected]<mailto:[email protected]>> wrote: Hi guy, I have a pull request for mslink.py tool in Parts that I think is an issue we would want as a general solution for linking on the tools that deal with linking in SCons The request is here: https://bitbucket.org/sconsparts/parts/pull-requests/17/introduced-sh-linktrailflags-to-mslinkpy/diff I would like to your guys option on the matter. Given you think you like the idea in general, do you like the value being used? If we would like to sync this change, I think we would want to keep a common value between Parts and SCons to help the users. Thanks Jason _______________________________________________ Scons-dev mailing list [email protected]<mailto:[email protected]> https://pairlist2.pair.net/mailman/listinfo/scons-dev
_______________________________________________ Scons-dev mailing list [email protected] https://pairlist2.pair.net/mailman/listinfo/scons-dev
