I haven't even tried it yet, I accidentally pushed it, I'm trying to figure
out how to revert that push.

I was hoping that it would cache the check if the source was used
elsewhere.  Also, I'm not sure why it is O(N*M).  I'm check the sources not
the targets, right?  If there was a directory as a source dependency, then
yes we'd have a problem of O(N*M) but those checks would be necessary,
right?

In any case, that change was a premature commit, I haven't even tested to
see if it does the right thing yet, much less what performance impact it
might have.

Manish

On Wed, Mar 22, 2017 at 4:41 PM, William Blevins <[email protected]>
wrote:

> Manish,
>
> Have you thought about the performance penalty for the directory node
> up_to_date change? I assume this is a reason the code operates as it
> currently does...
>
> This will require, O(N * M) checks per directory node where N = max
> directory depth and M = the number of files within the directory chain.
>
> V/R,
> William
>
_______________________________________________
Scons-dev mailing list
[email protected]
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Reply via email to