Any chance you can create a pull request on bitbucket for this? It's a lot simpler to merge that way.
Thanks, Bill On Tue, Jul 4, 2017 at 10:47 PM, Evan Driscoll <[email protected]> wrote: > I recently gave running SCons under PyPy a shot. It actually worked, > except for running out of file descriptors due to the GC not closing things > immediately. > > I went through and added some explicit close calls (actually, mostly > 'with's) and then it worked fine. It looks like you actually picked up most > of them (probably all the important ones) in 8716da8, but in case you > wanted, I thought I'd send a patch with a few more. (We're using 2.5.0, and > I'm not sure if the commit cited above landed in time for .1 or after that.) > > I don't know if the remainder matter though, or in the case of the MD5 > change, if it's in code that's even called. (Though if it is called, it may > well matter.) I just did a search for 'open' and made replacements for ones > where it looked easy to do and I didn't have to think too hard. :-) > > Evan > > P.S. On scons.org, Development -> Development, the "Developer's > Guidelines" link is broken. > > P.P.S. The FAQ still has the question "why is SCons written for Python 2.4" > > > _______________________________________________ > Scons-dev mailing list > [email protected] > https://pairlist2.pair.net/mailman/listinfo/scons-dev > >
_______________________________________________ Scons-dev mailing list [email protected] https://pairlist2.pair.net/mailman/listinfo/scons-dev
