Hi Bill, I created the pull request here: https://bitbucket.org/scons/scons/pull-requests/490/windows-added-the-capability-to-build/diff Who should I add as reviewer?
Thanks, Ibrahim From: Ibrahim Esmat Sent: Thursday, July 20, 2017 3:04 PM To: 'Bill Deegan' <[email protected]> Cc: SCons developer list <[email protected]> Subject: RE: [Scons-dev] Windows: Building Store Compatible libraries for UWP Apps Hi Bill, Thanks. Question for the docs: I updated msvc.xml for my changes, and in order for it to pass validation for msvc.xml (since I added another Variable) I ran the ‘bin/docs-update-generated.py’ script which updated the doc/generated/*.gen and doc/generated/*.mod files. Do I have to have those in my commit? Also, I get the following errors when running the bin/docs-validate.py script: 95.33% (204/214) doc/user/scons_ex.xml Traceback (most recent call last): File "bin/docs-validate.py", line 24, in <module> os.path.join('doc','user') File "/mnt/f/Dev/SConsSrc/scons/bin/SConsDoc.py", line 642, in validate_all_xml if not tf.validateXml(fp, xmlschema_context): File "/mnt/f/Dev/SConsSrc/scons/bin/SConsDoc.py", line 338, in validateXml doc.xinclude() File "src/lxml/lxml.etree.pyx", line 2342, in lxml.etree._ElementTree.xinclude (src/lxml/lxml.etree.c:71345) File "src/lxml/xinclude.pxi", line 61, in lxml.etree.XInclude.__call__ (src/lxml/lxml.etree.c:160123) lxml.etree.XIncludeError: PCDATA invalid Char value 27, line 3, column 1 Thanks, Ibrahim From: Bill Deegan [mailto:[email protected]] Sent: Wednesday, July 19, 2017 12:11 PM To: Ibrahim Esmat <[email protected]<mailto:[email protected]>> Cc: SCons developer list <[email protected]<mailto:[email protected]>> Subject: Re: [Scons-dev] Windows: Building Store Compatible libraries for UWP Apps Ibrahim, In order to have a single codebase work with both py3 and py2.7 we're using (among other things) from __future__ import print_function, this brings print() to py2.7 (and won't work even in py2.7 if it's not called as a function). So indeed it is still running with py 2.7 and erroring out when print is used without the ()'s So if you're working on default please use print(). Also note you can run via python <sandbox>/src/script/scons.py (And don't need to use the bootstrap.py script to do so anymore, bootstrap.py is at this point only for building scons, it's docs and packages) Hope that helps. -Bill On Wed, Jul 19, 2017 at 2:31 PM, Ibrahim Esmat <[email protected]<mailto:[email protected]>> wrote: Hi Bill, I made the changes and I was trying to test it with a project that we are using SCons with. However, when parsing our SConscript files, python seems to give me Invalid Syntax error for the print statements. I know that the print statement was changed to the print function in python 3.0, but on my system I have python 2.7.11. Why is SCons processing with Python 3.0? Is it how I built SCons? To build I used: python bootstrap.py And to test with our project I used: python bootstrap.py -C [project dir] [arguments] P.S I ran all the tests and they passed. Thanks, Ibrahim From: Bill Deegan [mailto:[email protected]<mailto:[email protected]>] Sent: Monday, July 17, 2017 2:04 PM To: Ibrahim Esmat <[email protected]<mailto:[email protected]>> Cc: SCons developer list <[email protected]<mailto:[email protected]>> Subject: Re: [Scons-dev] Windows: Building Store Compatible libraries for UWP Apps Probably msvs.xml Take a look at the developers guide and https://bitbucket.org/scons/scons/wiki/DeveloperGuide/Documentation<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbitbucket.org%2Fscons%2Fscons%2Fwiki%2FDeveloperGuide%2FDocumentation&data=02%7C01%7Ciesmat%40microsoft.com%7C98da5053860642f8889408d4cd5749ad%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636359222164365634&sdata=s94fap3pWjVmyxTtZoe4BWiWrx5EQ65cjtCv64sk%2FWg%3D&reserved=0>. -Bill On Mon, Jul 17, 2017 at 2:45 PM, Ibrahim Esmat <[email protected]<mailto:[email protected]>> wrote: Hi Bill, Thanks. Yes this will be for VS 2015+. Which docs should I change? Thanks, Ibrahim From: Bill Deegan [mailto:[email protected]<mailto:[email protected]>] Sent: Monday, July 17, 2017 7:34 AM To: Ibrahim Esmat <[email protected]<mailto:[email protected]>> Cc: SCons developer list <[email protected]<mailto:[email protected]>> Subject: Re: [Scons-dev] Windows: Building Store Compatible libraries for UWP Apps Ibrihim, Great! O.k. so in your pull request you should aim to have the following: 1) test(s) 2) changes to the docs to indicate the new environment variable(s) * I'm guessing this will only apply to VS 2015 and above? (or whichever versions), it would be wise to document that 3) a blurb in src/CHANGES.txt Just let the list know (or pop on IRC) if you need any help with this. -Bill On Sat, Jul 15, 2017 at 8:38 PM, Ibrahim Esmat <[email protected]<mailto:[email protected]>> wrote: Hi Bill, Thanks. The change is basically going to check a SCons environment variable and if set, it will call the Visual Studio setup batch files with an extra 'store' argument. This will setup the environment LIBPATH to point to the store libraries instead of the desktop ones. Regards, Ibrahim Get Outlook for Android From: Bill Deegan Sent: Saturday, July 15, 3:01 PM Subject: Re: [Scons-dev] Windows: Building Store Compatible libraries for UWP Apps To: SCons developer list Cc: Ibrahim Esmat Ibrihim, Take a look at the developer guide: https://bitbucket.org/<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbitbucket.org%2Fscons%2Fscons%2Fwiki%2FDeveloperGuide&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=34CU%2FqqPHKLMeAjmBuNnHmGX%2FHilJ2qmqSucf%2FrTCoc%3D&reserved=0>scons<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbitbucket.org%2Fscons%2Fscons%2Fwiki%2FDeveloperGuide&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=34CU%2FqqPHKLMeAjmBuNnHmGX%2FHilJ2qmqSucf%2FrTCoc%3D&reserved=0>/<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbitbucket.org%2Fscons%2Fscons%2Fwiki%2FDeveloperGuide&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=34CU%2FqqPHKLMeAjmBuNnHmGX%2FHilJ2qmqSucf%2FrTCoc%3D&reserved=0>scons<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbitbucket.org%2Fscons%2Fscons%2Fwiki%2FDeveloperGuide&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=34CU%2FqqPHKLMeAjmBuNnHmGX%2FHilJ2qmqSucf%2FrTCoc%3D&reserved=0>/wiki/<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbitbucket.org%2Fscons%2Fscons%2Fwiki%2FDeveloperGuide&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=34CU%2FqqPHKLMeAjmBuNnHmGX%2FHilJ2qmqSucf%2FrTCoc%3D&reserved=0>DeveloperGuide<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbitbucket.org%2Fscons%2Fscons%2Fwiki%2FDeveloperGuide&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=34CU%2FqqPHKLMeAjmBuNnHmGX%2FHilJ2qmqSucf%2FrTCoc%3D&reserved=0> Work off default, and submit a pull request, (with tests please) via bitbucket. BTW.. what needs to be changed? Flags to linker, or extra builders? Thanks, Bill On Fri, Jul 14, 2017 at 9:25 PM, Ibrahim Esmat via Scons-dev <scons<mailto:[email protected]>[email protected]<mailto:[email protected]>> wrote: Hi, I would like to make a small change to SCons to enable Universal Windows DLLs to be built from SCons. This will allow the universal libraries built to be used in a Universal Windows Platform (UWP) App that can be published to the Windows Store and available on all devices running Windows 10. Is someone already working on this? If not, which branch should I be using for the next release? Currently I’m using the default branch. Thanks, Ibrahim _______________________________________________ Scons-dev mailing list Scons<mailto:[email protected]>[email protected]<mailto:[email protected]> https://<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=fwfoNmbF662r%2FhcZyHWNMYP3sj3%2BHAHmTIUB7eFP2x4%3D&reserved=0>pairlist2<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=fwfoNmbF662r%2FhcZyHWNMYP3sj3%2BHAHmTIUB7eFP2x4%3D&reserved=0>.pair.net/mailman/<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=fwfoNmbF662r%2FhcZyHWNMYP3sj3%2BHAHmTIUB7eFP2x4%3D&reserved=0>listinfo<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=fwfoNmbF662r%2FhcZyHWNMYP3sj3%2BHAHmTIUB7eFP2x4%3D&reserved=0>/<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=fwfoNmbF662r%2FhcZyHWNMYP3sj3%2BHAHmTIUB7eFP2x4%3D&reserved=0>scons<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=fwfoNmbF662r%2FhcZyHWNMYP3sj3%2BHAHmTIUB7eFP2x4%3D&reserved=0>-dev<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7Ciesmat%40microsoft.com%7Cf43f5da9882a44a6844608d4cbccfa62%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636357528615984107&sdata=fwfoNmbF662r%2FhcZyHWNMYP3sj3%2BHAHmTIUB7eFP2x4%3D&reserved=0>
_______________________________________________ Scons-dev mailing list [email protected] https://pairlist2.pair.net/mailman/listinfo/scons-dev
