Follow-up Comment #4, bug #68508 (group screen): This wasn't quite fixed, unfortunately, as it now fails due to including Screen's own `src/pty.h` instead of the system `pty.h`.
The following one line patch fixes it: From 31de6c71900a513a677d5534257594d2a6436371 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin <[email protected]> Date: Sat, 31 Oct 2026 19:28:56 +0100 Subject: [PATCH] Use -iquote instead of -I for $(srcdir) in CPPFLAGS Using -I$(srcdir), added in cf67b6f (Include $(srcdir) in CPPFLAGS so out-of-tree builds succeed, 2026-09-24), makes screen's own src/pty.h shadow the system <pty.h> in out-of-tree builds, resulting in the following compilation error: pty.c:56:13: error: implicit declaration of function 'openpty' Use -iquote, which only applies to #include "...", to avoid this. Also list "." before $(srcdir) to keep searching the build directory, containing the generated headers, before the source one, as was the case before, because -iquote directories are searched before -I ones. --- src/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.in b/src/Makefile.in index 8fc308e..694f40a 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -33,7 +33,7 @@ SCREENENCODINGS = $(datadir)/screen/utf8encodings CC = @CC@ CFLAGS = @CFLAGS@ -Wall -Wextra -std=c17 -CPPFLAGS = @CPPFLAGS@ -I$(srcdir) -iquote. -DSCREENENCODINGS='"$(SCREENENCODINGS)"' -DBUILD_DATE='"$(BUILD_DATE)"' +CPPFLAGS = @CPPFLAGS@ -iquote. -iquote$(srcdir) -DSCREENENCODINGS='"$(SCREENENCODINGS)"' -DBUILD_DATE='"$(BUILD_DATE)"' LDFLAGS = @LDFLAGS@ LIBS = @LIBS@ -- 2.56.0.1.g8a5202d0c2 _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?68508> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
signature.asc
Description: PGP signature
