Author: jghali
Date: Sun May 27 19:34:45 2018
New Revision: 22562

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=22562
Log:
use const QString& instead of QString in function arguments in a few more places

Modified:
    trunk/Scribus/scribus/scribusdoc.cpp
    trunk/Scribus/scribus/scribusdoc.h

Modified: trunk/Scribus/scribus/scribusdoc.cpp
URL: 
http://scribus.net/websvn/diff.php?repname=Scribus&rev=22562&path=/trunk/Scribus/scribus/scribusdoc.cpp
==============================================================================
--- trunk/Scribus/scribus/scribusdoc.cpp        (original)
+++ trunk/Scribus/scribus/scribusdoc.cpp        Sun May 27 19:34:45 2018
@@ -4071,7 +4071,7 @@
        return results2;
 }
 
-QStringList ScribusDoc::getUsedPatternsHelper(QString pattern, QStringList 
&results) const
+QStringList ScribusDoc::getUsedPatternsHelper(const QString& pattern, 
QStringList &results) const
 {
        auto patIter = docPatterns.constFind(pattern);
        if (patIter == docPatterns.end())
@@ -4122,7 +4122,7 @@
        return results;
 }
 
-QStringList ScribusDoc::getPatternDependencyList(QStringList used) const
+QStringList ScribusDoc::getPatternDependencyList(const QStringList& used) const
 {
        QStringList results;
        QStringList pp;
@@ -4247,7 +4247,7 @@
        return results;
 }
 
-QStringList ScribusDoc::getUsedSymbolsHelper(QString pattern, QStringList 
&results) const
+QStringList ScribusDoc::getUsedSymbolsHelper(const QString& pattern, 
QStringList &results) const
 {
        auto patIter = docPatterns.constFind(pattern);
        if (patIter == docPatterns.end())

Modified: trunk/Scribus/scribus/scribusdoc.h
URL: 
http://scribus.net/websvn/diff.php?repname=Scribus&rev=22562&path=/trunk/Scribus/scribus/scribusdoc.h
==============================================================================
--- trunk/Scribus/scribus/scribusdoc.h  (original)
+++ trunk/Scribus/scribus/scribusdoc.h  Sun May 27 19:34:45 2018
@@ -705,13 +705,13 @@
        */
        QStringList getUsedPatterns() const;
        QStringList getUsedPatternsSelection(Selection* customSelection) const;
-       QStringList getUsedPatternsHelper(QString pattern, QStringList 
&results) const;
-       QStringList getPatternDependencyList(QStringList used) const;
+       QStringList getUsedPatternsHelper(const QString& pattern, QStringList 
&results) const;
+       QStringList getPatternDependencyList(const QStringList& used) const;
        /*!
        * @brief Builds a QStringList of the symbols used within the document
        */
        QStringList getUsedSymbols() const;
-       QStringList getUsedSymbolsHelper(QString pattern, QStringList &results) 
const;
+       QStringList getUsedSymbolsHelper(const QString& pattern, QStringList 
&results) const;
 
        /*!
        * @brief Check if document use Acrobat Form Fields


_______________________________________________
scribus-commit mailing list
scribus-commit@lists.scribus.net
http://lists.scribus.net/mailman/listinfo/scribus-commit

Reply via email to