Author: jghali
Date: Thu Oct 22 11:33:21 2020
New Revision: 24089
URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=24089
Log:
#16274: remove outdated FIXME <ale>
Modified:
trunk/Scribus/scribus/plugins/scriptplugin/cmdmani.cpp
trunk/Scribus/scribus/plugins/scriptplugin_py2x/cmdmani.cpp
Modified: trunk/Scribus/scribus/plugins/scriptplugin/cmdmani.cpp
URL:
http://scribus.net/websvn/diff.php?repname=Scribus&rev=24089&path=/trunk/Scribus/scribus/plugins/scriptplugin/cmdmani.cpp
==============================================================================
--- trunk/Scribus/scribus/plugins/scriptplugin/cmdmani.cpp (original)
+++ trunk/Scribus/scribus/plugins/scriptplugin/cmdmani.cpp Thu Oct 22
11:33:21 2020
@@ -11,9 +11,7 @@
#include "scribusview.h"
#include "sctextstream.h"
#include "selection.h"
-#include "ui/propertiespalette.h" //CB argh..
noooooooooooooooooooooooooooooooooooo FIXME see other FIXME
#include "undomanager.h"
-
PyObject *scribus_loadimage(PyObject* /* self */, PyObject* args)
{
@@ -505,6 +503,8 @@
PageItem *item = GetUniqueItem(QString::fromUtf8(name));
if (item == nullptr)
return nullptr;
+ // FIXME: Rather than toggling the lock, we should probably let the
user set the lock state
+ // and instead provide a different function like toggleLock()
item->toggleLock();
if (item->locked())
return PyLong_FromLong(1);
@@ -516,8 +516,6 @@
char *name = const_cast<char*>("");
if (!PyArg_ParseTuple(args, "|es", "utf-8", &name))
return nullptr;
- // FIXME: Rather than toggling the lock, we should probably let the
user set the lock state
- // and instead provide a different function like toggleLock()
if (!checkHaveDocument())
return nullptr;
PageItem *item = GetUniqueItem(QString::fromUtf8(name));
Modified: trunk/Scribus/scribus/plugins/scriptplugin_py2x/cmdmani.cpp
URL:
http://scribus.net/websvn/diff.php?repname=Scribus&rev=24089&path=/trunk/Scribus/scribus/plugins/scriptplugin_py2x/cmdmani.cpp
==============================================================================
--- trunk/Scribus/scribus/plugins/scriptplugin_py2x/cmdmani.cpp (original)
+++ trunk/Scribus/scribus/plugins/scriptplugin_py2x/cmdmani.cpp Thu Oct 22
11:33:21 2020
@@ -11,10 +11,7 @@
#include "scribusview.h"
#include "sctextstream.h"
#include "selection.h"
-#include "ui/propertiespalette.h" //CB argh..
noooooooooooooooooooooooooooooooooooo FIXME see other FIXME
-#include "ui/propertiespalette_image.h"
#include "undomanager.h"
-
PyObject *scribus_loadimage(PyObject* /* self */, PyObject* args)
{
@@ -506,6 +503,8 @@
PageItem *item = GetUniqueItem(QString::fromUtf8(name));
if (item == nullptr)
return nullptr;
+ // FIXME: Rather than toggling the lock, we should probably let the
user set the lock state
+ // and instead provide a different function like toggleLock()
item->toggleLock();
if (item->locked())
return PyInt_FromLong(1);
@@ -517,8 +516,6 @@
char *name = const_cast<char*>("");
if (!PyArg_ParseTuple(args, "|es", "utf-8", &name))
return nullptr;
- // FIXME: Rather than toggling the lock, we should probably let the
user set the lock state
- // and instead provide a different function like toggleLock()
if (!checkHaveDocument())
return nullptr;
PageItem *item = GetUniqueItem(QString::fromUtf8(name));
_______________________________________________
scribus-commit mailing list
[email protected]
http://lists.scribus.net/mailman/listinfo/scribus-commit
