On Mon, Aug 22, 2022 at 01:55:15AM -0300, Daniel Franzini wrote:
> The current status is:
>
> * in rev 13670: both builds pic14 and pic16 are fine without changes;
> * but there are some fixes needed in order to run the tests for these
> ports. Attached is a patch that provides the necessary fixes (one also
> needs to have gpsim installed and in the path for things to run or set the
> GPSIM_PATH variable with the path of gpsim;
Thanks Daniel.
-EXCLUDE_PORTS += \
- pic14 \
- pic16
+# EXCLUDE_PORTS += \
+# pic14 \
+# pic16
The use of EXCLUDE_PORTS here is indeed fishy. We might need some
configure logic to determine if gpsim is present... Or do we want pic
tests to just fail if there is no gpsim? Fine with me, what do others
think?
----
-EMU_INPUT = < $(PORTS_DIR)/$(PORT_BASE)/uCsim.cmd
+ifeq ($(PORT_BASE), pic14)
+EMU_INPUT = $(PORTS_DIR)/$(PORT_BASE)/gpsim.cmd
+EMU_EXTRA_FLAGS = -i -c
+else
+ifeq ($(PORT_BASE), pic16)
+EMU_INPUT = $(PORTS_DIR)/$(PORT_BASE)/gpsim.cmd
+EMU_EXTRA_FLAGS = -i -c
+else
+EMU_INPUT = $(PORTS_DIR)/$(PORT_BASE)/uCsim.cmd
+endif
+endif
Please move PORT specifics into spec.mk. EMU_INPUT is set before
[..]/${PORT}/spec.mk is included. Add
+# Default Simulator input argument. Override in spec.mk
EMU_INPUT = < $(PORTS_DIR)/$(PORT_BASE)/uCsim.cmd
Do we really need the EMU_EXTRA_FLAGS variable? Could you use EMU_FLAGS
in */spec.mk instead?
Best wishes
felix
_______________________________________________
Sdcc-user mailing list
Sdcc-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sdcc-user
