--- chromatic <[EMAIL PROTECTED]> wrote:
> On Fri, 2004-01-30 at 16:12, DH wrote:
> 
> > build is Build on case insensitive filesystems, so perl Build.PL will delete build,
> > and this is a problem since build has all your Module::Build subclass...
> 
> Good point; I'll rename it to build_libs unless someone comes up with a
> better name in the next few hours.
> 
> As a matter of idle curiosity, does it matter that build is a directory,
> whereas Build is a file?

makes no difference.

SDL::Build::MSWin32 does not exist, but i don't think Build.PL (or SDL::Build)
should die if it doesn't
(there's bound to be some platforms where a specific SDL::Build subclass may not exist,
or where one wouldn't be usefull, so it shouldn't matter)

Also, in SDL::Build, it'd be a good idea to check $includes->{$subsystem} actually 
contains a
reference, otherwise strict(?) will complain, something like the following should 
suffice

$file_flags{ $sub_file } = 
{
    extra_compiler_flags =>
    [
        ( $includes->{$subsystem} ? @{ $includes->{$subsystem} }  : () ),
        $sdl_compile,
        ( $defines->{$subsystem} ? @{ $defines->{$subsystem} }  : () ),
        '-fPIC',
    ],
    extra_linker_flags => 
    [
        ( $links->{$subsystem}{paths} ? @{ $links->{$subsystem}{paths} } : () ),
        $sdl_link,
        ( $links->{$subsystem}{libs} ? @{ $links->{$subsystem}{libs} } : () ),
    ],
},


__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free web site building tool. Try it!
http://webhosting.yahoo.com/ps/sb/

Reply via email to