Hi Glen, Your updated Ruby install means updated ERB. It is also possible that the new version of Rails is now prefering Erubis. Erubis isn't always 100% the same as the default ERB parser... and there have been a number of ERB bug fixes and tidies. The comment syntax you're using isn't really proper ERB (the syntax, not the library). If you want to do a code comment, you should probably leave the <% open. Does
<% =begin blah blah blah =end %> exhibit the same problems? I agree that tossing a spare <% -%> doesn't seem right. Rob On Wed, Jul 2, 2008 at 6:25 PM, Glenn Little <[EMAIL PROTECTED]> wrote: > > I agree to a point, but sometimes the comment is a block > of exposition explaining usage philosophy or some such. > I could see a valid argument being made about factoring > that elsewhere, but frankly sometimes a couple of lines of > explanation in the middle of code (even view code) is the > best place when sharing info between you and other programmers > (or future you). Another option I suppose would be converting > them all to the > > <%# > # > # > %> > > style, as unwieldy as that is. > > On the other hand, there are the practical considerations regarding > all the code that currently has this construct, including our > in-house code, various plugins we may have used, etc. > > I guess I was initially just wondering though if I had missed > something and inadvertently broken the comment parsing, or > if what I was seeing was really the way it is now. > > -glenn > > Patrick Crowley wrote: >>> But I'm not yet considering that a valid "fix". Just a symptom. >> >> >> The easiest fix is to not comment out lots of view code. ;) >> >> I generally avoid commenting out view code because it can cause a >> number of problems (code bloat, exposing templates to users, escaping >> issues, etc.). >> >> I'd move this code into a partial. That way, you can include it when >> you need it, and remove it when you don't... without hacks. >> >> -- Patrick >> >> >> >> > > > > > --~--~---------~--~----~------------~-------~--~----~ SD Ruby mailing list [email protected] http://groups.google.com/group/sdruby -~----------~----~----~----~------~----~------~--~---
