On Fri, Dec 10, 2010 at 10:33:28AM +0100, Gerd Hoffmann wrote: > Hi, > > >>+ u16 cmd; > > > >You have an unused variable here. > > Ah, right. Howcome gcc didn't warn me on this, usually it does ... > Is that warning turned off for seabios?
It warns for me. Compiling whole program out/ccode.16.s src/ahci.c: In function ‘ahci_init_controller’: src/ahci.c:437:9: warning: unused variable ‘cmd’ Maybe something with different gcc versions? $ gcc --version gcc (GCC) 4.5.1 20100924 (Red Hat 4.5.1-4) > >The patch series looks fine to me. If there's no further comments > >I'll commit this weekend. > > Want me respin? Do do you just zap the variable when committing? I can fix it if it's easier. -Kevin _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios