I applied this change.
-Kevin
On Tue, Dec 21, 2010 at 10:29:27PM +0100, Stefan Reinauer wrote:
> Hi,
>
> I made these two tiny changes to SeaBIOS when I was playing with the
> HEAD version.
>
> The Makefile change prevents the test command from failing if CC
> contains a space.
>
> The coreboot change prevents a warning on our gcc 4.5.2 in certain
> circumstances when sizeof seems to be unsigned long int instead of
> unsigned int.
>
> They're both unintrusive, shouldn't have potential for breaking
> anything.
>
> Stefan
>
>
> Signed-off-by: Stefan Reinauer <ste...@coreboot.org>
>
> --- Makefile 2010-12-21 13:21:07.179055000 -0800
> +++ Makefile 2010-12-21 13:21:52.129455000 -0800
> @@ -68,7 +68,7 @@
> ################ Build rules
>
> # Verify the gcc configuration and test if -fwhole-program works.
> -TESTGCC:=$(shell CC=$(CC) tools/test-gcc.sh)
> +TESTGCC:=$(shell CC="$(CC)" tools/test-gcc.sh)
> ifeq "$(TESTGCC)" "-1"
> $(error "Please upgrade GCC")
> endif
> --- src/coreboot.c 2010-12-21 13:21:07.278052000 -0800
> +++ src/coreboot.c 2010-12-21 13:23:03.782793000 -0800
> @@ -320,7 +320,7 @@
> u8 scratch[15980];
> int need = (LzmaGetNumProbs(&state.Properties) * sizeof(CProb));
> if (need > sizeof(scratch)) {
> - dprintf(1, "LzmaDecode need %d have %d\n", need, sizeof(scratch));
> + dprintf(1, "LzmaDecode need %d have %d\n", need, (unsigned
> int)sizeof(scratch));
> return -1;
> }
> state.Probs = (CProb *)scratch;
>
>
>
_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios
