On Thu, Apr 28, 2011 at 04:49:52PM +0200, Gerd Hoffmann wrote:
> This patch makes the memory window for PCI
> memory bars configurable via Kconfig.

These BUILD_PCI* variables are only used by four lines of code in
pciinit.c.  The code only uses BUILD_PCIMEM_START, BUILD_PCIMEM_END,
BUILD_PCIPREFMEM_START, BUILD_PCIPREFMEM_END.

I think it would be better to define the kconfig variables needed (eg,
PCIMEM_START, PCIMEM_SIZE, PCIMEM_PREFMEM_SIZE) and then change the
pciinit.c code to use the CONFIG_* variables directly.

-Kevin

_______________________________________________
SeaBIOS mailing list
[email protected]
http://www.seabios.org/mailman/listinfo/seabios

Reply via email to