On Mon, Jul 04, 2011 at 04:11:11PM +0800, Wayne Xia wrote: > 2011-7-3 6:57, Kevin O'Connor: > >On Mon, Jun 27, 2011 at 03:10:38PM +0800, Wayne Xia wrote: > >>+void raw_data_format_adjust_24bpp(u8 *src, u8 *dest, int width, int height, > >>+ int bytes_per_line_src, int bytes_per_line_dest, u8 > >>switch_flag) > > > >This should be declared static. Also, doesn't this function just > >become a series of memcpy calls now that bytes_per_line_dest and > >switch_flag aren't needed? > > > changed to static. But I am afraid this function need to be called by > the "bmp_show" to switch vertical line sequence and adjust data > location.
My point is that the two parameters "bytes_per_line_dest" and "switch_flag" are no longer needed, and therefore the function can be simplified. > >Thanks. It would be preferable if the jpeg fixes were in a separate > >patch from the bmp feature addition. > > > split it as a single patch. Thanks. -Kevin _______________________________________________ SeaBIOS mailing list [email protected] http://www.seabios.org/mailman/listinfo/seabios
