On 05/18/12 05:16, Kevin O'Connor wrote: > On Tue, May 15, 2012 at 12:46:21PM +0200, Gerd Hoffmann wrote: >> Almost every linux distro has iasl packaged these days. >> Lets make it a build dependency and stop the hassle we >> have with updating the *.hex files in the git repo. > > I'm a bit torn on this. I see the gain in that it simplifies the > build and makes patches smaller.
Patch conflicts in the generated files are a pain too. > It also allows include files (eg, > config.h) to be pulled into the asl code so that symbolic names can be > shared. Iasl is easily available from most distros, but it isn't > installed by default. I don't want to scare off any casual users that > download the git tree and attempt to compile. We can detect iasl and print a friendly message in case it isn't there, see attached patch. Comments? And, yes, we probably want move them to out/ as suggested by Marc in case we'll go that route. cheers, Gerd
>From 714e20e0bbcc69f8745acea44eea7e50bc4eac53 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann <[email protected]> Date: Tue, 22 May 2012 11:42:15 +0200 Subject: [PATCH] iasl detection Signed-off-by: Gerd Hoffmann <[email protected]> --- Makefile | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 2a5adfe..f67b89f 100644 --- a/Makefile +++ b/Makefile @@ -62,7 +62,15 @@ OBJCOPY=objcopy OBJDUMP=objdump STRIP=strip PYTHON=python -IASL:=iasl +IASL:=$(shell which iasl 2>/dev/null) + +ifeq "$(IASL)" "" +iasl-not-found: + @echo "You need 'iasl' to compile seabios." + @echo "Most likely your distro has packages for you," + @echo "try asking the package manager to install it." + @false +endif # Default targets -include $(KCONFIG_CONFIG) -- 1.7.1
_______________________________________________ SeaBIOS mailing list [email protected] http://www.seabios.org/mailman/listinfo/seabios
