Kevin O'Connor <[email protected]> writes: > On Tue, Jun 12, 2012 at 09:20:23AM +0200, Sven Schnelle wrote: > [...] >> That patch wasn't complete, sorry. I've attached another version ;) > [...] >> struct ehci_qh { >> u32 next; >> @@ -102,8 +102,8 @@ struct ehci_qh { >> u32 alt_next; >> u32 token; >> u32 buf[5]; >> - // u32 buf_hi[5]; >> -} PACKED; >> + u32 buf_hi[5]; >> +} PACKED __aligned(EHCI_QH_ALIGN); > > I don't think the ehci_qh needs to be padded to 128 bytes as it isn't > allocated in arrays. Not specifiying the alignment allows the other > fields in the ehci_pipe struct to use that pad space instead of it > being wasted. Let me know if I've missed something.
You didn't miss anything. it's ok to remove that padding. > How about the below? > [..] Looks ok to me. Regards Sven _______________________________________________ SeaBIOS mailing list [email protected] http://www.seabios.org/mailman/listinfo/seabios
