On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost <[email protected]> wrote: > On Sat, Jul 14, 2012 at 09:14:30AM +0000, Blue Swirl wrote: > [...] >> >> > diff --git a/tests/Makefile b/tests/Makefile >> >> > index b605e14..89bd890 100644 >> >> > --- a/tests/Makefile >> >> > +++ b/tests/Makefile >> >> > @@ -15,6 +15,7 @@ check-unit-y += >> >> > tests/test-string-output-visitor$(EXESUF) >> >> > check-unit-y += tests/test-coroutine$(EXESUF) >> >> > check-unit-y += tests/test-visitor-serialization$(EXESUF) >> >> > check-unit-y += tests/test-iov$(EXESUF) >> >> > +check-unit-y += tests/test-x86-cpuid$(EXESUF) >> >> >> >> This probably tries to build the cpuid test also for non-x86 targets >> >> and break them all. >> > >> > I don't think there's any concept of "targets" for the check-unit tests. >> >> How about: >> check-qtest-i386-y = tests/test-x86-cpuid$(EXESUF) > > test-x86-cpuid is not a qtest test case.
Why not? I don't think it is a unit test either, judging from what the other unit tests do. > >> >> > I had to do the following, to be able to make a test that uses the >> > target-i386 code: >> > >> >> > +tests/test-x86-cpuid.o: QEMU_INCLUDES += -Itarget-i386 >> > >> > Any suggestions to avoid this hack would be welcome. >> >> Maybe it would be simpler to adjust #include path in the file. > > Using the full path on the #include line would break in case > target-i386/topology.h include other files from the target-i386 > directory. That's fragile. Maybe the target-xyz files should use the full path. > > -- > Eduardo _______________________________________________ SeaBIOS mailing list [email protected] http://www.seabios.org/mailman/listinfo/seabios
