> On 28 Nov 2018, at 22:17, Laszlo Ersek <ler...@redhat.com> wrote: > > On 11/28/18 16:54, Liran Alon wrote: >> From: Arbel Moshe <arbel.mo...@oracle.com> >> >> Add support for obsolete SMBIOS Type 6 which describes the speed, type, >> size and error status of each system memory module. >> >> This is required by some guests to boot successfully. >> >> Such an example is Cisco NGFW appliance which has a script which >> runs every boot that parses this SMBIOS Type 6 information and if >> it doesn't exists, it just fails to boot with an error of >> "Unable to parse dmidecode. Restarting now!". >> >> Reviewed-by: Liran Alon <liran.a...@oracle.com> >> Reviewed-by: Ross Philipson <ross.philip...@oracle.com> >> Signed-off-by: Arbel Moshe <arbel.mo...@oracle.com> >> --- >> src/fw/smbios.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > > This file starts with the following two lines: > > // smbios table generation (on emulators) > // DO NOT ADD NEW FEATURES HERE. (See paravirt.c / biostables.c instead.) > > Please consider extending the SMBIOS generator in QEMU instead. > > Thanks > Laszlo
I thought originally that QEMU SMBIOS generator is used only for non-legacy SMBIOS. But seems like I was wrong and indeed can use SMBIOS_TABLE_ENTRY entry on QEMU_CFG_SMBIOS_ENTRIES. Will need to submit patches to QEMU then… Thanks, -Liran _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios
