Gerd, thank you very much for a review. I'll test more, and - if it turns out that it always initializes successfully on a 2nd attempt without any extra sleeps (or maybe 3rd in some really rare not-observed-yet cases), I could modify this patch so that it will still "return;" but only after i.e. 3rd attempt is unsuccessful ---> reducing the wasted time to a couple of milliseconds or even less. Hopefully this patch would be more acceptable in such a version.
cheers, Mike On Wed, Jun 5, 2019 at 10:46 AM Gerd Hoffmann <kra...@redhat.com> wrote: > > On Tue, Jun 04, 2019 at 09:07:44PM +0300, Mike Banon wrote: > > At least some USB drives with a write protect switch (e.g. Netac U335) > > could report "MEDIUM NOT PRESENT" for a while if a write protect is > > enabled. > > Broken hardware. > Lovely. > > > Do not stop the initialization attempts after getting this, > > and the initialization will be successful - likely on a 2nd attempt. > > That change may drastically increase boot time. If you have an empty > cdrom drive connected to your machine seabios will poll the device for > five seconds no matter what for no good reason instead of simply > stopping because no cdrom is inserted. > > So, no. Not going to happen. We need something else. I have no good > idea how to handle that without a blacklist of known-broken devices > though ... > > cheers, > Gerd > _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-le...@seabios.org
