On Mon, Oct 21, 2019 at 10:33:19PM +0200, Uwe Kleine-König wrote: > Hello Kevin, > > On 10/21/19 5:31 PM, Kevin O'Connor wrote: > > Update the documentation to be explicit about the signed-off-by > > convention. > [...] >The best match for this patch would be (a) in the DCO, > but there is no "open source license indicated in the file" > (vgasrc/svgamodes.c)
The lack of a copyright statement on svgamodes.c appears to be an ommission in commit 004f5b3a where the contents of that file were created from another file without copying over the license statement. I will submit a fix for it. > I like this change in general. Note however that I could not have > signed-off my patch that resulted in > fc92d092ea4f704bc4d283c3911ee9894733f4ce according to the rules you > introduce here. I don't want to be nitpicky, but it is unclear if you are uncomfortable with the submission. If you are, please state that and I will revert the commit. We do try to make the copyrights and submission process transparent. I don't feel the license or process has been unclear. The DCO was indirectly documented before via the QEMU documentation: https://www.seabios.org/Contributing states the process follows: http://wiki.qemu.org/Contribute/SubmitAPatch The SeaBIOS license is in the COPYING and COPYING.LESSER files in the git repo. Thanks, -Kevin _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-le...@seabios.org
