Dear Gerd,

Am 25.06.20 um 11:17 schrieb Gerd Hoffmann:
Little mistake, big effect.  The patch adding the ati driver broke
cirrus due to a missing "else", which effectively downgrades cirrus
to standard vga.

What is an easy test with QEMU to figure out, that only standard vga is used?

Fixes: 34b6ecc16074 ("vga: add atiext driver")
Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
---
  vgasrc/vgahw.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vgasrc/vgahw.h b/vgasrc/vgahw.h
index c774f4f2c6b7..8b64660e5ef7 100644
--- a/vgasrc/vgahw.h
+++ b/vgasrc/vgahw.h
@@ -36,7 +36,7 @@ static inline int vgahw_set_mode(struct vgamode_s *vmode_g, 
int flags) {
  static inline void vgahw_list_modes(u16 seg, u16 *dest, u16 *last) {
      if (CONFIG_VGA_CIRRUS)
          clext_list_modes(seg, dest, last);
-    if (CONFIG_VGA_ATI)
+    else if (CONFIG_VGA_ATI)
          ati_list_modes(seg, dest, last);
      else if (CONFIG_VGA_BOCHS)
          bochsvga_list_modes(seg, dest, last);

Reviewed-by: Paul Menzel <pmen...@molgen.mpg.de>


Kind regards,

Paul
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org

Reply via email to