Hi,
> Add support for all high-definition and quad extended graphics array
> resolutions as listed on Wikipedia.
> Also fixed some indentation so the mode values would all align and
> changed a few of the hex identifiers at the start of the list to use
> lowercase instead of uppercase letters to comply with the style of the
> the rest of the modes in the struct.
Can you split that into two patches please? One for the reformating
and one for the new modes?
> + /* other high-definition resolutions */
> + { 0x196, { MM_DIRECT, 960, 540, 16, 8, 16, SEG_GRAPH } },
> + { 0x197, { MM_DIRECT, 960, 540, 24, 8, 16, SEG_GRAPH } },
> + { 0x198, { MM_DIRECT, 960, 540, 32, 8, 16, SEG_GRAPH } },
Also I'm wondering whenever it makes sense to support 16+24+32 bpp for
highres modes? The lowres modes (say FullHD and smaller) need that for
compatibility reasons with really old systems. For highres I don't see
the point though. In modern systems 32bpp is used almost exclusively.
16bpp plays a niche role when you are short on video memory. 24bpp is
simply not used any more.
take care,
Gerd
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
