Hi Gerd, Yes, you are right. I think reading these two config register is fine during init and align with the virtio blk spec. In the near future, we will working on some related work on these two value. To be specific, we will do some modification in virtio blk driver. If driver reads data larger than VIRTIO_BLK_F_SIZE_MAX, it will cause some issue to the DMA engine. To be frankly, I think our future work will have more discussion, so I think it is better to merge these two register reading first.
-----Original Message----- From: Gerd Hoffmann <kra...@redhat.com> Sent: Monday, November 29, 2021 6:53 PM To: Pei, Andy <andy....@intel.com> Cc: seabios@seabios.org; ke...@koconnor.net; Ding Limin <dingli...@cmss.chinamobile.com> Subject: Re: [PATCH v2] src/hw/virtio-blk: add feature VIRTIO_BLK_F_SIZE_MAX and VIRTIO_BLK_F_SEG_MAX On Fri, Nov 26, 2021 at 04:06:23PM +0800, Andy Pei wrote: > according to virtio spec, add feature VIRTIO_BLK_F_SIZE_MAX and > VIRTIO_BLK_F_SEG_MAX parse to virtio blk driver. Why is this needed? The code never actually uses max_segment_size and max_segments (other than logging the values) ... take care, Gerd _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-le...@seabios.org
