Reply in line

> +        if (features & max_segment_size)
> +            vdrive->drive.max_segment_size =
> +                vp_read(&vp->device, struct virtio_blk_config, 
> + size_max);

> +        else
> +            vdrive->drive.max_segment_size = 0;

Not needed, there is a memset(0) for the complete vdrive struct.
Andy: OK, address it in V4.

> +        dprintf(3, "virtio-blk %pP size_max=%u.\n", pci,
> +                vdrive->drive.max_segment_size);

Can you just add that to the existing dprintf instead of adding a new line to 
the log?
Andy: OK, address it in V4.

thanks,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org

Reply via email to