On Tue, Jan 28, 2025 at 09:14:43AM +0100, Gerd Hoffmann wrote:
> On Tue, Jan 21, 2025 at 11:59:14AM -0500, Christopher Lentocha wrote:
> >
> > For whatever reason, when you compile SeaBIOS in Csm16 mode, and use it
> > under EDK2's OvmfPkg, the ATA_CMD_IDENTIFY_PACKET_DEVICE command
> > doesn't work properly, therefore, SeaBIOS detects the "SATA HARDDISK"
> > as a "SATA CDROM" device, in QEMU. Despite the Tianocore developers
> > seem to have removed support for Csm16 some time ago, if we decide to
> > remove Csm16 mode in SeaBIOS in favor of that, at least we have the
> > last commit of Csm16 working properly and not half-broken. In order to
> > fix this bug, I decided to add another command, that command being
> > ATA_CMD_DEVICE_RESET, right before the ATA_CMD_IDENTIFY_PACKET_DEVICE
> > command is called.
> >
> > Signed-off-by: Christopher Lentocha <christopherericlento...@gmail.com>
> 
> Reviewed-by: Gerd Hoffmann <kra...@redhat.com>

Sounds good.

Gerd, since you reviewed and you're more familiar with this code, feel
free to also commit.

Cheers,
-Kevin

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org

Reply via email to