|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
_______________________________________________ seam-issues mailing list seam-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/seam-issues
Synchronization on the "factory instance" is not enough, as you may have e.g. an event scoped component that contains a @Factory(scope = APPLICATION) factory, so the "factory instance" (which is in fact the component instance that contains the factory method) would be different, so it wouldn't stop the factory method to be called in parallel, so we'd go back to the "IllegalArgumentException: factory method with defined scope outjected a value ..." issue (see the Seam_2_3 branch org.jboss.seam.test.integration.ConcurrentFactoryTest (which fails with this patch most of the time))
Synchronization on factoryMethod would probably make more sense, although that is also not a complete fix, as it won't completely fix JBSEAM-4993 ( sameFactoryLock test in org.jboss.seam.test.integration.FactoryLockTest fails)