Thanks, Stephen. I will post my fix to this mailing list first. Thanks for the suggestion. Alice ________________________________________ From: Stephen Smalley [[email protected]] Sent: Friday, December 21, 2012 5:06 AM To: Alice Chu Cc: [email protected] Subject: Re: Where to submit code for review
On 12/20/2012 05:43 PM, Alice Chu wrote: > Hi, > > Can someone tell me where to submit changes to review for: > external/checkpolicy > external/libsepol > external/libselinux > > We ran Klocwork on these components. I am now fixing issues found by Klocwork > on code from seandroid master branch. > I would like to know where to submit the changes to review so that the > changes will go into seandroid master branch. > > Is the following the correct command format to submit? > git push https://android-review.googlesource.com/platform/external/<proj> > fix_kw:refs/for/master > If you aren't sure about the fixes, you might post them here or to the selinux mailing list first as an RFC. Any changes to libsepol or checkpolicy should be submitted to the selinux mailing list first since they are directly taken from the upstream SELinux release versions. Since the Android libselinux is a heavily modified fork of the upstream libselinux, you can just post changes for it to this list and we'll sort out which if any of them apply to the upstream SELinux. When you are confident of the fixes, you can upload them to the AOSP gerrit server in the usual manner as per: http://source.android.com/source/submit-patches.html And we'll cherry-pick them into our seandroid branches once we've reviewed them, and ultimately merge them back into master once AOSP accepts them. Unfortunately there is a bit of a backlog in AOSP for our changes, and I'm not sure why or when that will clear up. Note that many people will be out of office for the next couple of weeks, so don't expect immediate responses. -- This message was distributed to subscribers of the seandroid-list mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe seandroid-list" without quotes as the message.
