On 12/21/2012 08:40 PM, Alice Chu wrote:
Hello,
This is for external/libsepol.
Attached you will find the Klocwork report on external/libsepol and my fix in a
patch. The change is done on master branch.
Some of the Klocwork findings are, I think, false positive. I keep them in the
report so that you can go over one more time.
Please review my change and let me know any additional correction I should make.
Thank you very much for the feedback.
As with the checkpolicy patch, this should go first to selinux list
since libsepol in Android is a direct copy of the upstream SELinux
libsepol. And it would help to have the patch inlined for review. A
few obvious initial comments:
- Various NULL initializations and tests for NULL appear to be
unnecessary to me. Did you confirm that they are truly needed or just
blindly "fix" based on the output of your tool? Let's not change code
just to appease some tool.
- It would be cleaner to define a symtab_destroy or symtab_free helper
and use it throughout.
--
This message was distributed to subscribers of the seandroid-list mailing list.
If you no longer wish to subscribe, send mail to majord...@tycho.nsa.gov with
the words "unsubscribe seandroid-list" without quotes as the message.
