[389-devel] Please review: [389 Project] #47608: change slapi_entry_attr_get_bool to handle "on"/"off" values, support default value

[Noriko Hosoi]

https://fedorahosted.org/389/ticket/47608

https://fedorahosted.org/389/attachment/ticket/47608/0001-Ticket-47608-change-slapi_entry_attr_get_bool-to-han.patch

Description: Adding an API slapi_entry_attr_get_bool_ext, which is an 
extension of slapi_entry_attr_get_bool. The difference is slapi_ 
entry_attr_get_bool_ext returns the given default value if the type is 
not found in the entry.


Does this satisfy the requirement?
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (take 2): [389 Project] #47677: Size returned by slapi_entry_size is not accurate

[Noriko Hosoi]

https://fedorahosted.org/389/ticket/47677

https://fedorahosted.org/389/attachment/ticket/47677/0001-Ticket-47677-Size-returned-by-slapi_entry_size-is-no.2.patch

 Description: slapi_entry_size calculating the entry size had issues.
 . To calculate the Slapi_DN size, local function slapi_dn_size was used.
   slapi_dn_size internally calls slapi_sdn_get_dn and slapi_sdn_get_ndn.
   The calls generates normalized dn and case lowered normalized dn from
   raw dn udn if the normalized dn are not stored in Slapi_DN yet.  I.e.,
   the get size function allocates extra memory for the normalized dn.
   Local slapi_dn_size also failed to count the raw dn length.  This patch
   replaces slapi_dn_size with (slapi_sdn_get_size - sizeof(Slapi_DN)).
 . slapi_entry_size counted Slapi_RDN twice.
 . slapi_entry_size did not count the size of e_virtual_lock, e_aux_attrs
   and e_extension.


--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] mmr.pl deprecated?

[Rich Megginson]

On 02/09/2014 02:29 PM, Paul Robert Marino wrote:

I just noticed on the wiki that it says mmr.pl is deprecated because
its "it is too buggy and has no maintainer"


There is no dedicated source code repo for it.
There is no place to file bugs/tickets against it.
There is no one to fix the bugs/tickets.



I'm just curious if there is a punch list of the bugs I might be
willing to tackle them if so.


Not that I know of, just various emails/irc messages over the years.


Ive always found it to be a useful tool
and I prefer not to click my mouse a hundred times when a command line
script could do the job.
I'm not saying I would definitely be willing to become the maintainer
on a long term basis because I have too many project on my plate as it
is, just that I would be willing to take some time to do any updates
and bug fixes as I have time and possibly be willing to act as an
temporary maintainer for a brief period of time.

The code is fairly strait forward and at the least I could make the
option parsing a lot more robust and the error messages far more
helpful.
The coding style is outdated and could use probably prototyping on the
subroutines.
Further more it might be useful to accept a config file and or
environment variables for some of the information for example I hate
putting passwords on the command line.
I can also see that there are a lot more options that would be nice to
be able to tune.
but if there is a bug list I would be happy to spend some time on it
and see how many I could run through in a short period of time.
A quick search of bugzilla.redhat.com didn't seam to show any thing as
far as I could tell


It would probably be easiest to make a github repo for mmr.pl and use 
that for tracking changes, bugs/tickets, documentation.



--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel


--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel