Jenkins build is back to normal : amarok_master #340

2013-04-13 Thread KDE CI System 
See 

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-13 Thread Harsh Gupta 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/
---

(Updated April 13, 2013, 9:44 p.m.)


Review request for Amarok.


Changes
---

Second patch :  Bug fixed.


Description
---

1. Disabled Pre-amplifier in equalizer if it is not supported by phonon.
2. Fixed top and bottom labels of first slider. Earlier band name label was at 
the top and slider value label was at the bottom for first slider.
3. Removed an extra semicolon EqualizerDialog.h .
Note : I have made an assumption that if at all preamp is present then it will 
the first element of Effect Parameter list.


This addresses bug 301311.
https://bugs.kde.org/show_bug.cgi?id=301311


Diffs (updated)
-

  ChangeLog a278be3 
  src/EngineController.h 5de4beb 
  src/EngineController.cpp 28fb256 
  src/dialogs/EqualizerDialog.cpp f42a033 
  src/dialogs/EqualizerDialog.ui 43b0187 

Diff: http://git.reviewboard.kde.org/r/108995/diff/


Testing
---

All unit test cases passed.
Note : I have tested it with gstreamer only. Xine phonon keep crashing on my PC.


File Attachments


Equalizer snapshot
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png


Thanks,

Harsh Gupta

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109984: Renamed attribute names to match Amarok coding style.

2013-04-13 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109984/
---

(Updated April 13, 2013, 2 p.m.)


Status
--

This change has been marked as submitted.


Review request for Amarok.


Description
---

Renamed attribute names to match Amarok coding style.
Note : This patch must be applied before "FIX Pre-amplifier in equalizer 
doesn't work" patch.


Diffs
-

  src/dialogs/EqualizerDialog.cpp 7299e9a 
  src/dialogs/EqualizerDialog.h fd9032b 
  src/EngineController.cpp 86ad837 

Diff: http://git.reviewboard.kde.org/r/109984/diff/


Testing
---

Ok


Thanks,

Harsh Gupta

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109984: Renamed attribute names to match Amarok coding style.

2013-04-13 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109984/#review30988
---


This review has been submitted with commit 
8d4001baf95bf726e038a5feb0f5ffaa0c76a819 by Matěj Laitl on behalf of Harsh 
Gupta to branch master.

- Commit Hook


On April 12, 2013, 10:37 p.m., Harsh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109984/
> ---
> 
> (Updated April 12, 2013, 10:37 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Renamed attribute names to match Amarok coding style.
> Note : This patch must be applied before "FIX Pre-amplifier in equalizer 
> doesn't work" patch.
> 
> 
> Diffs
> -
> 
>   src/dialogs/EqualizerDialog.cpp 7299e9a 
>   src/dialogs/EqualizerDialog.h fd9032b 
>   src/EngineController.cpp 86ad837 
> 
> Diff: http://git.reviewboard.kde.org/r/109984/diff/
> 
> 
> Testing
> ---
> 
> Ok
> 
> 
> Thanks,
> 
> Harsh Gupta
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-13 Thread Anmol Ahuja 


> On April 12, 2013, 5:45 a.m., Matěj Laitl wrote:
> > src/playlist/PlaylistModel.cpp, lines 361-366
> > 
> >
> > Thinking about it more, the logic should be following:
> > 
> > if( s_showToolTip )
> > toolTipForTrack() // contains logic for showing not played notice 
> > if track isn't playable
> > else if( !track->notPlayebleReason().isEmpty() )
> > return i18n( "Note: the track is not playable.\n%1", 
> > notPlayableReason );  // i.e. just show the notice if s_showToolTip is false

Can't I just check if( !track->isPlayable() )?


- Anmol


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109817/#review30947
---


On April 13, 2013, 7:08 p.m., Anmol Ahuja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109817/
> ---
> 
> (Updated April 13, 2013, 7:08 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> 1. Added notPlayableReason() and prettyNotPlayableReason() to class Track
> 2. Display track tooltip with the prettyNotPlayableReason() if track not 
> playable
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/daap/DaapMeta.cpp e66afb7 
>   src/core-impl/collections/daap/DaapMeta.h 9a9c257 
>   src/core-impl/collections/db/sql/SqlMeta.h b7f0a71 
>   src/core-impl/collections/db/sql/SqlMeta.cpp 19ec936 
>   src/core-impl/collections/ipodcollection/IpodMeta.h 1d380b1 
>   src/core-impl/collections/ipodcollection/IpodMeta.cpp 9ffcf7e 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h 5d1b9f9 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 2b66574 
>   src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h 27ff06d 
>   src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp 6d5bcf7 
>   src/core-impl/collections/playdarcollection/PlaydarMeta.h 7a39a4f 
>   src/core-impl/collections/playdarcollection/PlaydarMeta.cpp 5f4ec3c 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.h ef342a4 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp e58a20a 
>   src/core-impl/collections/support/MemoryMeta.h 40061d2 
>   src/core-impl/collections/upnpcollection/UpnpMeta.h 55bc131 
>   src/core-impl/collections/upnpcollection/UpnpMeta.cpp 00cc915 
>   src/core-impl/meta/file/File.h 7d3359d 
>   src/core-impl/meta/file/File.cpp 2cd0a61 
>   src/core-impl/meta/multi/MultiTrack.h be55170 
>   src/core-impl/meta/proxy/MetaProxy.h 15967df 
>   src/core-impl/meta/proxy/MetaProxy.cpp 6a35bc5 
>   src/core-impl/meta/stream/Stream.h 3e19b45 
>   src/core-impl/meta/stream/Stream.cpp 6e35960 
>   src/core/meta/Meta.h f86cf39 
>   src/playlist/PlaylistModel.cpp 246b9a1 
>   src/services/ampache/AmpacheMeta.h 934fe75 
>   src/services/ampache/AmpacheMeta.cpp b59715c 
>   src/services/lastfm/meta/LastFmMeta.h 9c54a10 
>   src/services/lastfm/meta/LastFmMeta.cpp 424d136 
> 
> Diff: http://git.reviewboard.kde.org/r/109817/diff/
> 
> 
> Testing
> ---
> 
> Works as expected
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-13 Thread Anmol Ahuja 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109817/
---

(Updated April 13, 2013, 7:08 p.m.)


Review request for Amarok.


Description
---

1. Added notPlayableReason() and prettyNotPlayableReason() to class Track
2. Display track tooltip with the prettyNotPlayableReason() if track not 
playable


Diffs (updated)
-

  src/core-impl/collections/daap/DaapMeta.cpp e66afb7 
  src/core-impl/collections/daap/DaapMeta.h 9a9c257 
  src/core-impl/collections/db/sql/SqlMeta.h b7f0a71 
  src/core-impl/collections/db/sql/SqlMeta.cpp 19ec936 
  src/core-impl/collections/ipodcollection/IpodMeta.h 1d380b1 
  src/core-impl/collections/ipodcollection/IpodMeta.cpp 9ffcf7e 
  src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h 5d1b9f9 
  src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 2b66574 
  src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h 27ff06d 
  src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp 6d5bcf7 
  src/core-impl/collections/playdarcollection/PlaydarMeta.h 7a39a4f 
  src/core-impl/collections/playdarcollection/PlaydarMeta.cpp 5f4ec3c 
  src/core-impl/collections/proxycollection/ProxyCollectionMeta.h ef342a4 
  src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp e58a20a 
  src/core-impl/collections/support/MemoryMeta.h 40061d2 
  src/core-impl/collections/upnpcollection/UpnpMeta.h 55bc131 
  src/core-impl/collections/upnpcollection/UpnpMeta.cpp 00cc915 
  src/core-impl/meta/file/File.h 7d3359d 
  src/core-impl/meta/file/File.cpp 2cd0a61 
  src/core-impl/meta/multi/MultiTrack.h be55170 
  src/core-impl/meta/proxy/MetaProxy.h 15967df 
  src/core-impl/meta/proxy/MetaProxy.cpp 6a35bc5 
  src/core-impl/meta/stream/Stream.h 3e19b45 
  src/core-impl/meta/stream/Stream.cpp 6e35960 
  src/core/meta/Meta.h f86cf39 
  src/playlist/PlaylistModel.cpp 246b9a1 
  src/services/ampache/AmpacheMeta.h 934fe75 
  src/services/ampache/AmpacheMeta.cpp b59715c 
  src/services/lastfm/meta/LastFmMeta.h 9c54a10 
  src/services/lastfm/meta/LastFmMeta.cpp 424d136 

Diff: http://git.reviewboard.kde.org/r/109817/diff/


Testing
---

Works as expected


Thanks,

Anmol Ahuja

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109758: Asx playlist implementation.

2013-04-13 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109758/#review30985
---


Sorry, I errorneously pushed something I didn't want to. However I've hit 
Ctrl+C during the push, it seems that the commit hooks fired, but the commits 
might not have hit Amarok master.

- Matěj Laitl


On April 13, 2013, 12:50 p.m., Tatjana Gornak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109758/
> ---
> 
> (Updated April 13, 2013, 12:50 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Asx playlist implementation.
> 
> P.S. This patch make sense only if https://git.reviewboard.kde.org/r/107473/ 
> will be accepted
> 
> 
> This addresses bug 170207.
> https://bugs.kde.org/show_bug.cgi?id=170207
> 
> 
> Diffs
> -
> 
>   ChangeLog 7b394ac 
>   src/CMakeLists.txt d667d95 
>   src/MainWindow.cpp 07dca94 
>   src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp e19769d 
>   src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 82de3a6 
>   src/core-impl/playlists/types/file/asx/ASXPlaylist.h PRE-CREATION 
>   src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION 
>   src/core/playlists/PlaylistFormat.cpp 6b3cb6b 
>   src/playlistmanager/file/PlaylistFileProvider.cpp 4a5639e 
>   tests/core-impl/playlists/types/file/CMakeLists.txt ef69236 
>   tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h PRE-CREATION 
>   tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109758/diff/
> 
> 
> Testing
> ---
> 
> Loading and saving works
> 
> 
> Thanks,
> 
> Tatjana Gornak
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109758: Asx playlist implementation.

2013-04-13 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109758/
---

(Updated April 13, 2013, 12:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for Amarok.


Description
---

Asx playlist implementation.

P.S. This patch make sense only if https://git.reviewboard.kde.org/r/107473/ 
will be accepted


This addresses bug 170207.
https://bugs.kde.org/show_bug.cgi?id=170207


Diffs
-

  ChangeLog 7b394ac 
  src/CMakeLists.txt d667d95 
  src/MainWindow.cpp 07dca94 
  src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp e19769d 
  src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 82de3a6 
  src/core-impl/playlists/types/file/asx/ASXPlaylist.h PRE-CREATION 
  src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION 
  src/core/playlists/PlaylistFormat.cpp 6b3cb6b 
  src/playlistmanager/file/PlaylistFileProvider.cpp 4a5639e 
  tests/core-impl/playlists/types/file/CMakeLists.txt ef69236 
  tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h PRE-CREATION 
  tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109758/diff/


Testing
---

Loading and saving works


Thanks,

Tatjana Gornak

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109758: Asx playlist implementation.

2013-04-13 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109758/#review30984
---


This review has been submitted with commit 
c91a2017116789ecb5c63c7e850cb69cfeb6b6f1 by Matěj Laitl on behalf of Tatjana 
Gornak to branch master.

- Commit Hook


On April 9, 2013, 8:24 p.m., Tatjana Gornak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109758/
> ---
> 
> (Updated April 9, 2013, 8:24 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Asx playlist implementation.
> 
> P.S. This patch make sense only if https://git.reviewboard.kde.org/r/107473/ 
> will be accepted
> 
> 
> This addresses bug 170207.
> https://bugs.kde.org/show_bug.cgi?id=170207
> 
> 
> Diffs
> -
> 
>   ChangeLog 7b394ac 
>   src/CMakeLists.txt d667d95 
>   src/MainWindow.cpp 07dca94 
>   src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp e19769d 
>   src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 82de3a6 
>   src/core-impl/playlists/types/file/asx/ASXPlaylist.h PRE-CREATION 
>   src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION 
>   src/core/playlists/PlaylistFormat.cpp 6b3cb6b 
>   src/playlistmanager/file/PlaylistFileProvider.cpp 4a5639e 
>   tests/core-impl/playlists/types/file/CMakeLists.txt ef69236 
>   tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h PRE-CREATION 
>   tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109758/diff/
> 
> 
> Testing
> ---
> 
> Loading and saving works
> 
> 
> Thanks,
> 
> Tatjana Gornak
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109984: Renamed attribute names to match Amarok coding style.

2013-04-13 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109984/#review30983
---

Ship it!


Looks good, thanks!

- Matěj Laitl


On April 12, 2013, 10:37 p.m., Harsh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109984/
> ---
> 
> (Updated April 12, 2013, 10:37 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Renamed attribute names to match Amarok coding style.
> Note : This patch must be applied before "FIX Pre-amplifier in equalizer 
> doesn't work" patch.
> 
> 
> Diffs
> -
> 
>   src/dialogs/EqualizerDialog.cpp 7299e9a 
>   src/dialogs/EqualizerDialog.h fd9032b 
>   src/EngineController.cpp 86ad837 
> 
> Diff: http://git.reviewboard.kde.org/r/109984/diff/
> 
> 
> Testing
> ---
> 
> Ok
> 
> 
> Thanks,
> 
> Harsh Gupta
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Release of libmygpo-qt v1.0.7

2013-04-13 Thread Stefan Derkits 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear Amarok, Clementine & gPodder Community,

after exactly half a year, a new version of libmygpo-qt is ready.

Changes in 1.0.7:
- -) New Config Class. This class allows to programmatically to retrieve the
libmygpo-qt version and retrieve and set the gpodder.net API endpoint
(e.g. if you test your
software against a private instance of gpodder.net)
- -) Config Class also allows to set a prefix to the user-agent. Please
never completely overwrite the user-agent set in libmygpo-qt (instead
pre/append your own, e.g. via mygpo::Config::setUserAgentPrefix( ... ) )
- -) fixed a bug that created incomplete Episode Actions if an Episode
Action couldn't be parsed completely by libmygpo-qt
- -) fixed a small bug with the pkgconfig file (thx to davidsansome)
- -) added support for uploading & retrieving flattr Episode Actions to
gpodder.net (this allows you to automatically flattr Podcast Episodes
from any podcatcher that uses libmygpo-qt)

Where to get libmygpo-qt?

Tarball:
http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.7.tar.gz
sha256sum:
faade78e1baeeab7f858dec80530ad63c50f683fe511948ab1a45e685828cc74
md5sum:
447e60c8c695b4280a0e20c71abacf49

Some more important Links for libmygpo-qt:

Project Website: http://wiki.gpodder.org/wiki/Libmygpo-qt
Git Repository: https://github.com/gpodder/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
gpodder.net API: http://wiki.gpodder.org/wiki/Web_Services/API_2
Bug reports: http://bugs.gpodder.org
Contact: gpod...@freelists.org

Want to support libmygpo-qt?

You can support the development of libmygpo-qt you can flattr [0] me or
donate via paypal to ste...@derkits.at
You can also send me a book via my Amazon Wishlist [1]

- - --- Infos about libmygpo-qt ---

What is libmygpo-qt?

libmygpo-qt is a Qt/C++ library wrapping the gpodder.net Webservice.
It is currently used in Amarok & Clementine to retrieve a directory of
podcasts & to synchronize podcast subscriptions with gpodder.net

Greetings,
Stefan

[0] https://flattr.com/thing/1250603/Horrendus-on-GitHub
[1] http://www.amazon.de/registry/wishlist/2C1RXFXGF5RMS
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlFpUcsACgkQlZvAMV/NgGLtkACfaz16lfzsXfFP3UhymdnAWIad
Tt4AoIVylJ0tp71fFn16I5VObEi2kO32
=pD6S
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel