Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
This bug may also be related:
https://bugs.freedesktop.org/show_bug.cgi?id=109206
Alex
From: Koenig, Christian
Sent: Thursday, January 3, 2019 10:57:50 AM
To: Yu, Xiangliang; Xu, Feifei; amd-gfx@lists.freedesktop.org; Deucher,
Alexander
Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command
failed
> For Vega10, could you explain why it block older version fw?
I'm not very familiar with the PSP, so I don't know what exactly is
going wrong here.
Symptoms are that we get the following in dmesg:
> Jan 03 15:55:17 abel kernel: [drm] PSP loading VCE firmware
> Jan 03 15:55:17 abel kernel: [drm] reserve 0x40 from 0xf400c0
> for PSP TMR SIZE
> Jan 03 15:55:17 abel kernel: [drm:psp_cmd_submit_buf [amdgpu]] *ERROR*
> psp command failed and response status is (1)
> Jan 03 15:55:17 abel kernel: [drm:psp_hw_init [amdgpu]] *ERROR* PSP
> firmware loading failed
> Jan 03 15:55:17 abel kernel: [drm:amdgpu_device_fw_loading [amdgpu]]
> *ERROR* hw_init of IP block failed -22
> Jan 03 15:55:17 abel kernel: amdgpu :43:00.0:
> amdgpu_device_ip_init failed
> Jan 03 15:55:17 abel kernel: amdgpu :43:00.0: Fatal error during
> GPU init
I think the code was purposely ignoring some return status because the
command wasn't available on older fw generations.
Now that we bail out on every non zero return code that fails when you
try to use the older PSP firmware on Vega10.
Anyway breaking older fw versions is not something we can do, so we need
to either fix or revert that ASAP or end users will start to complain.
Any idea how to investigate further?
Christian.
Am 03.01.19 um 16:21 schrieb Yu, Xiangliang:
> XGMI command will not load ucode, so it can't find the command failed if
> check ucode at first.
> For code logic, should check response status to see if command complete
> successfully at first.
> For Vega10, could you explain why it block older version fw?
>
>
> -Original Message-
> From: Christian König
> Sent: Thursday, January 03, 2019 11:00 PM
> To: Xu, Feifei ; Yu, Xiangliang ;
> amd-gfx@lists.freedesktop.org; Deucher, Alexander
> Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command
> failed
>
> Hi guys,
>
> this patch broke loading older versions of PSP firmware on Vega10.
>
> What exactly is the background here? E.g. why do we need it? And can we
> revert it ASAP?
>
> Thanks,
> Christian.
>
> Am 18.12.18 um 03:45 schrieb Xu, Feifei:
>> Reviewed-by: Feifei Xu
>>
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Xiangliang Yu
>> Sent: Thursday, December 13, 2018 3:42 PM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Yu, Xiangliang
>> Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE
>> command failed
>>
>> There isn't ucode when executing INVOKE command, so current code can't check
>> the failure of INVOKE command.
>>
>> Remove the ucode check.
>>
>> Signed-off-by: Xiangliang Yu
>> ---
>>drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 +++
>>1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> index 2f126ea7..7f5ce37 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> @@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
>> while (*((unsigned int *)psp->fence_buf) != index)
>> msleep(1);
>>
>> -/* the status field must be 0 after FW is loaded */
>> -if (ucode && psp->cmd_buf_mem->resp.status) {
>> -DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n",
>> - psp->cmd_buf_mem->resp.status, ucode->ucode_id);
>> +/* the status field must be 0 after psp command completion */
>> +if (psp->cmd_buf_mem->resp.status) {
>> +if (ucode)
>> +DRM_ERROR("failed to load ucode id (%d) ",
>> + ucode->ucode_id);
>> +DRM_ERROR("psp command failed and response status is (%d)\n",
>> + psp->cmd_buf_mem->resp.status);
>> return -EINVAL;
>> }
>>
>> --
>> 2.7.4
>>
>> ___
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>> ___
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
> For Vega10, could you explain why it block older version fw?
I'm not very familiar with the PSP, so I don't know what exactly is
going wrong here.
Symptoms are that we get the following in dmesg:
> Jan 03 15:55:17 abel kernel: [drm] PSP loading VCE firmware
> Jan 03 15:55:17 abel kernel: [drm] reserve 0x40 from 0xf400c0
> for PSP TMR SIZE
> Jan 03 15:55:17 abel kernel: [drm:psp_cmd_submit_buf [amdgpu]] *ERROR*
> psp command failed and response status is (1)
> Jan 03 15:55:17 abel kernel: [drm:psp_hw_init [amdgpu]] *ERROR* PSP
> firmware loading failed
> Jan 03 15:55:17 abel kernel: [drm:amdgpu_device_fw_loading [amdgpu]]
> *ERROR* hw_init of IP block failed -22
> Jan 03 15:55:17 abel kernel: amdgpu :43:00.0:
> amdgpu_device_ip_init failed
> Jan 03 15:55:17 abel kernel: amdgpu :43:00.0: Fatal error during
> GPU init
I think the code was purposely ignoring some return status because the
command wasn't available on older fw generations.
Now that we bail out on every non zero return code that fails when you
try to use the older PSP firmware on Vega10.
Anyway breaking older fw versions is not something we can do, so we need
to either fix or revert that ASAP or end users will start to complain.
Any idea how to investigate further?
Christian.
Am 03.01.19 um 16:21 schrieb Yu, Xiangliang:
> XGMI command will not load ucode, so it can't find the command failed if
> check ucode at first.
> For code logic, should check response status to see if command complete
> successfully at first.
> For Vega10, could you explain why it block older version fw?
>
>
> -Original Message-
> From: Christian König
> Sent: Thursday, January 03, 2019 11:00 PM
> To: Xu, Feifei ; Yu, Xiangliang ;
> amd-gfx@lists.freedesktop.org; Deucher, Alexander
> Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command
> failed
>
> Hi guys,
>
> this patch broke loading older versions of PSP firmware on Vega10.
>
> What exactly is the background here? E.g. why do we need it? And can we
> revert it ASAP?
>
> Thanks,
> Christian.
>
> Am 18.12.18 um 03:45 schrieb Xu, Feifei:
>> Reviewed-by: Feifei Xu
>>
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Xiangliang Yu
>> Sent: Thursday, December 13, 2018 3:42 PM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Yu, Xiangliang
>> Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE
>> command failed
>>
>> There isn't ucode when executing INVOKE command, so current code can't check
>> the failure of INVOKE command.
>>
>> Remove the ucode check.
>>
>> Signed-off-by: Xiangliang Yu
>> ---
>>drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 +++
>>1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> index 2f126ea7..7f5ce37 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> @@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
>> while (*((unsigned int *)psp->fence_buf) != index)
>> msleep(1);
>>
>> -/* the status field must be 0 after FW is loaded */
>> -if (ucode && psp->cmd_buf_mem->resp.status) {
>> -DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n",
>> - psp->cmd_buf_mem->resp.status, ucode->ucode_id);
>> +/* the status field must be 0 after psp command completion */
>> +if (psp->cmd_buf_mem->resp.status) {
>> +if (ucode)
>> +DRM_ERROR("failed to load ucode id (%d) ",
>> + ucode->ucode_id);
>> +DRM_ERROR("psp command failed and response status is (%d)\n",
>> + psp->cmd_buf_mem->resp.status);
>> return -EINVAL;
>> }
>>
>> --
>> 2.7.4
>>
>> ___
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>> ___
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
XGMI command will not load ucode, so it can't find the command failed if check
ucode at first.
For code logic, should check response status to see if command complete
successfully at first.
For Vega10, could you explain why it block older version fw?
-Original Message-
From: Christian König
Sent: Thursday, January 03, 2019 11:00 PM
To: Xu, Feifei ; Yu, Xiangliang ;
amd-gfx@lists.freedesktop.org; Deucher, Alexander
Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command
failed
Hi guys,
this patch broke loading older versions of PSP firmware on Vega10.
What exactly is the background here? E.g. why do we need it? And can we revert
it ASAP?
Thanks,
Christian.
Am 18.12.18 um 03:45 schrieb Xu, Feifei:
> Reviewed-by: Feifei Xu
>
> -Original Message-
> From: amd-gfx On Behalf Of
> Xiangliang Yu
> Sent: Thursday, December 13, 2018 3:42 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Yu, Xiangliang
> Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE
> command failed
>
> There isn't ucode when executing INVOKE command, so current code can't check
> the failure of INVOKE command.
>
> Remove the ucode check.
>
> Signed-off-by: Xiangliang Yu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 2f126ea7..7f5ce37 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
> while (*((unsigned int *)psp->fence_buf) != index)
> msleep(1);
>
> - /* the status field must be 0 after FW is loaded */
> - if (ucode && psp->cmd_buf_mem->resp.status) {
> - DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n",
> - psp->cmd_buf_mem->resp.status, ucode->ucode_id);
> + /* the status field must be 0 after psp command completion */
> + if (psp->cmd_buf_mem->resp.status) {
> + if (ucode)
> + DRM_ERROR("failed to load ucode id (%d) ",
> + ucode->ucode_id);
> + DRM_ERROR("psp command failed and response status is (%d)\n",
> + psp->cmd_buf_mem->resp.status);
> return -EINVAL;
> }
>
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
Hi guys,
this patch broke loading older versions of PSP firmware on Vega10.
What exactly is the background here? E.g. why do we need it? And can we
revert it ASAP?
Thanks,
Christian.
Am 18.12.18 um 03:45 schrieb Xu, Feifei:
Reviewed-by: Feifei Xu
-Original Message-
From: amd-gfx On Behalf Of Xiangliang Yu
Sent: Thursday, December 13, 2018 3:42 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yu, Xiangliang
Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
There isn't ucode when executing INVOKE command, so current code can't check
the failure of INVOKE command.
Remove the ucode check.
Signed-off-by: Xiangliang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 2f126ea7..7f5ce37 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
while (*((unsigned int *)psp->fence_buf) != index)
msleep(1);
- /* the status field must be 0 after FW is loaded */
- if (ucode && psp->cmd_buf_mem->resp.status) {
- DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n",
- psp->cmd_buf_mem->resp.status, ucode->ucode_id);
+ /* the status field must be 0 after psp command completion */
+ if (psp->cmd_buf_mem->resp.status) {
+ if (ucode)
+ DRM_ERROR("failed to load ucode id (%d) ",
+ ucode->ucode_id);
+ DRM_ERROR("psp command failed and response status is (%d)\n",
+ psp->cmd_buf_mem->resp.status);
return -EINVAL;
}
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
Reviewed-by: Feifei Xu
-Original Message-
From: amd-gfx On Behalf Of Xiangliang Yu
Sent: Thursday, December 13, 2018 3:42 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yu, Xiangliang
Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
There isn't ucode when executing INVOKE command, so current code can't check
the failure of INVOKE command.
Remove the ucode check.
Signed-off-by: Xiangliang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 2f126ea7..7f5ce37 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
while (*((unsigned int *)psp->fence_buf) != index)
msleep(1);
- /* the status field must be 0 after FW is loaded */
- if (ucode && psp->cmd_buf_mem->resp.status) {
- DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n",
- psp->cmd_buf_mem->resp.status, ucode->ucode_id);
+ /* the status field must be 0 after psp command completion */
+ if (psp->cmd_buf_mem->resp.status) {
+ if (ucode)
+ DRM_ERROR("failed to load ucode id (%d) ",
+ ucode->ucode_id);
+ DRM_ERROR("psp command failed and response status is (%d)\n",
+ psp->cmd_buf_mem->resp.status);
return -EINVAL;
}
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
Anyone to help reviewing?
Thanks!
-Original Message-
From: amd-gfx On Behalf Of Xiangliang Yu
Sent: Thursday, December 13, 2018 3:42 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yu, Xiangliang
Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
There isn't ucode when executing INVOKE command, so current code can't check
the failure of INVOKE command.
Remove the ucode check.
Signed-off-by: Xiangliang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 2f126ea7..7f5ce37 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
while (*((unsigned int *)psp->fence_buf) != index)
msleep(1);
- /* the status field must be 0 after FW is loaded */
- if (ucode && psp->cmd_buf_mem->resp.status) {
- DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n",
- psp->cmd_buf_mem->resp.status, ucode->ucode_id);
+ /* the status field must be 0 after psp command completion */
+ if (psp->cmd_buf_mem->resp.status) {
+ if (ucode)
+ DRM_ERROR("failed to load ucode id (%d) ",
+ ucode->ucode_id);
+ DRM_ERROR("psp command failed and response status is (%d)\n",
+ psp->cmd_buf_mem->resp.status);
return -EINVAL;
}
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed
There isn't ucode when executing INVOKE command, so current code can't
check the failure of INVOKE command.
Remove the ucode check.
Signed-off-by: Xiangliang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 2f126ea7..7f5ce37 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
while (*((unsigned int *)psp->fence_buf) != index)
msleep(1);
- /* the status field must be 0 after FW is loaded */
- if (ucode && psp->cmd_buf_mem->resp.status) {
- DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n",
- psp->cmd_buf_mem->resp.status, ucode->ucode_id);
+ /* the status field must be 0 after psp command completion */
+ if (psp->cmd_buf_mem->resp.status) {
+ if (ucode)
+ DRM_ERROR("failed to load ucode id (%d) ",
+ ucode->ucode_id);
+ DRM_ERROR("psp command failed and response status is (%d)\n",
+ psp->cmd_buf_mem->resp.status);
return -EINVAL;
}
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
