Re: install-strip rule doesn't work

[Tom Tromey]

> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes:

Akim> Nonetheless, I keep on thinking this is overkill, and would like to
Akim> resubmit my proposal, part of the aforementioned thread:

Akim> http://sources.redhat.com/ml/automake/2001-03/msg00151.html

I'd still prefer not to do this.  I think this would be a regression
from 1.4.  In 1.6 (or whatever we call the next major release) we can
ditch autoconf 2.13 support entirely.  Then we can revisit this.

Tom

Re: install-strip rule doesn't work

[Akim Demaille]

Jim> * m4/strip.m4: Fix a typo: s/\$\$/$/.

Pollux> This issue should disappear with the following pending patch.
Pollux> http://sources.redhat.com/ml/automake/2001-03/msg00129.html

I agree with this patch.  I also agree with the one documentation one,

http://sources.redhat.com/ml/automake/2001-03/msg00130.html

Nonetheless, I keep on thinking this is overkill, and would like to
resubmit my proposal, part of the aforementioned thread:

http://sources.redhat.com/ml/automake/2001-03/msg00151.html

Re: install-strip rule doesn't work

[Alexandre Duret-Lutz]

>>> "Jim" == Jim Meyering <[EMAIL PROTECTED]> writes:

[...]

 Jim> The problem comes from automake's m4/strip.m4.
 Jim> We want the make variable, $(INSTALL) not the shell variable.
 Jim> [I prefer parens to curly braces, but have left the braces,
 Jim> in case they're there for a good reason]

 Jim> Here's a patch that should work:

 Jim> 2001-04-30  Jim Meyering  <[EMAIL PROTECTED]>

 Jim> * m4/strip.m4: Fix a typo: s/\$\$/$/.

This issue should disappear with the following pending patch.
http://sources.redhat.com/ml/automake/2001-03/msg00129.html

[...]

-- 
Alexandre Duret-Lutz

install-strip rule doesn't work

[Jim Meyering]

Hi Bob,

Thanks for reporting that.
It seems to be a bug that's still in the current sources.

In fileutils-4.1/src/Makefile, I see this:

  INSTALL_STRIP_PROGRAM = $${INSTALL} -s

which eventually expands to just ` -s' and produces the
symptom Bob noted below.

The problem comes from automake's m4/strip.m4.
We want the make variable, $(INSTALL) not the shell variable.
[I prefer parens to curly braces, but have left the braces,
 in case they're there for a good reason]

Here's a patch that should work:

2001-04-30  Jim Meyering  <[EMAIL PROTECTED]>

* m4/strip.m4: Fix a typo: s/\$\$/$/.



--- m4/strip.m4.~1~ Mon Feb 19 05:11:57 2001
+++ m4/strip.m4 Mon Apr 30 11:13:36 2001
@@ -30,7 +30,7 @@ if test -z "$STRIP"; then
   # is substitued in the sub-makes, not at the top-level; this is
   # needed if ${INSTALL} is a relative path (ajusted in each subdirectory
   # by config.status).
-  INSTALL_STRIP_PROGRAM='$${INSTALL} -s'
+  INSTALL_STRIP_PROGRAM='${INSTALL} -s'
   INSTALL_STRIP_PROGRAM_ENV=''
 else
   _am_dirpart="`echo $install_sh | sed -e 's,//*[[^/]]*$,,'`"

Bob Proulx <[EMAIL PROTECTED]> wrote:
| Jim
...
| I just happened to try something new today.  I tried to use the newer
| make target install-strip that the later automake provides.  It seems
| broken.
|
|   make install-strip
|   /bin/sh ../mkinstalldirs /usr/local/bin
| -s chgrp /usr/local/bin/chgrp
|   /bin/sh: -s:  not found.
|
| BTW, here is the previous method that I am continuing to use for
| production installations.
|
|   make INSTALL_PROGRAM='install -s' install
|
| This had not previously existed and so should not be a concern for
| the, well deserved, release.  But I did want to note it anyway.
|
| Bob