Re: [PATCH] Honour CPNIO_DSYNC flag if set.
Still very busy? 2016-09-30 18:53 GMT+02:00 Andrew Hughes : > - Original Message - >> Hello. >> >> Any plans to process these bug reports? Some of these were first >> reported in Jan 2015 (and a solution was already proposed) >> > > Yes, I haven't forgotten, but as I say, I'm very busy with OpenJDK > and IcedTea as well. > >> Guillermo >> >> 2016-04-14 21:33 GMT+02:00 Andrew Hughes : >> > >> > >> > - Original Message - >> >> 2016-04-14 12:45 GMT+02:00 Andrew Hughes : >> >> >> >> > >> >> > - Original Message - >> >> > > Hello ? Anybody here ? >> >> > > >> >> > >> >> > Yes, but very busy right now. >> >> > >> >> >> >> I have created entries in the bug tracker for this bug and also for the >> >> CPNIO_DSYNC problem and autoconf macros issue in 0.99, as all of them are >> >> still outstanding. At least this way, the next time I need to ask about >> >> the >> >> status of these I will not need to search emails that are months or years >> >> old. >> >> >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70658 >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70659 >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660 >> >> >> >> Guillermo >> >> >> > >> > Yeah, I saw them. I'll try and take a look when things are quieter. >> > >> > Thanks for the work, >> > -- >> > Andrew :) >> > >> > Senior Free Java Software Engineer >> > Red Hat, Inc. (http://www.redhat.com) >> > >> > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) >> > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 >> > >> > >> >> >> >> -- >> Guillermo Rodriguez Garcia >> guille.rodrig...@gmail.com >> > > -- > Andrew :) > > Senior Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > -- Guillermo Rodriguez Garcia guille.rodrig...@gmail.com
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
- Original Message - > Hello. > > Any plans to process these bug reports? Some of these were first > reported in Jan 2015 (and a solution was already proposed) > Yes, I haven't forgotten, but as I say, I'm very busy with OpenJDK and IcedTea as well. > Guillermo > > 2016-04-14 21:33 GMT+02:00 Andrew Hughes : > > > > > > - Original Message - > >> 2016-04-14 12:45 GMT+02:00 Andrew Hughes : > >> > >> > > >> > - Original Message - > >> > > Hello ? Anybody here ? > >> > > > >> > > >> > Yes, but very busy right now. > >> > > >> > >> I have created entries in the bug tracker for this bug and also for the > >> CPNIO_DSYNC problem and autoconf macros issue in 0.99, as all of them are > >> still outstanding. At least this way, the next time I need to ask about > >> the > >> status of these I will not need to search emails that are months or years > >> old. > >> > >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70658 > >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70659 > >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660 > >> > >> Guillermo > >> > > > > Yeah, I saw them. I'll try and take a look when things are quieter. > > > > Thanks for the work, > > -- > > Andrew :) > > > > Senior Free Java Software Engineer > > Red Hat, Inc. (http://www.redhat.com) > > > > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) > > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > > > > > > > -- > Guillermo Rodriguez Garcia > guille.rodrig...@gmail.com > -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
Hello. Any plans to process these bug reports? Some of these were first reported in Jan 2015 (and a solution was already proposed) Guillermo 2016-04-14 21:33 GMT+02:00 Andrew Hughes : > > > - Original Message - >> 2016-04-14 12:45 GMT+02:00 Andrew Hughes : >> >> > >> > - Original Message - >> > > Hello ? Anybody here ? >> > > >> > >> > Yes, but very busy right now. >> > >> >> I have created entries in the bug tracker for this bug and also for the >> CPNIO_DSYNC problem and autoconf macros issue in 0.99, as all of them are >> still outstanding. At least this way, the next time I need to ask about the >> status of these I will not need to search emails that are months or years >> old. >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70658 >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70659 >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660 >> >> Guillermo >> > > Yeah, I saw them. I'll try and take a look when things are quieter. > > Thanks for the work, > -- > Andrew :) > > Senior Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > -- Guillermo Rodriguez Garcia guille.rodrig...@gmail.com
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
- Original Message - > 2016-04-14 12:45 GMT+02:00 Andrew Hughes : > > > > > - Original Message - > > > Hello ? Anybody here ? > > > > > > > Yes, but very busy right now. > > > > I have created entries in the bug tracker for this bug and also for the > CPNIO_DSYNC problem and autoconf macros issue in 0.99, as all of them are > still outstanding. At least this way, the next time I need to ask about the > status of these I will not need to search emails that are months or years > old. > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70658 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70659 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660 > > Guillermo > Yeah, I saw them. I'll try and take a look when things are quieter. Thanks for the work, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
2016-04-14 12:45 GMT+02:00 Andrew Hughes : > > - Original Message - > > Hello ? Anybody here ? > > > > Yes, but very busy right now. > I have created entries in the bug tracker for this bug and also for the CPNIO_DSYNC problem and autoconf macros issue in 0.99, as all of them are still outstanding. At least this way, the next time I need to ask about the status of these I will not need to search emails that are months or years old. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70658 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70659 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70660 Guillermo
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
- Original Message - > Hello ? Anybody here ? > Yes, but very busy right now. -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
Hello ? Anybody here ?
2016-02-02 16:52 GMT+01:00 Guillermo Rodriguez Garcia <
guille.rodrig...@gmail.com>:
> Hello Andrew,
>
> Any chances this patch and the DecimalFormat one will be applied? It is
> been
> roughly one year since I first submitted the patches.
>
> Guillermo
>
> 2015-07-28 16:46 GMT+02:00 Andrew Hughes :
>
>> - Original Message -
>> > Hello,
>> >
>> > Don't want to bug you, but have you had the chance to look into this?
>> >
>>
>> Hi Guillermo,
>>
>> Sorry, I've been busy with the OpenJDK security updates.
>> I'll try and look into both this week.
>>
>> Thanks for your patience.
>>
>> > Guillermo
>> >
>> > 2015-01-29 18:16 GMT+01:00 Andrew Hughes :
>> > >
>> > >
>> > > - Original Message -
>> > >> Hello. Any feedback?
>> > >>
>> > >>
>> > >> 2015-01-20 14:10 GMT+01:00 grodriguez :
>> > >>
>> > >> > The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC was
>> honoured).
>> > >> > This was breaking at least RandomFileAccess when open in "rwd" mode
>> > >> > ("rws" would work as expected).
>> > >> >
>> > >> > ---
>> > >> > native/jni/java-nio/gnu_java_nio_VMChannel.c |3 ++-
>> > >> > 1 files changed, 2 insertions(+), 1 deletions(-)
>> > >> >
>> > >> > diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.c
>> > >> > b/native/jni/java-nio/gnu_java_nio_VMChannel.c
>> > >> > index 7899f0b..6a1cf48 100644
>> > >> > --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c
>> > >> > +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c
>> > >> > @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (JNIEnv
>> *env,
>> > >> > | ((mode & CPNIO_APPEND) ? O_APPEND :
>> > >> >((nmode == O_WRONLY) ? O_TRUNC : 0))
>> > >> > | ((mode & CPNIO_EXCL) ? O_EXCL : 0)
>> > >> > - | ((mode & CPNIO_SYNC) ? O_SYNC : 0));
>> > >> > + | ((mode & CPNIO_SYNC) ? O_SYNC : 0)
>> > >> > + | ((mode & CPNIO_DSYNC) ? O_DSYNC : 0));
>> > >> >
>> > >> >npath = JCL_jstring_to_cstring (env, path);
>> > >> >
>> > >> > --
>> > >> > 1.7.0.4
>> > >> >
>> > >> >
>> > >>
>> > >>
>> > >> --
>> > >> Guillermo Rodriguez Garcia
>> > >> guille.rodrig...@gmail.com
>> > >>
>> > >
>> > > Thanks. I'll apply the patch as soon as I can.
>> > > --
>> > > Andrew :)
>> > >
>> > > Free Java Software Engineer
>> > > Red Hat, Inc. (http://www.redhat.com)
>> > >
>> > > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
>> > > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
>> > >
>> > > PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
>> > > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
>> > >
>> >
>> >
>> >
>> > --
>> > Guillermo Rodriguez Garcia
>> > guille.rodrig...@gmail.com
>> >
>> >
>>
>> --
>> Andrew :)
>>
>> Senior Free Java Software Engineer
>> Red Hat, Inc. (http://www.redhat.com)
>>
>> PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
>> Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
>>
>> PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
>> Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
>>
>>
>
>
> --
> Guillermo Rodriguez Garcia
> guille.rodrig...@gmail.com
>
--
Guillermo Rodriguez Garcia
guille.rodrig...@gmail.com
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
Hello Andrew,
Any chances this patch and the DecimalFormat one will be applied? It is been
roughly one year since I first submitted the patches.
Guillermo
2015-07-28 16:46 GMT+02:00 Andrew Hughes :
> - Original Message -
> > Hello,
> >
> > Don't want to bug you, but have you had the chance to look into this?
> >
>
> Hi Guillermo,
>
> Sorry, I've been busy with the OpenJDK security updates.
> I'll try and look into both this week.
>
> Thanks for your patience.
>
> > Guillermo
> >
> > 2015-01-29 18:16 GMT+01:00 Andrew Hughes :
> > >
> > >
> > > - Original Message -
> > >> Hello. Any feedback?
> > >>
> > >>
> > >> 2015-01-20 14:10 GMT+01:00 grodriguez :
> > >>
> > >> > The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC was
> honoured).
> > >> > This was breaking at least RandomFileAccess when open in "rwd" mode
> > >> > ("rws" would work as expected).
> > >> >
> > >> > ---
> > >> > native/jni/java-nio/gnu_java_nio_VMChannel.c |3 ++-
> > >> > 1 files changed, 2 insertions(+), 1 deletions(-)
> > >> >
> > >> > diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> > >> > b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> > >> > index 7899f0b..6a1cf48 100644
> > >> > --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> > >> > +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> > >> > @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (JNIEnv *env,
> > >> > | ((mode & CPNIO_APPEND) ? O_APPEND :
> > >> >((nmode == O_WRONLY) ? O_TRUNC : 0))
> > >> > | ((mode & CPNIO_EXCL) ? O_EXCL : 0)
> > >> > - | ((mode & CPNIO_SYNC) ? O_SYNC : 0));
> > >> > + | ((mode & CPNIO_SYNC) ? O_SYNC : 0)
> > >> > + | ((mode & CPNIO_DSYNC) ? O_DSYNC : 0));
> > >> >
> > >> >npath = JCL_jstring_to_cstring (env, path);
> > >> >
> > >> > --
> > >> > 1.7.0.4
> > >> >
> > >> >
> > >>
> > >>
> > >> --
> > >> Guillermo Rodriguez Garcia
> > >> guille.rodrig...@gmail.com
> > >>
> > >
> > > Thanks. I'll apply the patch as soon as I can.
> > > --
> > > Andrew :)
> > >
> > > Free Java Software Engineer
> > > Red Hat, Inc. (http://www.redhat.com)
> > >
> > > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
> > > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
> > >
> > > PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
> > > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
> > >
> >
> >
> >
> > --
> > Guillermo Rodriguez Garcia
> > guille.rodrig...@gmail.com
> >
> >
>
> --
> Andrew :)
>
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
>
> PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
> Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
>
>
--
Guillermo Rodriguez Garcia
guille.rodrig...@gmail.com
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
- Original Message -
> Hello,
>
> Don't want to bug you, but have you had the chance to look into this?
>
Hi Guillermo,
Sorry, I've been busy with the OpenJDK security updates.
I'll try and look into both this week.
Thanks for your patience.
> Guillermo
>
> 2015-01-29 18:16 GMT+01:00 Andrew Hughes :
> >
> >
> > - Original Message -
> >> Hello. Any feedback?
> >>
> >>
> >> 2015-01-20 14:10 GMT+01:00 grodriguez :
> >>
> >> > The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC was honoured).
> >> > This was breaking at least RandomFileAccess when open in "rwd" mode
> >> > ("rws" would work as expected).
> >> >
> >> > ---
> >> > native/jni/java-nio/gnu_java_nio_VMChannel.c |3 ++-
> >> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >> >
> >> > diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> >> > b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> >> > index 7899f0b..6a1cf48 100644
> >> > --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> >> > +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> >> > @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (JNIEnv *env,
> >> > | ((mode & CPNIO_APPEND) ? O_APPEND :
> >> >((nmode == O_WRONLY) ? O_TRUNC : 0))
> >> > | ((mode & CPNIO_EXCL) ? O_EXCL : 0)
> >> > - | ((mode & CPNIO_SYNC) ? O_SYNC : 0));
> >> > + | ((mode & CPNIO_SYNC) ? O_SYNC : 0)
> >> > + | ((mode & CPNIO_DSYNC) ? O_DSYNC : 0));
> >> >
> >> >npath = JCL_jstring_to_cstring (env, path);
> >> >
> >> > --
> >> > 1.7.0.4
> >> >
> >> >
> >>
> >>
> >> --
> >> Guillermo Rodriguez Garcia
> >> guille.rodrig...@gmail.com
> >>
> >
> > Thanks. I'll apply the patch as soon as I can.
> > --
> > Andrew :)
> >
> > Free Java Software Engineer
> > Red Hat, Inc. (http://www.redhat.com)
> >
> > PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
> > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
> >
> > PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
> > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
> >
>
>
>
> --
> Guillermo Rodriguez Garcia
> guille.rodrig...@gmail.com
>
>
--
Andrew :)
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
Hello,
Don't want to bug you, but have you had the chance to look into this?
Guillermo
2015-01-29 18:16 GMT+01:00 Andrew Hughes :
>
>
> - Original Message -
>> Hello. Any feedback?
>>
>>
>> 2015-01-20 14:10 GMT+01:00 grodriguez :
>>
>> > The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC was honoured).
>> > This was breaking at least RandomFileAccess when open in "rwd" mode
>> > ("rws" would work as expected).
>> >
>> > ---
>> > native/jni/java-nio/gnu_java_nio_VMChannel.c |3 ++-
>> > 1 files changed, 2 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.c
>> > b/native/jni/java-nio/gnu_java_nio_VMChannel.c
>> > index 7899f0b..6a1cf48 100644
>> > --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c
>> > +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c
>> > @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (JNIEnv *env,
>> > | ((mode & CPNIO_APPEND) ? O_APPEND :
>> >((nmode == O_WRONLY) ? O_TRUNC : 0))
>> > | ((mode & CPNIO_EXCL) ? O_EXCL : 0)
>> > - | ((mode & CPNIO_SYNC) ? O_SYNC : 0));
>> > + | ((mode & CPNIO_SYNC) ? O_SYNC : 0)
>> > + | ((mode & CPNIO_DSYNC) ? O_DSYNC : 0));
>> >
>> >npath = JCL_jstring_to_cstring (env, path);
>> >
>> > --
>> > 1.7.0.4
>> >
>> >
>>
>>
>> --
>> Guillermo Rodriguez Garcia
>> guille.rodrig...@gmail.com
>>
>
> Thanks. I'll apply the patch as soon as I can.
> --
> Andrew :)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
>
> PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
> Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
>
--
Guillermo Rodriguez Garcia
guille.rodrig...@gmail.com
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
- Original Message -
> Hello. Any feedback?
>
>
> 2015-01-20 14:10 GMT+01:00 grodriguez :
>
> > The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC was honoured).
> > This was breaking at least RandomFileAccess when open in "rwd" mode
> > ("rws" would work as expected).
> >
> > ---
> > native/jni/java-nio/gnu_java_nio_VMChannel.c |3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> > b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> > index 7899f0b..6a1cf48 100644
> > --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> > +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> > @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (JNIEnv *env,
> > | ((mode & CPNIO_APPEND) ? O_APPEND :
> >((nmode == O_WRONLY) ? O_TRUNC : 0))
> > | ((mode & CPNIO_EXCL) ? O_EXCL : 0)
> > - | ((mode & CPNIO_SYNC) ? O_SYNC : 0));
> > + | ((mode & CPNIO_SYNC) ? O_SYNC : 0)
> > + | ((mode & CPNIO_DSYNC) ? O_DSYNC : 0));
> >
> >npath = JCL_jstring_to_cstring (env, path);
> >
> > --
> > 1.7.0.4
> >
> >
>
>
> --
> Guillermo Rodriguez Garcia
> guille.rodrig...@gmail.com
>
Thanks. I'll apply the patch as soon as I can.
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: [PATCH] Honour CPNIO_DSYNC flag if set.
Hello. Any feedback?
2015-01-20 14:10 GMT+01:00 grodriguez :
> The CPNIO_DSYNC flag was being ignored (only CPNIO_SYNC was honoured).
> This was breaking at least RandomFileAccess when open in "rwd" mode
> ("rws" would work as expected).
>
> ---
> native/jni/java-nio/gnu_java_nio_VMChannel.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> index 7899f0b..6a1cf48 100644
> --- a/native/jni/java-nio/gnu_java_nio_VMChannel.c
> +++ b/native/jni/java-nio/gnu_java_nio_VMChannel.c
> @@ -1705,7 +1705,8 @@ Java_gnu_java_nio_VMChannel_open (JNIEnv *env,
> | ((mode & CPNIO_APPEND) ? O_APPEND :
>((nmode == O_WRONLY) ? O_TRUNC : 0))
> | ((mode & CPNIO_EXCL) ? O_EXCL : 0)
> - | ((mode & CPNIO_SYNC) ? O_SYNC : 0));
> + | ((mode & CPNIO_SYNC) ? O_SYNC : 0)
> + | ((mode & CPNIO_DSYNC) ? O_DSYNC : 0));
>
>npath = JCL_jstring_to_cstring (env, path);
>
> --
> 1.7.0.4
>
>
--
Guillermo Rodriguez Garcia
guille.rodrig...@gmail.com
