[jira] [Commented] (AIRFLOW-3913) Search Button overrides existing GET Parameter

2019-09-14 Thread Alejandro (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929736#comment-16929736
 ] 

Alejandro commented on AIRFLOW-3913:


This looks like it was fixed by: [https://github.com/apache/airflow/pull/5503]

> Search Button overrides existing GET Parameter
> --
>
> Key: AIRFLOW-3913
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3913
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.2
>Reporter: Felix Uellendall
>Priority: Minor
>  Labels: GoodForNewContributors, beginner, starter
>
> When you search for DAGs the url will be reset to the base_url + 
> "?search=".
> So if you have hided paused dags for example and then search for something 
> you also get paused dags.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (AIRFLOW-3912) Hide/Show Paused DAGs Button overrides existing GET Parameter

2019-09-14 Thread Alejandro (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-3912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929733#comment-16929733
 ] 

Alejandro commented on AIRFLOW-3912:


This looks like it was fixed by: [https://github.com/apache/airflow/pull/5503]

> Hide/Show Paused DAGs Button overrides existing GET Parameter
> -
>
> Key: AIRFLOW-3912
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3912
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.2
>Reporter: Felix Uellendall
>Assignee: Alejandro
>Priority: Minor
>  Labels: GoodForNewContributors, beginner, starter
>
> When you click on the "Hide Paused DAGs" / "Show Paused DAGs" Button the url 
> will be reset to the base_url + "?show_paused=True" / "?show_paused=False".
> This can be bad when you want to search for dags for example and then show 
> only the paused dags.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (AIRFLOW-3912) Hide/Show Paused DAGs Button overrides existing GET Parameter

2019-09-13 Thread Alejandro (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-3912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alejandro reassigned AIRFLOW-3912:
--

Assignee: Alejandro

> Hide/Show Paused DAGs Button overrides existing GET Parameter
> -
>
> Key: AIRFLOW-3912
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3912
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.2
>Reporter: Felix Uellendall
>Assignee: Alejandro
>Priority: Minor
>  Labels: GoodForNewContributors, beginner, starter
>
> When you click on the "Hide Paused DAGs" / "Show Paused DAGs" Button the url 
> will be reset to the base_url + "?show_paused=True" / "?show_paused=False".
> This can be bad when you want to search for dags for example and then show 
> only the paused dags.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (AIRFLOW-5387) Pagination is broken when the config variable hide_paused_dags_by_default is set to True because showPaused variable is removed

2019-09-13 Thread Alejandro (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alejandro reassigned AIRFLOW-5387:
--

Assignee: Alejandro

> Pagination is broken when the config variable hide_paused_dags_by_default is 
> set to True because showPaused variable is removed
> ---
>
> Key: AIRFLOW-5387
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.4
>Reporter: Guillem Lefait
>Assignee: Alejandro
>Priority: Minor
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
> if 'showPaused' in kwargs:
>   v = kwargs['showPaused']
>   if v or v is None:
>  kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True, 
> removing the parameter showPaused disable access to the correct paginated 
> pages when navigating to "Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only 
> "active" DAGs are presented.
> Fix: 
> - showPaused parameter should not be removed and therefore lines 68 to 71 
> (included) could be removed.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (AIRFLOW-4553) Scheduler only schedules one task at a time with CeleryExecutor

2019-05-31 Thread Alejandro (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853269#comment-16853269
 ] 

Alejandro commented on AIRFLOW-4553:


[~Fokko] Any ideas?

> Scheduler only schedules one task at a time with CeleryExecutor
> ---
>
> Key: AIRFLOW-4553
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4553
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: scheduler
>Affects Versions: 1.10.2, 1.10.3
>Reporter: Alejandro
>Assignee: Alejandro
>Priority: Major
>
> I've recently upgraded from Airflow 1.9.0 to Airflow 1.10.3. There has been a 
> change in how the scheduler put tasks up for execution that have affected 
> some of our DAGs. We use the CeleryExecutor.
> On Airflow 1.9.0 the scheduler would set as `scheduled` as many tasks as it 
> could, For example in a DAG with 5 independent tasks and enough concurrency 
> set, the scheduler would queue the 5 tasks for execution and all 5 tasks 
> could potentially start running.
> On Airflow 1.10.3 the scheduler would set as `scheduled` only one task at a 
> time, For example in a DAG with 5 independent tasks and enough concurrency 
> set, the scheduler would queue the 1 task for execution and the other 4 would 
> not stay with a None state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-4553) Scheduler only schedules one task at a time with CeleryExecutor

2019-05-24 Thread Alejandro (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847494#comment-16847494
 ] 

Alejandro commented on AIRFLOW-4553:


[~bolke] It looks like this behavior was introduced by 
[https://github.com/apache/airflow/pull/2888]

We are using MySQL and it looks like only the changes applied to the task 
instance within the last iteration of the for loop are really applied. That 
means that only the last task gets its state changed to SCHEDULED

Changing the commit back to be within the for loop fixes the issue. Any ideas 
why the state is not committed in bulk as expected?

> Scheduler only schedules one task at a time with CeleryExecutor
> ---
>
> Key: AIRFLOW-4553
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4553
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: scheduler
>Affects Versions: 1.10.2, 1.10.3
>Reporter: Alejandro
>Priority: Major
>
> I've recently upgraded from Airflow 1.9.0 to Airflow 1.10.3. There has been a 
> change in how the scheduler put tasks up for execution that have affected 
> some of our DAGs. We use the CeleryExecutor.
> On Airflow 1.9.0 the scheduler would set as `scheduled` as many tasks as it 
> could, For example in a DAG with 5 independent tasks and enough concurrency 
> set, the scheduler would queue the 5 tasks for execution and all 5 tasks 
> could potentially start running.
> On Airflow 1.10.3 the scheduler would set as `scheduled` only one task at a 
> time, For example in a DAG with 5 independent tasks and enough concurrency 
> set, the scheduler would queue the 1 task for execution and the other 4 would 
> not stay with a None state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (AIRFLOW-4553) Scheduler only schedules one task at a time with CeleryExecutor

2019-05-21 Thread Alejandro (JIRA)
Alejandro created AIRFLOW-4553:
--

 Summary: Scheduler only schedules one task at a time with 
CeleryExecutor
 Key: AIRFLOW-4553
 URL: https://issues.apache.org/jira/browse/AIRFLOW-4553
 Project: Apache Airflow
  Issue Type: Bug
  Components: scheduler
Affects Versions: 1.10.3, 1.10.2
Reporter: Alejandro


I've recently upgraded from Airflow 1.9.0 to Airflow 1.10.3. There has been a 
change in how the scheduler put tasks up for execution that have affected some 
of our DAGs. We use the CeleryExecutor.

On Airflow 1.9.0 the scheduler would set as `scheduled` as many tasks as it 
could, For example in a DAG with 5 independent tasks and enough concurrency 
set, the scheduler would queue the 5 tasks for execution and all 5 tasks could 
potentially start running.

On Airflow 1.10.3 the scheduler would set as `scheduled` only one task at a 
time, For example in a DAG with 5 independent tasks and enough concurrency set, 
the scheduler would queue the 1 task for execution and the other 4 would not 
stay with a None state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)