[jira] [Commented] (AIRFLOW-3813) create a cli to allow Admin to add / delete role
[ https://issues.apache.org/jira/browse/AIRFLOW-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762352#comment-16762352 ] ASF subversion and git services commented on AIRFLOW-3813: -- Commit 2dadee7a248442012e835eeaad3f21f698d0642b in airflow's branch refs/heads/master from Andrew Stahlman [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=2dadee7 ] [AIRFLOW-3813] Add CLI commands to manage roles (#4658) * [AIRFLOW-3813] Add CLI commands to manage roles Here is the help text of the new command `airflow roles`: usage: airflow roles [-h] [-c] [-l] [role [role ...]] positional arguments: role The name of a role optional arguments: -h, --helpshow this help message and exit -c, --create Create a new role -l, --listList roles Create is reentrant, i.e., it only adds a new role if it does not exist. * Update docs on role creation > create a cli to allow Admin to add / delete role > > > Key: AIRFLOW-3813 > URL: https://issues.apache.org/jira/browse/AIRFLOW-3813 > Project: Apache Airflow > Issue Type: Improvement >Reporter: Tao Feng >Assignee: Andrew Stahlman >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3813) create a cli to allow Admin to add / delete role
[ https://issues.apache.org/jira/browse/AIRFLOW-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762353#comment-16762353 ] ASF subversion and git services commented on AIRFLOW-3813: -- Commit 2dadee7a248442012e835eeaad3f21f698d0642b in airflow's branch refs/heads/master from Andrew Stahlman [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=2dadee7 ] [AIRFLOW-3813] Add CLI commands to manage roles (#4658) * [AIRFLOW-3813] Add CLI commands to manage roles Here is the help text of the new command `airflow roles`: usage: airflow roles [-h] [-c] [-l] [role [role ...]] positional arguments: role The name of a role optional arguments: -h, --helpshow this help message and exit -c, --create Create a new role -l, --listList roles Create is reentrant, i.e., it only adds a new role if it does not exist. * Update docs on role creation > create a cli to allow Admin to add / delete role > > > Key: AIRFLOW-3813 > URL: https://issues.apache.org/jira/browse/AIRFLOW-3813 > Project: Apache Airflow > Issue Type: Improvement >Reporter: Tao Feng >Assignee: Andrew Stahlman >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3813) create a cli to allow Admin to add / delete role
[ https://issues.apache.org/jira/browse/AIRFLOW-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762351#comment-16762351 ] ASF GitHub Bot commented on AIRFLOW-3813: - feng-tao commented on pull request #4658: [AIRFLOW-3813] Add CLI commands to manage roles URL: https://github.com/apache/airflow/pull/4658 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > create a cli to allow Admin to add / delete role > > > Key: AIRFLOW-3813 > URL: https://issues.apache.org/jira/browse/AIRFLOW-3813 > Project: Apache Airflow > Issue Type: Improvement >Reporter: Tao Feng >Assignee: Andrew Stahlman >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-3813) create a cli to allow Admin to add / delete role
[
https://issues.apache.org/jira/browse/AIRFLOW-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762072#comment-16762072
]
ASF GitHub Bot commented on AIRFLOW-3813:
-
astahlman commented on pull request #4658: [AIRFLOW-3813] Add CLI commands to
create, delete, and list roles
URL: https://github.com/apache/airflow/pull/4658
Make sure you have checked _all_ steps below.
### Jira
- [ X ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3813
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ X ] Here are some details about my PR, including screenshots of any UI
changes:
Here is the help text of the new command `airflow roles`:
usage: airflow roles [-h] [-c] [-d] [-l] [role [role ...]]
positional arguments:
role The name of a role
optional arguments:
-h, --helpshow this help message and exit
-c, --create Create a new role
-d, --delete Delete an existing role
-l, --listList roles
Create and delete are both reentrant, i.e., `create` only adds a new
role if it does not exist, and `delete` only removes roles that do
exist.
### Tests
- [ X ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added unit tests for creating, deleting, and listing roles in tests/core.py
### Commits
- [ X ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ X ] In case of new functionality, my PR adds documentation that
describes how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ X ] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> create a cli to allow Admin to add / delete role
>
>
> Key: AIRFLOW-3813
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3813
> Project: Apache Airflow
> Issue Type: Improvement
>Reporter: Tao Feng
>Assignee: Andrew Stahlman
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
