[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341595#comment-16341595 ] Jean-Baptiste Onofré commented on BEAM-2273: Yes, I confirm that the starter archetype doesn't generate or copy code (the example archetype uses a script to copy the code from examples). > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341585#comment-16341585 ] Jean-Baptiste Onofré commented on BEAM-2273: AFAIR, the starter archetype doesn't generate any code. I will double check anyway. > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jean-Baptiste Onofré >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341380#comment-16341380 ] Luke Cwik commented on BEAM-2273: - All that is left is to also make sure that `sdks/java/maven-archetypes/starter` also is cleaned up. > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jean-Baptiste Onofré >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339654#comment-16339654 ] Jean-Baptiste Onofré commented on BEAM-2273: Not a blocker for 2.3.0, but good to have anyway. Let me add you as reviewer on the PR. > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jean-Baptiste Onofré >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339647#comment-16339647 ] Kenneth Knowles commented on BEAM-2273: --- Looks like PR is open. It doesn't actually need to block anything so if it gets fixed by 2.3.0 that's great but no need to track & block. > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jean-Baptiste Onofré >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339516#comment-16339516 ] ASF GitHub Bot commented on BEAM-2273: -- jbonofre opened a new pull request #4487: [BEAM-2273] Cleanup examples Maven Archetype to copy in a clean state URL: https://github.com/apache/beam/pull/4487 Follow this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339400#comment-16339400 ] Jean-Baptiste Onofré commented on BEAM-2273: I'm resuming work on this one. I think it's just a question of {{maven-clean-plugin}} to configure. > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339401#comment-16339401 ] Jean-Baptiste Onofré commented on BEAM-2273: By the way, first, I'm checking if this Jira is still valid (testing). > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336762#comment-16336762 ] ASF GitHub Bot commented on BEAM-2273: -- aaltay closed pull request #3107: [BEAM-2273] Fully clean up archetypes when running mvn clean URL: https://github.com/apache/beam/pull/3107 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/sdks/java/maven-archetypes/pom.xml b/sdks/java/maven-archetypes/pom.xml index b7fe2747daa..31263c321f4 100644 --- a/sdks/java/maven-archetypes/pom.xml +++ b/sdks/java/maven-archetypes/pom.xml @@ -69,7 +69,7 @@ - + @@ -87,6 +87,29 @@ + +maven-clean-plugin + + + + examples/src/main/resources/archetype-resources + +src/**/* +src + + false + + + examples-java8/src/main/resources/archetype-resources + +src/**/* +src + + false + + + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jason Kuster >Priority: Major > Fix For: 2.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072543#comment-16072543 ] Jean-Baptiste Onofré commented on BEAM-2273: Any update on this Jira for 2.1.0 release ? > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jason Kuster > Fix For: 2.1.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-2273) mvn clean doesn't fully clean up archetypes.
[ https://issues.apache.org/jira/browse/BEAM-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007389#comment-16007389 ] ASF GitHub Bot commented on BEAM-2273: -- GitHub user jasonkuster opened a pull request: https://github.com/apache/beam/pull/3107 [BEAM-2273] Fully clean up archetypes when running mvn clean Signed-off-by: Jason KusterBe sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- R: @dhalperi @davorbonaci You can merge this pull request into a Git repository by running: $ git pull https://github.com/jasonkuster/beam clean-up Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3107 commit 131f757996630762ecc0cce8c5b568441c651945 Author: Jason Kuster Date: 2017-05-11T23:46:25Z Fully clean up archetypes when running mvn clean Signed-off-by: Jason Kuster > mvn clean doesn't fully clean up archetypes. > > > Key: BEAM-2273 > URL: https://issues.apache.org/jira/browse/BEAM-2273 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Jason Kuster >Assignee: Jason Kuster > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)