[GitHub] borisstoyanov commented on issue #2630: Host Affinity plugin

[GitBox]

borisstoyanov commented on issue #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#issuecomment-387646532
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2630: Host Affinity plugin

[GitBox]

blueorangutan commented on issue #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#issuecomment-387646659
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2621: Backports for 4.11 branch

[GitBox]

rhtyd commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-387685480
 
 
   I looked at the reported errors, none of them are PR related, but either 
issue with the PR itself or network/env issue. I'll fix some tests in a 
separate PR.
   I'll do a squash merge, after check 4.11 branch and doing any fwd-merge. 
Then merge this PR from 4.11 onto master with `-X ours` since the backported 
changes are already on master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2613: Cleanup POMs

[GitBox]

rhtyd commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-387689270
 
 
   @blueorangutan package
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2630: Host Affinity plugin

[GitBox]

rhtyd commented on issue #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#issuecomment-387690295
 
 
   @nvazquez overall good, can you add a marvin test to show that when 
host-affinity plugin is used to deploy two VMs they both end up on the same 
host?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2569: Errors in Spanish translation

[GitBox]

rhtyd commented on issue #2569: Errors in Spanish translation
URL: https://github.com/apache/cloudstack/issues/2569#issuecomment-387698465
 
 
   @jorgesumle thanks for the issue and the PR. As requested on the PR you 
sent, we use transifex to do the translations, please use that for 
changing/fixing translation used in CloudStack. The updated translations are 
committed to CloudStack and open, even though transifex maybe a private service.
   You can look at the following on how you can participate.
   
https://github.com/apache/cloudstack/blob/master/tools/transifex/README-transifex.txt
   
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Update+L10N+files+from+Transifex+to+git+repo
   I'll close this issue as this is something that should be solved via 
transifex.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2539: Admin Dashboard System Capacity broken with German Locale

[GitBox]

rhtyd commented on issue #2539: Admin Dashboard System Capacity broken with 
German Locale
URL: https://github.com/apache/cloudstack/issues/2539#issuecomment-387702020
 
 
   I followed the step to set the locale to `de_DE.UTF-8`, restarted the mgmt 
server and before log in selected German as language. After login I see this 
(not sure if this has any error, maybe translation?):
   ![screenshot from 2018-05-09 
16-25-41](https://user-images.githubusercontent.com/95203/39811271-c477ac8e-53a5-11e8-9b56-b240ebdbd3f5.png)
   
   @mdesaive @rafaelweingartner @DaanHoogland what is the expected 
error/screenshot and any ideas on fixing it. I'll remove the milestone of 
4.11.1.0 on this as I'm not sure how to approach a fix to the reported issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387698731
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2036


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2569: Errors in Spanish translation

[GitBox]

rhtyd closed issue #2569: Errors in Spanish translation
URL: https://github.com/apache/cloudstack/issues/2569
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-387629154
 
 
   Trillian test result (tid-2646)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31862 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2621-t2646-vmware-65.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 64 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_extract_template | `Failure` | 141.60 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 164.24 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2630: Host Affinity plugin

[GitBox]

borisstoyanov commented on issue #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#issuecomment-387634385
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

blueorangutan commented on issue #2629: Fix primary storage count when deleting 
volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387652822
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2613: Cleanup POMs

[GitBox]

blueorangutan commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-387689493
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

rhtyd commented on issue #2629: Fix primary storage count when deleting volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387691414
 
 
   @rafaelweingartner can you rebase against 4.11 and fix conflicts? Then I can 
help run tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387692475
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #2584: Enhance and cleanup DatabaseUpgradeChecker

[GitBox]

marcaurele commented on issue #2584: Enhance and cleanup DatabaseUpgradeChecker
URL: https://github.com/apache/cloudstack/pull/2584#issuecomment-387654356
 
 
   @khos2ow @rhtyd @rafaelweingartner There was also this discussion about how 
the current state of DB migration was buggy, and to fix it (merged) 
https://github.com/apache/cloudstack/pull/1768 - I don't think it will break 
things. In my opinion it will only improve the current state by lifting the 
need to be very verbose, and error prone when adding a new upgrade path.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2630: Host Affinity plugin

[GitBox]

rhtyd commented on a change in pull request #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#discussion_r186992914
 
 

 ##
 File path: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
 ##
 @@ -1212,11 +1213,12 @@ private boolean canAvoidCluster(Cluster clusterVO, 
ExcludeList avoids, ExcludeLi
 }
 
 protected Pair> 
findPotentialDeploymentResources(List suitableHosts, Map suitableVolumeStoragePools,
-ExcludeList avoid, DeploymentPlanner.PlannerResourceUsage 
resourceUsageRequired, List readyAndReusedVolumes) {
+ExcludeList avoid, DeploymentPlanner.PlannerResourceUsage 
resourceUsageRequired, List readyAndReusedVolumes, List 
preferredHosts) {
 s_logger.debug("Trying to find a potenial host and associated storage 
pools from the suitable host/pool lists for this VM");
 
 boolean hostCanAccessPool = false;
 boolean haveEnoughSpace = false;
+boolean hostAffinity = true;
 
 Review comment:
   @nvazquez how about keeping the value to `false` unless the preferredHost 
list is not? This is fine as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387513278
 
 
   Trillian test result (tid-2642)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 19756 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2508-t2642-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 62 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 108.80 | 
test_privategw_acl.py
   test_01_secured_vm_migration | `Error` | 1.13 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 1.11 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 1.12 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 1.11 | 
test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 5.30 | test_vm_life_cycle.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 194.79 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 137.51 | test_vpc_vpn.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.11 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.31 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.58 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387401151
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387397331
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2029


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387400987
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387692217
 
 
   XenServer and Vmware tests are LGTM, 1-2 failure seen in intermittent/env 
related. I've rebase and fixed conflicts against latest 4.11, will kick test 
against KVM after packaging.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2625: Could not connect to SMTP host

[GitBox]

rhtyd closed issue #2625: Could not connect to SMTP host
URL: https://github.com/apache/cloudstack/issues/2625
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2625: Could not connect to SMTP host

[GitBox]

rhtyd commented on issue #2625: Could not connect to SMTP host
URL: https://github.com/apache/cloudstack/issues/2625#issuecomment-387696619
 
 
   @izenk depending on your STMP provider's setting if you want SSL enabled 
transport set `project.smtp.useAuth` to true in global settings, restart mgmt 
server and try again. I'll close this but feel free to open if the advised 
solution does not work for you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2575: HTML shown to end-user in UI

[GitBox]

rhtyd commented on issue #2575: HTML shown to end-user in UI
URL: https://github.com/apache/cloudstack/issues/2575#issuecomment-387698925
 
 
   I could reproduce this in latest 4.11 while creating zone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-387515399
 
 
   Trillian test result (tid-2639)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27050 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2621-t2639-vmware-65.zip
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 45 look OK, 22 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_00_deploy_vm_root_resize | `Failure` | 375.17 | 
test_deploy_vm_root_resize.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | 
test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | 
test_router_dns.py
   ContextSuite context=TestChangeServiceOfferingForVmWithSnapshots>:setup | 
`Error` | 0.00 | test_vm_snapshots.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.00 | 
test_vm_snapshots.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | 
test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.17 | 
test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.15 | 
test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.31 | 
test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | 
test_routers.py
   ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
   test_01_sys_vm_start | `Failure` | 0.09 | test_secondary_storage.py
   test_02_sys_template_ready | `Failure` | 0.08 | test_secondary_storage.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.20 | 
test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.42 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.42 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | 

[cloudstack] branch master updated (bc8a0c1 -> bb8f8b1)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from bc8a0c1  Remove "self-injection" of AccountManagerImpl (#2619)
 add 4534cef  backports for 4.11.1 from master (#2621)
 new bb8f8b1  Merge branch '4.11': ignore backport changes from 4.11

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack] 01/01: Merge branch '4.11': ignore backport changes from 4.11

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit bb8f8b1683dbd1bae2e3b02cdb2f0c36b992ceb9
Merge: bc8a0c1 4534cef
Author: Rohit Yadav 
AuthorDate: Wed May 9 15:25:39 2018 +0530

Merge branch '4.11': ignore backport changes from 4.11

Signed-off-by: Rohit Yadav 


-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] borisstoyanov commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

borisstoyanov commented on issue #2629: Fix primary storage count when deleting 
volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387652710
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

blueorangutan commented on issue #2615: config-drive: support user data on L2 
networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-386802579
 
 
   Trillian test result (tid-2602)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 87653 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2615-t2602-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 57 look OK, 10 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_verify_guest_lspci | `Error` | 621.74 | test_deploy_virtio_scsi_vm.py
   test_06_verify_guest_lspci_again | `Error` | 624.08 | 
test_deploy_virtio_scsi_vm.py
   test_isolate_network_password_server | `Failure` | 186.26 | 
test_password_server.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 382.47 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 712.51 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 336.29 | 
test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 536.05 | 
test_internal_lb.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 679.27 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 908.96 | 
test_privategw_acl.py
   test_router_dhcphosts | `Failure` | 183.04 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 194.34 | 
test_router_dhcphosts.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 
310.55 | test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 
324.96 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
488.65 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
488.43 | test_routers_network_ops.py
   test_01_secured_vm_migration | `Error` | 33.76 | test_vm_life_cycle.py
   test_01_secured_vm_migration | `Error` | 34.94 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 1.09 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 0.08 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 1.09 | 
test_vm_life_cycle.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 989.92 | 
test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 549.71 | 
test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 1059.32 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Error` | 633.12 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 485.44 | test_vpc_vpn.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.46 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2624: Unknown parameters : projectid

[GitBox]

rhtyd commented on issue #2624: Unknown parameters : projectid
URL: https://github.com/apache/cloudstack/issues/2624#issuecomment-387695753
 
 
   These log messages mean that an unsupported API param arg was submitted as 
part of the API request. These are harmless and ignorable warning. A lot of 
these warning I could not see in latest 4.11 branch via UI browsing some of the 
thing you've noted. Closing this bug.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2624: Unknown parameters : projectid

[GitBox]

rhtyd closed issue #2624: Unknown parameters : projectid
URL: https://github.com/apache/cloudstack/issues/2624
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2613: Cleanup POMs

[GitBox]

blueorangutan commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-387695835
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2035


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2592: Unable to add NIC to VM - Insufficient capacity when adding NIC to VM

[GitBox]

rhtyd commented on issue #2592: Unable to add NIC to VM - Insufficient capacity 
when adding NIC to VM
URL: https://github.com/apache/cloudstack/issues/2592#issuecomment-387700754
 
 
   I could not reproduce this issue on latest 4.11 branch. I did this:
   - I added a new isolated network, it went into "Allocated" state
   - On an already deployed/running VM, I add a nic on the newly created 
network to it
   - This kicked a new VR for that new network and a nic was successfully 
added, no errors see.
   
   ![screenshot from 2018-05-09 
16-20-11](https://user-images.githubusercontent.com/95203/39811021-03e4e2ca-53a5-11e8-8780-d70b07e5f7b3.png)
   ![screenshot from 2018-05-09 
16-20-21](https://user-images.githubusercontent.com/95203/39811024-04272d10-53a5-11e8-9662-0b8230368fd4.png)
   
   Closing this issue as I could not reproduce it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2592: Unable to add NIC to VM - Insufficient capacity when adding NIC to VM

[GitBox]

rhtyd closed issue #2592: Unable to add NIC to VM - Insufficient capacity when 
adding NIC to VM
URL: https://github.com/apache/cloudstack/issues/2592
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-387639382
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2584: Enhance and cleanup DatabaseUpgradeChecker

[GitBox]

blueorangutan commented on issue #2584: Enhance and cleanup 
DatabaseUpgradeChecker
URL: https://github.com/apache/cloudstack/pull/2584#issuecomment-387635904
 
 
   Trillian test result (tid-2643)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47609 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2584-t2643-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 248.23 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 128.29 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_secured_vm_migration | `Error` | 40.39 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 40.41 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 42.42 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 40.40 | 
test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 138.62 | test_volumes.py
   test_11_migrate_volume_and_change_offering | `Error` | 131.39 | 
test_volumes.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.43 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2630: Host Affinity plugin

[GitBox]

blueorangutan commented on issue #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#issuecomment-387640997
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2033


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-387593228
 
 
   Trillian test result (tid-2637)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 48645 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2621-t2637-xenserver-71.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_dynamicroles.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_simulator.py
   Intermitten failure detected: /marvin/tests/smoke/test_login.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Smoke tests completed. 55 look OK, 12 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   login_test_saml_user | `Error` | 0.70 | test_login.py
   test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py
   test_role_account_acls_multiple_mgmt_servers | `Error` | 0.73 | 
test_dynamicroles.py
   test_configure_ha_provider_invalid | `Error` | 0.01 | 
test_hostha_simulator.py
   test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | 
test_hostha_simulator.py
   test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | 
test_hostha_simulator.py
   test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_configure_default_driver | `Error` | 0.01 | 
test_hostha_simulator.py
   test_hostha_configure_invalid_provider | `Error` | 0.01 | 
test_hostha_simulator.py
   test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | 
test_hostha_simulator.py
   test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py
   test_oobm_issue_power_cycle | `Error` | 3.53 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_off | `Error` | 2.40 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_on | `Error` | 3.41 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_reset | `Error` | 2.32 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_soft | `Error` | 2.47 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_status | `Error` | 2.31 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_background_powerstate_sync | `Failure` | 21.62 | 
test_outofbandmanagement.py
   test_oobm_background_powerstate_sync | `Error` | 21.63 | 
test_outofbandmanagement.py
   test_oobm_configure_default_driver | `Error` | 0.05 | 
test_outofbandmanagement.py
   test_oobm_configure_invalid_driver | `Error` | 0.05 | 
test_outofbandmanagement.py
   test_oobm_disable_feature_invalid | `Error` | 0.07 | 
test_outofbandmanagement.py
   test_oobm_disable_feature_valid | `Error` | 0.14 | 
test_outofbandmanagement.py
   test_oobm_enable_feature_invalid | `Error` | 0.07 | 
test_outofbandmanagement.py
   test_oobm_enable_feature_valid | `Error` | 1.13 | test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 10.97 | 
test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 10.98 | 
test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 4.45 | test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 4.45 | test_outofbandmanagement.py
   

[GitHub] blueorangutan commented on issue #2621: Backports for 4.11 branch

[GitBox]

blueorangutan commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-387621543
 
 
   Trillian test result (tid-2644)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 28579 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2621-t2644-xenserver-71.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_dynamicroles.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_simulator.py
   Intermitten failure detected: /marvin/tests/smoke/test_login.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 55 look OK, 12 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   login_test_saml_user | `Error` | 0.46 | test_login.py
   test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py
   test_role_account_acls_multiple_mgmt_servers | `Error` | 0.47 | 
test_dynamicroles.py
   test_configure_ha_provider_invalid | `Error` | 0.01 | 
test_hostha_simulator.py
   test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | 
test_hostha_simulator.py
   test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | 
test_hostha_simulator.py
   test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_configure_default_driver | `Error` | 0.01 | 
test_hostha_simulator.py
   test_hostha_configure_invalid_provider | `Error` | 0.01 | 
test_hostha_simulator.py
   test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | 
test_hostha_simulator.py
   test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py
   test_oobm_issue_power_cycle | `Error` | 3.35 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_off | `Error` | 3.32 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_on | `Error` | 3.29 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_reset | `Error` | 3.28 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_soft | `Error` | 2.26 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_status | `Error` | 2.21 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_background_powerstate_sync | `Failure` | 21.41 | 
test_outofbandmanagement.py
   test_oobm_background_powerstate_sync | `Error` | 21.41 | 
test_outofbandmanagement.py
   test_oobm_configure_default_driver | `Error` | 0.04 | 
test_outofbandmanagement.py
   test_oobm_configure_invalid_driver | `Error` | 0.05 | 
test_outofbandmanagement.py
   test_oobm_disable_feature_invalid | `Error` | 0.06 | 
test_outofbandmanagement.py
   test_oobm_disable_feature_valid | `Error` | 1.15 | 
test_outofbandmanagement.py
   test_oobm_enable_feature_invalid | `Error` | 0.07 | 
test_outofbandmanagement.py
   test_oobm_enable_feature_valid | `Error` | 1.11 | test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 9.76 | 
test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 9.77 | 
test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 4.29 | test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 4.30 | test_outofbandmanagement.py
   test_oobm_issue_power_off | 

[GitHub] rhtyd commented on issue #2621: Backports for 4.11 branch

[GitBox]

rhtyd commented on issue #2621: Backports for 4.11 branch
URL: https://github.com/apache/cloudstack/pull/2621#issuecomment-387639190
 
 
   @blueorangutan test centos7 xenserver-71


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2630: Host Affinity plugin

[GitBox]

blueorangutan commented on issue #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#issuecomment-387634586
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

borisstoyanov commented on issue #2629: Fix primary storage count when deleting 
volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387637614
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

blueorangutan commented on issue #2629: Fix primary storage count when deleting 
volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387637727
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2627: Catch error in packagin script and fail the build

[GitBox]

blueorangutan commented on issue #2627: Catch error in packagin script and fail 
the build
URL: https://github.com/apache/cloudstack/pull/2627#issuecomment-387629383
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2032


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

blueorangutan commented on issue #2629: Fix primary storage count when deleting 
volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387644320
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2034


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2630: Host Affinity plugin

[GitBox]

blueorangutan commented on issue #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#issuecomment-387753902
 
 
   Trillian test result (tid-2649)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 23050 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2630-t2649-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_site2site_vpn | `Failure` | 159.49 | test_vpc_vpn.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.65 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2558: API uploadSslCert does not work

[GitBox]

GabrielBrascher commented on issue #2558: API uploadSslCert does not work
URL: https://github.com/apache/cloudstack/issues/2558#issuecomment-387783651
 
 
   Yes @rhtyd, I will take a look at it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2584: Enhance and cleanup DatabaseUpgradeChecker

[GitBox]

rhtyd commented on issue #2584: Enhance and cleanup DatabaseUpgradeChecker
URL: https://github.com/apache/cloudstack/pull/2584#issuecomment-387793896
 
 
   @khos2ow fair enough, my concern was that the resultant linked-list and map 
(old way) should return the same list -- I was looking for such a test for all 
version keys (from the old map).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX" (#2600)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 951f73b  CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX" 
(#2600)
951f73b is described below

commit 951f73b10749b1d713ab1d740e6667def4bac212
Author: Kui LIU 
AuthorDate: Wed May 9 18:14:40 2018 +0200

CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX" (#2600)

These Boolean-return methods are named "getXXX", but other Boolean-return 
methods are named "isXXX", such as the following two methods. They will return 
boolean values, rename them as "isXXX" should be more clear than "getXXX".
---
 .../command/admin/offering/CreateServiceOfferingCmd.java   |  6 +++---
 .../api/command/admin/vlan/ListVlanIpRangesCmd.java|  2 +-
 .../api/command/admin/vpc/UpdateVPCCmdByAdmin.java |  2 +-
 .../api/command/user/address/ListPublicIpAddressesCmd.java |  4 ++--
 .../api/command/user/network/ListNetworksCmd.java  |  4 ++--
 .../apache/cloudstack/api/command/user/vm/DeployVMCmd.java |  2 +-
 .../cloudstack/api/command/user/vpc/UpdateVPCCmd.java  |  4 ++--
 .../org/apache/cloudstack/api/response/HostResponse.java   |  6 +++---
 .../cloudstack/api/response/ServiceOfferingResponse.java   |  2 +-
 .../cloudstack/api/response/SnapshotPolicyResponse.java|  2 +-
 .../org/apache/cloudstack/api/response/VolumeResponse.java |  2 +-
 .../org/apache/cloudstack/api/command/QuotaSummaryCmd.java |  4 ++--
 .../lifecylce/NexentaPrimaryDataStoreLifeCycle.java|  2 +-
 .../storage/datastore/util/NexentaStorAppliance.java   |  2 +-
 .../cloudstack/storage/datastore/util/NexentaUtil.java |  2 +-
 .../cloudstack/storage/datastore/util/NexentaUtilTest.java |  6 +++---
 .../com/cloud/configuration/ConfigurationManagerImpl.java  |  6 +++---
 .../main/java/com/cloud/network/NetworkServiceImpl.java|  4 ++--
 .../main/java/com/cloud/server/ManagementServerImpl.java   |  6 +++---
 .../src/main/java/com/cloud/storage/TemplateProfile.java   | 14 +++---
 .../main/java/com/cloud/template/TemplateAdapterBase.java  |  8 
 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java   |  2 +-
 22 files changed, 46 insertions(+), 46 deletions(-)

diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
index 41e5fc9..eaa8d87 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
@@ -166,15 +166,15 @@ public class CreateServiceOfferingCmd extends BaseCmd {
 return serviceOfferingName;
 }
 
-public Boolean getOfferHa() {
+public Boolean isOfferHa() {
 return offerHa == null ? Boolean.FALSE : offerHa;
 }
 
-public Boolean GetLimitCpuUse() {
+public Boolean isLimitCpuUse() {
 return limitCpuUse == null ? Boolean.FALSE : limitCpuUse;
 }
 
-public Boolean getVolatileVm() {
+public Boolean isVolatileVm() {
 return isVolatile == null ? Boolean.FALSE : isVolatile;
 }
 
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
index d4f2d5a..d5edd30 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
@@ -119,7 +119,7 @@ public class ListVlanIpRangesCmd extends BaseListCmd {
 return networkId;
 }
 
-public Boolean getForVirtualNetwork() {
+public Boolean isForVirtualNetwork() {
 return forVirtualNetwork;
 }
 
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
index 8606c32..d7761de 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
@@ -34,7 +34,7 @@ public class UpdateVPCCmdByAdmin extends UpdateVPCCmd {
 
 @Override
 public void execute(){
-Vpc result = _vpcService.updateVpc(getId(), getVpcName(), 
getDisplayText(), getCustomId(), getDisplayVpc());
+Vpc result = _vpcService.updateVpc(getId(), getVpcName(), 
getDisplayText(), getCustomId(), isDisplayVpc());
 if (result != null) {
 VpcResponse response = 
_responseGenerator.createVpcResponse(ResponseView.Full, result);
 

[GitHub] rhtyd closed pull request #2600: CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX".

[GitBox]

rhtyd closed pull request #2600: CLOUDSTACK-10362: Change the "getXXX" method 
names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
index 0bde79bbd7b..3448698cd37 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
@@ -166,15 +166,15 @@ public String getServiceOfferingName() {
 return serviceOfferingName;
 }
 
-public Boolean getOfferHa() {
+public Boolean isOfferHa() {
 return offerHa == null ? Boolean.FALSE : offerHa;
 }
 
-public Boolean GetLimitCpuUse() {
+public Boolean isLimitCpuUse() {
 return limitCpuUse == null ? Boolean.FALSE : limitCpuUse;
 }
 
-public Boolean getVolatileVm() {
+public Boolean isVolatileVm() {
 return isVolatile == null ? Boolean.FALSE : isVolatile;
 }
 
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
index d4f2d5ad611..d5edd301a66 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
@@ -119,7 +119,7 @@ public Long getNetworkId() {
 return networkId;
 }
 
-public Boolean getForVirtualNetwork() {
+public Boolean isForVirtualNetwork() {
 return forVirtualNetwork;
 }
 
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
index 8606c32a71e..d7761def204 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCCmdByAdmin.java
@@ -34,7 +34,7 @@
 
 @Override
 public void execute(){
-Vpc result = _vpcService.updateVpc(getId(), getVpcName(), 
getDisplayText(), getCustomId(), getDisplayVpc());
+Vpc result = _vpcService.updateVpc(getId(), getVpcName(), 
getDisplayText(), getCustomId(), isDisplayVpc());
 if (result != null) {
 VpcResponse response = 
_responseGenerator.createVpcResponse(ResponseView.Full, result);
 response.setResponseName(getCommandName());
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
index 0a0e7a12076..d590081104a 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
@@ -133,11 +133,11 @@ public Long getAssociatedNetworkId() {
 return associatedNetworkId;
 }
 
-public Boolean getIsSourceNat() {
+public Boolean isSourceNat() {
 return isSourceNat;
 }
 
-public Boolean getIsStaticNat() {
+public Boolean isStaticNat() {
 return isStaticNat;
 }
 
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
index 041d6417044..a61c59734c6 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java
@@ -123,11 +123,11 @@ public Long getPhysicalNetworkId() {
 return supportedServices;
 }
 
-public Boolean getRestartRequired() {
+public Boolean isRestartRequired() {
 return restartRequired;
 }
 
-public Boolean getSpecifyIpRanges() {
+public Boolean isSpecifyIpRanges() {
 return specifyIpRanges;
 }
 
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 
b/api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
index 8161fb2564b..7fc54884099 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
@@ -256,7 +256,7 @@ public HypervisorType getHypervisor() {
 return 

[GitHub] blueorangutan commented on issue #2615: config-drive: support user data on L2 networks

[GitBox]

blueorangutan commented on issue #2615: config-drive: support user data on L2 
networks
URL: https://github.com/apache/cloudstack/pull/2615#issuecomment-38662
 
 
   Trillian test result (tid-2647)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34119 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2615-t2647-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: config-drive: support user data on L2 networks (#2615)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new bd89760  config-drive: support user data on L2 networks (#2615)
bd89760 is described below

commit bd8976010835acaa690c85775d0504a4ff8df894
Author: Nicolas Vazquez 
AuthorDate: Wed May 9 13:03:11 2018 -0300

config-drive: support user data on L2 networks (#2615)

Supporting ConfigDrive user data on L2 networks.
Add UI checkbox to create L2 network offering with config drive.

Signed-off-by: Rohit Yadav 
---
 .../engine/orchestration/NetworkOrchestrator.java  | 20 +--
 .../orchestration/NetworkOrchestratorTest.java | 41 ++
 server/src/com/cloud/network/NetworkModelImpl.java |  2 +-
 .../com/cloud/network/guru/GuestNetworkGuru.java   |  4 +--
 ui/scripts/configuration.js| 19 ++
 ui/scripts/docs.js |  4 +++
 6 files changed, 85 insertions(+), 5 deletions(-)

diff --git 
a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 
b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
index 1b707c3..5508472 100644
--- 
a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
+++ 
b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -2291,13 +2291,14 @@ public class NetworkOrchestrator extends ManagerBase 
implements NetworkOrchestra
 final boolean cidrRequired = zone.getNetworkType() == 
NetworkType.Advanced
 && ntwkOff.getTrafficType() == TrafficType.Guest
 && (ntwkOff.getGuestType() == GuestType.Shared || 
(ntwkOff.getGuestType() == GuestType.Isolated
-&& 
!_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.SourceNat))
-|| ntwkOff.getGuestType() == GuestType.L2 && 
!_networkModel.listNetworkOfferingServices(ntwkOff.getId()).isEmpty());
+&& 
!_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.SourceNat)));
 if (cidr == null && ip6Cidr == null && cidrRequired) {
 throw new 
InvalidParameterValueException("StartIp/endIp/gateway/netmask are required when 
create network of" + " type " + Network.GuestType.Shared
 + " and network of type " + GuestType.Isolated + " with 
service " + Service.SourceNat.getName() + " disabled");
 }
 
+checkL2OfferingServices(ntwkOff);
+
 // No cidr can be specified in Basic zone
 if (zone.getNetworkType() == NetworkType.Basic && cidr != null) {
 throw new 
InvalidParameterValueException("StartIp/endIp/gateway/netmask can't be 
specified for zone of type " + NetworkType.Basic);
@@ -2396,6 +2397,21 @@ public class NetworkOrchestrator extends ManagerBase 
implements NetworkOrchestra
 return network;
 }
 
+/**
+ * Checks for L2 network offering services. Only 2 cases allowed:
+ * - No services
+ * - User Data service only, provided by ConfigDrive
+ * @param ntwkOff network offering
+ */
+protected void checkL2OfferingServices(NetworkOfferingVO ntwkOff) {
+if (ntwkOff.getGuestType() == GuestType.L2 && 
!_networkModel.listNetworkOfferingServices(ntwkOff.getId()).isEmpty() &&
+
(!_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.UserData) ||
+
(_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.UserData) &&
+
_networkModel.listNetworkOfferingServices(ntwkOff.getId()).size() > 1))) {
+throw new InvalidParameterValueException("For L2 networks, only 
UserData service is allowed");
+}
+}
+
 @Override
 @DB
 public boolean shutdownNetwork(final long networkId, final 
ReservationContext context, final boolean cleanupElements) {
diff --git 
a/engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
 
b/engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
index 2d15403..b0283f3 100644
--- 
a/engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
+++ 
b/engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
@@ -26,10 +26,15 @@ import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Arrays;
 
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.offerings.NetworkOfferingVO;
 import org.apache.log4j.Logger;
 import org.junit.Before;
 import 

[GitHub] rhtyd closed pull request #2615: config-drive: support user data on L2 networks

[GitBox]

rhtyd closed pull request #2615: config-drive: support user data on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 
b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
index cec2e5926c1..f9d63676f8c 100644
--- 
a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
+++ 
b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -2290,13 +2290,14 @@ public Network createGuestNetwork(final long 
networkOfferingId, final String nam
 final boolean cidrRequired = zone.getNetworkType() == 
NetworkType.Advanced
 && ntwkOff.getTrafficType() == TrafficType.Guest
 && (ntwkOff.getGuestType() == GuestType.Shared || 
(ntwkOff.getGuestType() == GuestType.Isolated
-&& 
!_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.SourceNat))
-|| ntwkOff.getGuestType() == GuestType.L2 && 
!_networkModel.listNetworkOfferingServices(ntwkOff.getId()).isEmpty());
+&& 
!_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.SourceNat)));
 if (cidr == null && ip6Cidr == null && cidrRequired) {
 throw new 
InvalidParameterValueException("StartIp/endIp/gateway/netmask are required when 
create network of" + " type " + Network.GuestType.Shared
 + " and network of type " + GuestType.Isolated + " with 
service " + Service.SourceNat.getName() + " disabled");
 }
 
+checkL2OfferingServices(ntwkOff);
+
 // No cidr can be specified in Basic zone
 if (zone.getNetworkType() == NetworkType.Basic && cidr != null) {
 throw new 
InvalidParameterValueException("StartIp/endIp/gateway/netmask can't be 
specified for zone of type " + NetworkType.Basic);
@@ -2395,6 +2396,21 @@ public Network doInTransaction(final TransactionStatus 
status) {
 return network;
 }
 
+/**
+ * Checks for L2 network offering services. Only 2 cases allowed:
+ * - No services
+ * - User Data service only, provided by ConfigDrive
+ * @param ntwkOff network offering
+ */
+protected void checkL2OfferingServices(NetworkOfferingVO ntwkOff) {
+if (ntwkOff.getGuestType() == GuestType.L2 && 
!_networkModel.listNetworkOfferingServices(ntwkOff.getId()).isEmpty() &&
+
(!_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.UserData) ||
+
(_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.UserData) &&
+
_networkModel.listNetworkOfferingServices(ntwkOff.getId()).size() > 1))) {
+throw new InvalidParameterValueException("For L2 networks, only 
UserData service is allowed");
+}
+}
+
 @Override
 @DB
 public boolean shutdownNetwork(final long networkId, final 
ReservationContext context, final boolean cleanupElements) {
diff --git 
a/engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
 
b/engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
index 2d15403a865..b0283f35c1b 100644
--- 
a/engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
+++ 
b/engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
@@ -26,10 +26,15 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Arrays;
 
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.offerings.NetworkOfferingVO;
 import org.apache.log4j.Logger;
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
 import org.mockito.Matchers;
 
 import com.cloud.network.Network;
@@ -56,6 +61,7 @@
 /**
  * NetworkManagerImpl implements NetworkManager.
  */
+@RunWith(JUnit4.class)
 public class NetworkOrchestratorTest extends TestCase {
 static final Logger s_logger = 
Logger.getLogger(NetworkOrchestratorTest.class);
 
@@ -65,6 +71,10 @@
 String dhcpProvider = "VirtualRouter";
 NetworkGuru guru = mock(NetworkGuru.class);
 
+NetworkOfferingVO networkOffering = mock(NetworkOfferingVO.class);
+
+private static final long networkOfferingId = 1l;
+
 @Override
 @Before
 public void setUp() {
@@ -90,6 +100,9 @@ public void setUp() {
 List networkGurus = new ArrayList();
 

[GitHub] rhtyd commented on issue #2630: Host Affinity plugin

[GitBox]

rhtyd commented on issue #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#issuecomment-387790019
 
 
   Tests LGTM, once review comments are addressed/replied we can merge this. 
/cc @nvazquez 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2627: Catch error in packagin script and fail the build

[GitBox]

rhtyd closed pull request #2627: Catch error in packagin script and fail the 
build
URL: https://github.com/apache/cloudstack/pull/2627
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/packaging/package.sh b/packaging/package.sh
index c4f2c489e2b..7432da72452 100755
--- a/packaging/package.sh
+++ b/packaging/package.sh
@@ -162,11 +162,16 @@ function packaging() {
 cp "$PWD/$DISTRO/cloud.spec" "$RPMDIR/SPECS"
 
 (cd "$RPMDIR"; rpmbuild --define "_topdir ${RPMDIR}" "${DEFVER}" 
"${DEFFULLVER}" "${DEFREL}" ${DEFPRE+"$DEFPRE"} ${DEFOSSNOSS+"$DEFOSSNOSS"} 
${DEFSIM+"$DEFSIM"} -bb SPECS/cloud.spec)
-(cd $PWD/../; git reset --hard)
 if [ $? -ne 0 ]; then
+if [ "$USE_TIMESTAMP" == "true" ]; then
+(cd $PWD/../; git reset --hard)
+fi
 echo "RPM Build Failed "
 exit 3
 else
+if [ "$USE_TIMESTAMP" == "true" ]; then
+(cd $PWD/../; git reset --hard)
+fi
 echo "RPM Build Done"
 fi
 exit
@@ -259,5 +264,16 @@ if [ -n "$unrecognized_flags" ]; then
 echo ""
 fi
 
+# Fail early if working directory is NOT clean and --use-timestamp was provided
+if [ "$USE_TIMESTAMP" == "true" ]; then
+if [ -n "$(cd $PWD/../; git status -s)" ]; then
+echo "Erro: You have uncommitted changes and asked for --use-timestamp 
to be used."
+echo "  --use-timestamp flag is going to temporarily change  POM 
versions  and"
+echo "  revert them at the end of build, and there's no  way we 
can do partial"
+echo "  revert. Please commit your changes first or omit 
--use-timestamp flag."
+exit 1
+fi
+fi
+
 echo "Packaging CloudStack..."
 packaging "$PACKAGEVAL" "$SIM" "$TARGETDISTRO" "$RELEASE" "$BRANDING" 
"$USE_TIMESTAMP"


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: packaging: Catch error in packaging script and fail the build (#2627)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 1107595  packaging: Catch error in packaging script and fail the build 
(#2627)
1107595 is described below

commit 11075953f66c3ed0adc457a08601833b5395e581
Author: Khosrow Moossavi 
AuthorDate: Wed May 9 12:13:07 2018 -0400

packaging: Catch error in packaging script and fail the build (#2627)

This is to fix the regression added in #2433. In this fix
we're going to fail the build early if --use-timestamp is
provided and working directory is *not* clean.
---
 packaging/package.sh | 18 +-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/packaging/package.sh b/packaging/package.sh
index c4f2c48..7432da7 100755
--- a/packaging/package.sh
+++ b/packaging/package.sh
@@ -162,11 +162,16 @@ function packaging() {
 cp "$PWD/$DISTRO/cloud.spec" "$RPMDIR/SPECS"
 
 (cd "$RPMDIR"; rpmbuild --define "_topdir ${RPMDIR}" "${DEFVER}" 
"${DEFFULLVER}" "${DEFREL}" ${DEFPRE+"$DEFPRE"} ${DEFOSSNOSS+"$DEFOSSNOSS"} 
${DEFSIM+"$DEFSIM"} -bb SPECS/cloud.spec)
-(cd $PWD/../; git reset --hard)
 if [ $? -ne 0 ]; then
+if [ "$USE_TIMESTAMP" == "true" ]; then
+(cd $PWD/../; git reset --hard)
+fi
 echo "RPM Build Failed "
 exit 3
 else
+if [ "$USE_TIMESTAMP" == "true" ]; then
+(cd $PWD/../; git reset --hard)
+fi
 echo "RPM Build Done"
 fi
 exit
@@ -259,5 +264,16 @@ if [ -n "$unrecognized_flags" ]; then
 echo ""
 fi
 
+# Fail early if working directory is NOT clean and --use-timestamp was provided
+if [ "$USE_TIMESTAMP" == "true" ]; then
+if [ -n "$(cd $PWD/../; git status -s)" ]; then
+echo "Erro: You have uncommitted changes and asked for --use-timestamp 
to be used."
+echo "  --use-timestamp flag is going to temporarily change  POM 
versions  and"
+echo "  revert them at the end of build, and there's no  way we 
can do partial"
+echo "  revert. Please commit your changes first or omit 
--use-timestamp flag."
+exit 1
+fi
+fi
+
 echo "Packaging CloudStack..."
 packaging "$PACKAGEVAL" "$SIM" "$TARGETDISTRO" "$RELEASE" "$BRANDING" 
"$USE_TIMESTAMP"

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd commented on issue #2614: WIP perform config drive creation on primary storage (CLOUDSTACK-10290)

[GitBox]

rhtyd commented on issue #2614: WIP perform config drive creation on primary 
storage (CLOUDSTACK-10290)
URL: https://github.com/apache/cloudstack/pull/2614#issuecomment-387725700
 
 
   @DaanHoogland is this ready for testing and review, as per our schedule we 
were hoping to cut RC1 starting next week (mid May) I'm cutting down on the 
scope and limiting to completed PRs and blockers.
   I'll re-add the milestone on your remark.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2614: WIP perform config drive creation on primary storage (CLOUDSTACK-10290)

[GitBox]

rhtyd commented on issue #2614: WIP perform config drive creation on primary 
storage (CLOUDSTACK-10290)
URL: https://github.com/apache/cloudstack/pull/2614#issuecomment-387725700
 
 
   @DaanHoogland is this ready for testing and review, as per our schedule we 
were hoping to cut RC1 starting next week (mid May) I'm cutting down on the 
scope and limiting to completed PRs and blockers. --I'll re-add the milestone 
on your remark.-- 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2614: WIP perform config drive creation on primary storage (CLOUDSTACK-10290)

[GitBox]

rhtyd commented on issue #2614: WIP perform config drive creation on primary 
storage (CLOUDSTACK-10290)
URL: https://github.com/apache/cloudstack/pull/2614#issuecomment-387725700
 
 
   @DaanHoogland is this ready for testing and review, as per our schedule we 
were hoping to cut RC1 starting next week (mid May) I'm cutting down on the 
scope and limiting to completed PRs and blockers.
   -I'll re-add the milestone on your remark.-


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2632: listostypes: Fixes #2529 return boolean than string in response

[GitBox]

rhtyd commented on issue #2632: listostypes: Fixes #2529 return boolean than 
string in response
URL: https://github.com/apache/cloudstack/pull/2632#issuecomment-387702656
 
 
   I checked no smoke/component test consumes this API key, travis and 
packaging tests are enough to validate this change.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2529: listOsTypes respond returns isuserdefined as string

[GitBox]

rhtyd closed issue #2529: listOsTypes respond returns isuserdefined as string
URL: https://github.com/apache/cloudstack/issues/2529
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2613: Cleanup POMs

[GitBox]

rhtyd commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-387704422
 
 
   @khos2ow with your changes the logic to find version from the pom.xml needs 
changing that fails the deb packaging, but fwiw ignore the failure for now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

rhtyd commented on issue #2629: Fix primary storage count when deleting volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387706455
 
 
   @rafaelweingartner thanks, can you have a look at travis failures?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2529: listOsTypes respond returns isuserdefined as string

[GitBox]

rhtyd closed issue #2529: listOsTypes respond returns isuserdefined as string
URL: https://github.com/apache/cloudstack/issues/2529
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (bb8f8b1 -> f77b1a7)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from bb8f8b1  Merge branch '4.11': ignore backport changes from 4.11
 add 253f7d7  listostypes: Fixes #2529 return boolean than string in 
response (#2632)
 new f77b1a7  Merge branch '4.11'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../java/org/apache/cloudstack/api/response/GuestOSResponse.java| 6 +++---
 server/src/main/java/com/cloud/api/ApiResponseHelper.java   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

rhtyd commented on issue #2629: Fix primary storage count when deleting volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387735758
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2545: dedicatePublicIpRange to domain doesn't work

[GitBox]

rhtyd commented on issue #2545: dedicatePublicIpRange to domain doesn't work
URL: https://github.com/apache/cloudstack/issues/2545#issuecomment-387715468
 
 
   Since a project can tie users/accounts from different domains, IP range 
dedicated to an account/domain cannot be used by a project. Can you advise 
exactly how you were testing this? /cc @PaulAngus 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2545: dedicatePublicIpRange to domain doesn't work

[GitBox]

rhtyd commented on issue #2545: dedicatePublicIpRange to domain doesn't work
URL: https://github.com/apache/cloudstack/issues/2545#issuecomment-387715468
 
 
   Since a project can tie users/accounts from different domains, IP range 
dedicated to an account/domain cannot be used by a project. Can you advise 
exactly how you were testing this? /cc @PaulAngus 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2545: dedicatePublicIpRange to domain doesn't work

[GitBox]

rhtyd commented on issue #2545: dedicatePublicIpRange to domain doesn't work
URL: https://github.com/apache/cloudstack/issues/2545#issuecomment-387715669
 
 
   I've removed this from 4.11.1.0 until we can conclude that this is a valid 
bug.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

rafaelweingartner commented on issue #2629: Fix primary storage count when 
deleting volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387720939
 
 
   @rhtyd now everything is fine


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2614: WIP perform config drive creation on primary storage (CLOUDSTACK-10290)

[GitBox]

GabrielBrascher commented on issue #2614: WIP perform config drive creation on 
primary storage (CLOUDSTACK-10290)
URL: https://github.com/apache/cloudstack/pull/2614#issuecomment-387741703
 
 
   @DaanHoogland @rhtyd Is this still a work in progress? I can help to review 
if it is ready for testing and review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-cloudmonkey] branch master updated: Fixes #17: handle errors when unable to connect

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git


The following commit(s) were added to refs/heads/master by this push:
 new 2494d02  Fixes #17: handle errors when unable to connect
2494d02 is described below

commit 2494d0248965ea83abcd98a83fc1cfa6c5e142bd
Author: Rohit Yadav 
AuthorDate: Wed May 9 19:11:40 2018 +0530

Fixes #17: handle errors when unable to connect

Signed-off-by: Rohit Yadav 
---
 cmd/login.go| 5 +++--
 cmd/network.go  | 8 +---
 config/about.go | 3 ++-
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/cmd/login.go b/cmd/login.go
index 36b54e8..3a67103 100644
--- a/cmd/login.go
+++ b/cmd/login.go
@@ -82,9 +82,10 @@ func init() {
 
client, _, err := Login(r)
if client == nil || err != nil {
-   fmt.Println("Failed to login, check 
credentials")
+   fmt.Println("Failed to login, check credentials 
and try again.")
} else {
-   fmt.Println("Success!")
+   fmt.Println("Successfully logged in and saved 
credentials to the server profile.")
+   r.Config.UpdateConfig("", "")
}
 
return nil
diff --git a/cmd/network.go b/cmd/network.go
index 19cac73..3361526 100644
--- a/cmd/network.go
+++ b/cmd/network.go
@@ -78,10 +78,13 @@ func Login(r *Request) (*http.Client, string, error) {
 
sessionKey := ""
resp, err := client.PostForm(r.Config.ActiveProfile.URL, params)
+   if err != nil {
+   return client, sessionKey, errors.New("failed to connect to 
management server, please check the URL: " + r.Config.ActiveProfile.URL)
+   }
if resp.StatusCode != http.StatusOK {
-   e := errors.New("failed to log in")
+   e := errors.New("failed to log in, please check the 
credentials")
if err != nil {
-   e = errors.New("failed to log in due to:" + err.Error())
+   e = errors.New("failed to log in due to " + err.Error())
}
return client, sessionKey, e
}
@@ -146,7 +149,6 @@ func NewAPIRequest(r *Request, api string, args []string) 
(map[string]interface{
client.Timeout = time.Duration(time.Duration(r.Config.Core.Timeout) * 
time.Second)
response, err := client.Get(fmt.Sprintf("%s?%s", 
r.Config.ActiveProfile.URL, encodedParams))
if err != nil {
-   fmt.Println("Error:", err)
return nil, err
}
body, _ := ioutil.ReadAll(response.Body)
diff --git a/config/about.go b/config/about.go
index c47c029..088d31c 100644
--- a/config/about.go
+++ b/config/about.go
@@ -32,6 +32,7 @@ func (c *Config) Version() string {
 // PrintHeader prints startup message in CLI mode
 func (c *Config) PrintHeader() {
fmt.Println(c.Name(), c.Version())
-   fmt.Println("Type \"help\" for details, \"sync\" to update API cache or 
press tab to list commands")
+   fmt.Println("Type \"help\" for details, \"sync\" to update API cache or 
press tab to list options")
+   fmt.Println("Report issue and features here: 
https://github.com/apache/cloudstack-cloudmonkey/issues;)
fmt.Println()
 }

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd commented on issue #2614: WIP perform config drive creation on primary storage (CLOUDSTACK-10290)

[GitBox]

rhtyd commented on issue #2614: WIP perform config drive creation on primary 
storage (CLOUDSTACK-10290)
URL: https://github.com/apache/cloudstack/pull/2614#issuecomment-387706058
 
 
   This is still in WIP, we are not in a state to test/merge by end of this 
week so I'll move to 4.11.2.0. In case this change we can consider this for 
4.11.1.0 before RC1 is cut.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo commented on issue #2632: listostypes: Fixes #2529 return boolean than string in response

[GitBox]

resmo commented on issue #2632: listostypes: Fixes #2529 return boolean than 
string in response
URL: https://github.com/apache/cloudstack/pull/2632#issuecomment-387712786
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo commented on issue #2529: listOsTypes respond returns isuserdefined as string

[GitBox]

resmo commented on issue #2529: listOsTypes respond returns isuserdefined as 
string
URL: https://github.com/apache/cloudstack/issues/2529#issuecomment-387712638
 
 
   no need to close it manually, github will close it after PR is merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

[GitBox]

rhtyd commented on issue #2540: problem adding new shared network NIC to VM "A 
NIC with this MAC address exits for network:"
URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-387714577
 
 
   I was able to reproduce this using mentioned steps:
   ```
   2018-05-09 11:54:34,243 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(API-Job-Executor-4:ctx-93641744 job-151) (logid:01cf6a76) Executing AsyncJobVO 
{id:151, userId: 2, accountId: 2, instanceType: None, instanceId: null, cmd: 
org.apache.cloudstack.api.command.admin.vm.AddNicToVMCmdByAdmin, cmdInfo: 
{"virtualmachineid":"5be800c6-c06a-4944-97be-0b2339cf9fff","response":"json","ctxUserId":"2","httpmethod":"GET","networkid":"cafc6944-64fe-488a-bf2c-916ed89090b3","ctxStartEventId":"349","ctxDetails":"{\"interface
 
com.cloud.vm.VirtualMachine\":\"5be800c6-c06a-4944-97be-0b2339cf9fff\",\"interface
 
com.cloud.network.Network\":\"cafc6944-64fe-488a-bf2c-916ed89090b3\"}","ctxAccountId":"2","cmdEventType":"NIC.CREATE","_":"1525866874211"},
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 5071960016, completeMsid: null, lastUpdated: null, lastPolled: 
null, created: null}
   2018-05-09 11:54:34,244 DEBUG [c.c.a.ApiServlet] 
(qtp1096283470-12:ctx-89cce544 ctx-21b232ff) (logid:05f9e858) ===END===  
192.168.1.108 -- GET  
command=addNicToVirtualMachine=json=5be800c6-c06a-4944-97be-0b2339cf9fff=cafc6944-64fe-488a-bf2c-916ed89090b3&_=1525866874211
   2018-05-09 11:54:34,300 ERROR [c.c.a.ApiAsyncJobDispatcher] 
(API-Job-Executor-4:ctx-93641744 job-151) (logid:01cf6a76) Unexpected exception 
while executing org.apache.cloudstack.api.command.admin.vm.AddNicToVMCmdByAdmin
   com.cloud.utils.exception.CloudRuntimeException: A NIC with this MAC address 
exists for network: cafc6944-64fe-488a-bf2c-916ed89090b3
at 
com.cloud.vm.UserVmManagerImpl.addNicToVirtualMachine(UserVmManagerImpl.java:1204)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

blueorangutan commented on issue #2629: Fix primary storage count when deleting 
volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387730008
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2038


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2632: listostypes: Fixes #2529 return boolean than string in response

[GitBox]

rhtyd opened a new pull request #2632: listostypes: Fixes #2529 return boolean 
than string in response
URL: https://github.com/apache/cloudstack/pull/2632
 
 
   This returns the boolean value of the `isuserdefined` key than
   converting it to string. Fixes #2529.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

rafaelweingartner commented on issue #2629: Fix primary storage count when 
deleting volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387706721
 
 
   I am doing this right now. I think the rebase was not as straightforward as 
I would expect.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2632: listostypes: Fixes #2529 return boolean than string in response

[GitBox]

blueorangutan commented on issue #2632: listostypes: Fixes #2529 return boolean 
than string in response
URL: https://github.com/apache/cloudstack/pull/2632#issuecomment-387708965
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2037


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2614: WIP perform config drive creation on primary storage (CLOUDSTACK-10290)

[GitBox]

rhtyd commented on issue #2614: WIP perform config drive creation on primary 
storage (CLOUDSTACK-10290)
URL: https://github.com/apache/cloudstack/pull/2614#issuecomment-387725700
 
 
   @DaanHoogland is this ready for testing and review, as per our schedule we 
were hoping to cut RC1 starting next week (mid May) I'm cutting down on the 
scope and limiting to completed PRs and blockers. I'll re-add the milestone on 
your remark.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2558: API uploadSslCert does not work

[GitBox]

rhtyd commented on issue #2558: API uploadSslCert does not work
URL: https://github.com/apache/cloudstack/issues/2558#issuecomment-387747130
 
 
   @GabrielBrascher can you pick this up as well? Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

[GitBox]

rhtyd commented on issue #2540: problem adding new shared network NIC to VM "A 
NIC with this MAC address exits for network:"
URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-387746861
 
 
   @GabrielBrascher can you help fix this, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387704470
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387704582
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: listostypes: Fixes #2529 return boolean than string in response (#2632)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new 253f7d7  listostypes: Fixes #2529 return boolean than string in 
response (#2632)
253f7d7 is described below

commit 253f7d7728e561d5da6532a138b6786e7499e145
Author: Rohit Yadav 
AuthorDate: Wed May 9 18:03:09 2018 +0530

listostypes: Fixes #2529 return boolean than string in response (#2632)

This returns the boolean value of the `isuserdefined` key than
converting it to string. Fixes #2529.

Signed-off-by: Rohit Yadav 
---
 api/src/org/apache/cloudstack/api/response/GuestOSResponse.java | 6 +++---
 server/src/com/cloud/api/ApiResponseHelper.java | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/api/src/org/apache/cloudstack/api/response/GuestOSResponse.java 
b/api/src/org/apache/cloudstack/api/response/GuestOSResponse.java
index 6822288..c1a57c3 100644
--- a/api/src/org/apache/cloudstack/api/response/GuestOSResponse.java
+++ b/api/src/org/apache/cloudstack/api/response/GuestOSResponse.java
@@ -41,7 +41,7 @@ public class GuestOSResponse extends BaseResponse {
 
 @SerializedName(ApiConstants.IS_USER_DEFINED)
 @Param(description = "is the guest OS user defined")
-private String isUserDefined;
+private Boolean isUserDefined;
 
 public String getId() {
 return id;
@@ -67,11 +67,11 @@ public class GuestOSResponse extends BaseResponse {
 this.description = description;
 }
 
-public String getIsUserDefined() {
+public Boolean getIsUserDefined() {
 return isUserDefined;
 }
 
-public void setIsUserDefined(String isUserDefined) {
+public void setIsUserDefined(Boolean isUserDefined) {
 this.isUserDefined = isUserDefined;
 }
 
diff --git a/server/src/com/cloud/api/ApiResponseHelper.java 
b/server/src/com/cloud/api/ApiResponseHelper.java
index 88da634..24fecb6 100644
--- a/server/src/com/cloud/api/ApiResponseHelper.java
+++ b/server/src/com/cloud/api/ApiResponseHelper.java
@@ -3203,7 +3203,7 @@ public class ApiResponseHelper implements 
ResponseGenerator {
 GuestOSResponse response = new GuestOSResponse();
 response.setDescription(guestOS.getDisplayName());
 response.setId(guestOS.getUuid());
-
response.setIsUserDefined(Boolean.valueOf(guestOS.getIsUserDefined()).toString());
+response.setIsUserDefined(guestOS.getIsUserDefined());
 GuestOSCategoryVO category = 
ApiDBUtils.findGuestOsCategoryById(guestOS.getCategoryId());
 if (category != null) {
 response.setOsCategoryId(category.getUuid());

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd closed pull request #2632: listostypes: Fixes #2529 return boolean than string in response

[GitBox]

rhtyd closed pull request #2632: listostypes: Fixes #2529 return boolean than 
string in response
URL: https://github.com/apache/cloudstack/pull/2632
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api/src/org/apache/cloudstack/api/response/GuestOSResponse.java 
b/api/src/org/apache/cloudstack/api/response/GuestOSResponse.java
index 6822288a862..c1a57c3e0e1 100644
--- a/api/src/org/apache/cloudstack/api/response/GuestOSResponse.java
+++ b/api/src/org/apache/cloudstack/api/response/GuestOSResponse.java
@@ -41,7 +41,7 @@
 
 @SerializedName(ApiConstants.IS_USER_DEFINED)
 @Param(description = "is the guest OS user defined")
-private String isUserDefined;
+private Boolean isUserDefined;
 
 public String getId() {
 return id;
@@ -67,11 +67,11 @@ public void setDescription(String description) {
 this.description = description;
 }
 
-public String getIsUserDefined() {
+public Boolean getIsUserDefined() {
 return isUserDefined;
 }
 
-public void setIsUserDefined(String isUserDefined) {
+public void setIsUserDefined(Boolean isUserDefined) {
 this.isUserDefined = isUserDefined;
 }
 
diff --git a/server/src/com/cloud/api/ApiResponseHelper.java 
b/server/src/com/cloud/api/ApiResponseHelper.java
index 88da6342b81..24fecb6d8d9 100644
--- a/server/src/com/cloud/api/ApiResponseHelper.java
+++ b/server/src/com/cloud/api/ApiResponseHelper.java
@@ -3203,7 +3203,7 @@ public GuestOSResponse createGuestOSResponse(GuestOS 
guestOS) {
 GuestOSResponse response = new GuestOSResponse();
 response.setDescription(guestOS.getDisplayName());
 response.setId(guestOS.getUuid());
-
response.setIsUserDefined(Boolean.valueOf(guestOS.getIsUserDefined()).toString());
+response.setIsUserDefined(guestOS.getIsUserDefined());
 GuestOSCategoryVO category = 
ApiDBUtils.findGuestOsCategoryById(guestOS.getCategoryId());
 if (category != null) {
 response.setOsCategoryId(category.getUuid());


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

rhtyd commented on issue #2629: Fix primary storage count when deleting volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387723291
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2629: Fix primary storage count when deleting volumes

[GitBox]

blueorangutan commented on issue #2629: Fix primary storage count when deleting 
volumes
URL: https://github.com/apache/cloudstack/pull/2629#issuecomment-387723527
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2632: listostypes: Fixes #2529 return boolean than string in response

[GitBox]

rhtyd commented on issue #2632: listostypes: Fixes #2529 return boolean than 
string in response
URL: https://github.com/apache/cloudstack/pull/2632#issuecomment-387723347
 
 
   Merging this based on Travis smoke tests and reviews.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2529: listOsTypes respond returns isuserdefined as string

[GitBox]

rhtyd commented on issue #2529: listOsTypes respond returns isuserdefined as 
string
URL: https://github.com/apache/cloudstack/issues/2529#issuecomment-387702734
 
 
   Closing as Fixed in PR #2632 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2632: listostypes: Fixes #2529 return boolean than string in response

[GitBox]

blueorangutan commented on issue #2632: listostypes: Fixes #2529 return boolean 
than string in response
URL: https://github.com/apache/cloudstack/pull/2632#issuecomment-387702776
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2630: Host Affinity plugin

[GitBox]

DaanHoogland commented on a change in pull request #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#discussion_r186642429
 
 

 ##
 File path: 
plugins/affinity-group-processors/host-affinity/src/org/apache/cloudstack/affinity/HostAffinityProcessor.java
 ##
 @@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.affinity;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.HashSet;
+import java.util.ArrayList;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import com.cloud.vm.VMInstanceVO;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.affinity.dao.AffinityGroupDao;
+import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+
+import com.cloud.deploy.DeployDestination;
+import com.cloud.deploy.DeploymentPlan;
+import com.cloud.deploy.DeploymentPlanner.ExcludeList;
+import com.cloud.exception.AffinityConflictException;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.VirtualMachineProfile;
+import com.cloud.vm.dao.VMInstanceDao;
+
+public class HostAffinityProcessor extends AffinityProcessorBase implements 
AffinityGroupProcessor {
+
+private static final Logger s_logger = 
Logger.getLogger(HostAffinityProcessor.class);
+
+@Inject
+protected VMInstanceDao _vmInstanceDao;
+@Inject
+protected AffinityGroupDao _affinityGroupDao;
+@Inject
+protected AffinityGroupVMMapDao _affinityGroupVMMapDao;
+
+@Inject
+protected ConfigurationDao _configDao;
+
+@Override
+public void process(VirtualMachineProfile vmProfile, DeploymentPlan plan, 
ExcludeList avoid) throws AffinityConflictException {
+VirtualMachine vm = vmProfile.getVirtualMachine();
+List vmGroupMappings = 
_affinityGroupVMMapDao.findByVmIdType(vm.getId(), getType());
+for (AffinityGroupVMMapVO vmGroupMapping : vmGroupMappings) {
+if (vmGroupMapping != null) {
+AffinityGroupVO group = 
_affinityGroupDao.findById(vmGroupMapping.getAffinityGroupId());
+
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("Processing affinity group " + 
group.getName() + " for VM Id: " + vm.getId());
+}
+
+List groupVMIds = 
_affinityGroupVMMapDao.listVmIdsByAffinityGroup(group.getId());
+groupVMIds.remove(vm.getId());
+
+Set hostIds = new HashSet<>();
+for (Long groupVMId : groupVMIds) {
 
 Review comment:
   or even more


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2630: Host Affinity plugin

[GitBox]

DaanHoogland commented on a change in pull request #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#discussion_r186646609
 
 

 ##
 File path: 
plugins/affinity-group-processors/host-affinity/src/org/apache/cloudstack/affinity/HostAffinityProcessor.java
 ##
 @@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.affinity;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.HashSet;
+import java.util.ArrayList;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import com.cloud.vm.VMInstanceVO;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.affinity.dao.AffinityGroupDao;
+import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+
+import com.cloud.deploy.DeployDestination;
+import com.cloud.deploy.DeploymentPlan;
+import com.cloud.deploy.DeploymentPlanner.ExcludeList;
+import com.cloud.exception.AffinityConflictException;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.VirtualMachineProfile;
+import com.cloud.vm.dao.VMInstanceDao;
+
+public class HostAffinityProcessor extends AffinityProcessorBase implements 
AffinityGroupProcessor {
+
+private static final Logger s_logger = 
Logger.getLogger(HostAffinityProcessor.class);
+
+@Inject
+protected VMInstanceDao _vmInstanceDao;
+@Inject
+protected AffinityGroupDao _affinityGroupDao;
+@Inject
+protected AffinityGroupVMMapDao _affinityGroupVMMapDao;
+
+@Inject
+protected ConfigurationDao _configDao;
+
+@Override
+public void process(VirtualMachineProfile vmProfile, DeploymentPlan plan, 
ExcludeList avoid) throws AffinityConflictException {
+VirtualMachine vm = vmProfile.getVirtualMachine();
+List vmGroupMappings = 
_affinityGroupVMMapDao.findByVmIdType(vm.getId(), getType());
+for (AffinityGroupVMMapVO vmGroupMapping : vmGroupMappings) {
+if (vmGroupMapping != null) {
+AffinityGroupVO group = 
_affinityGroupDao.findById(vmGroupMapping.getAffinityGroupId());
+
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("Processing affinity group " + 
group.getName() + " for VM Id: " + vm.getId());
+}
+
+List groupVMIds = 
_affinityGroupVMMapDao.listVmIdsByAffinityGroup(group.getId());
+groupVMIds.remove(vm.getId());
+
+Set hostIds = new HashSet<>();
+for (Long groupVMId : groupVMIds) {
+VMInstanceVO groupVM = _vmInstanceDao.findById(groupVMId);
+hostIds.add(groupVM.getHostId());
+}
+List preferredHostIds = new ArrayList<>();
+preferredHostIds.addAll(hostIds);
+plan.setPreferredHosts(preferredHostIds);
+}
+}
+}
+
+@Override
+public boolean configure(final String name, final Map 
params) throws ConfigurationException {
+super.configure(name, params);
+return true;
+}
+
+@Override
+public boolean check(VirtualMachineProfile vmProfile, DeployDestination 
plannedDestination) throws AffinityConflictException {
+if (plannedDestination.getHost() == null) {
+return true;
+}
+long plannedHostId = plannedDestination.getHost().getId();
+
+VirtualMachine vm = vmProfile.getVirtualMachine();
+
+List vmGroupMappings = 
_affinityGroupVMMapDao.findByVmIdType(vm.getId(), getType());
+
+for (AffinityGroupVMMapVO vmGroupMapping : vmGroupMappings) {
 
 Review comment:
   same here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters

[GitBox]

rhtyd commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible 
after migration across clusters
URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-387705746
 
 
   @sureshanaparti can you rebase this against latest 4.11.
   I'll in the interim move this to 4.11.2.0 milestone, if the author does not 
repond I may take over this PR in future.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2630: Host Affinity plugin

[GitBox]

DaanHoogland commented on a change in pull request #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#discussion_r186641884
 
 

 ##
 File path: 
plugins/affinity-group-processors/host-affinity/src/org/apache/cloudstack/affinity/HostAffinityProcessor.java
 ##
 @@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.affinity;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.HashSet;
+import java.util.ArrayList;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import com.cloud.vm.VMInstanceVO;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.affinity.dao.AffinityGroupDao;
+import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+
+import com.cloud.deploy.DeployDestination;
+import com.cloud.deploy.DeploymentPlan;
+import com.cloud.deploy.DeploymentPlanner.ExcludeList;
+import com.cloud.exception.AffinityConflictException;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.VirtualMachineProfile;
+import com.cloud.vm.dao.VMInstanceDao;
+
+public class HostAffinityProcessor extends AffinityProcessorBase implements 
AffinityGroupProcessor {
+
+private static final Logger s_logger = 
Logger.getLogger(HostAffinityProcessor.class);
+
+@Inject
+protected VMInstanceDao _vmInstanceDao;
+@Inject
+protected AffinityGroupDao _affinityGroupDao;
+@Inject
+protected AffinityGroupVMMapDao _affinityGroupVMMapDao;
+
+@Inject
+protected ConfigurationDao _configDao;
+
+@Override
+public void process(VirtualMachineProfile vmProfile, DeploymentPlan plan, 
ExcludeList avoid) throws AffinityConflictException {
+VirtualMachine vm = vmProfile.getVirtualMachine();
+List vmGroupMappings = 
_affinityGroupVMMapDao.findByVmIdType(vm.getId(), getType());
+for (AffinityGroupVMMapVO vmGroupMapping : vmGroupMappings) {
+if (vmGroupMapping != null) {
+AffinityGroupVO group = 
_affinityGroupDao.findById(vmGroupMapping.getAffinityGroupId());
+
+if (s_logger.isDebugEnabled()) {
 
 Review comment:
   and maybe even nested functionality as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2630: Host Affinity plugin

[GitBox]

DaanHoogland commented on a change in pull request #2630: Host Affinity plugin
URL: https://github.com/apache/cloudstack/pull/2630#discussion_r186641723
 
 

 ##
 File path: 
plugins/affinity-group-processors/host-affinity/src/org/apache/cloudstack/affinity/HostAffinityProcessor.java
 ##
 @@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.affinity;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.HashSet;
+import java.util.ArrayList;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import com.cloud.vm.VMInstanceVO;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.affinity.dao.AffinityGroupDao;
+import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+
+import com.cloud.deploy.DeployDestination;
+import com.cloud.deploy.DeploymentPlan;
+import com.cloud.deploy.DeploymentPlanner.ExcludeList;
+import com.cloud.exception.AffinityConflictException;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.VirtualMachineProfile;
+import com.cloud.vm.dao.VMInstanceDao;
+
+public class HostAffinityProcessor extends AffinityProcessorBase implements 
AffinityGroupProcessor {
+
+private static final Logger s_logger = 
Logger.getLogger(HostAffinityProcessor.class);
+
+@Inject
+protected VMInstanceDao _vmInstanceDao;
+@Inject
+protected AffinityGroupDao _affinityGroupDao;
+@Inject
+protected AffinityGroupVMMapDao _affinityGroupVMMapDao;
+
+@Inject
+protected ConfigurationDao _configDao;
+
+@Override
+public void process(VirtualMachineProfile vmProfile, DeploymentPlan plan, 
ExcludeList avoid) throws AffinityConflictException {
+VirtualMachine vm = vmProfile.getVirtualMachine();
+List vmGroupMappings = 
_affinityGroupVMMapDao.findByVmIdType(vm.getId(), getType());
+for (AffinityGroupVMMapVO vmGroupMapping : vmGroupMappings) {
 
 Review comment:
   can you factor out the contents of the for loop into a separate method?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo opened a new issue #2529: listOsTypes respond returns isuserdefined as string

[GitBox]

resmo opened a new issue #2529: listOsTypes respond returns isuserdefined as 
string
URL: https://github.com/apache/cloudstack/issues/2529
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
* Enhancement
   
   # COMPONENT NAME
   
   ~~~
   API
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11
   ~~~
   
   # CONFIGURATION
   
   N/A 
   
   # OS / ENVIRONMENT
   
   N/A 
   
   # SUMMARY
   
   listOsTypes returns `isuserdefined` as json string, instead of json bool
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
$ cs listOsTypes id=1ee61d39-4b9a-11e7-8fea-0242ac110003 --region simulator 
 
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~json
   {
 "count": 1, 
 "ostype": [
   {
 "description": "Windows XP SP3 (32-bit)", 
 "id": "1ee61d39-4b9a-11e7-8fea-0242ac110003", 
 "isuserdefined": false, 
 "oscategoryid": "1ede7e9a-4b9a-11e7-8fea-0242ac110003"
   }
 ]
   }
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~json
   {
 "count": 1, 
 "ostype": [
   {
 "description": "Windows XP SP3 (32-bit)", 
 "id": "1ee61d39-4b9a-11e7-8fea-0242ac110003", 
 "isuserdefined": "false", 
 "oscategoryid": "1ede7e9a-4b9a-11e7-8fea-0242ac110003"
   }
 ]
   }
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2614: WIP perform config drive creation on primary storage (CLOUDSTACK-10290)

[GitBox]

DaanHoogland commented on issue #2614: WIP perform config drive creation on 
primary storage (CLOUDSTACK-10290)
URL: https://github.com/apache/cloudstack/pull/2614#issuecomment-387724501
 
 
   @rhtyd this is an issue on 4.11 and needs to go in 4.11.1. If it is not done 
on release it is time to remove the milestone, not in advance.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services