[mynewt-nimble] branch master updated (c337666 -> 6df27f0)
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. from c337666 Removed an illogical check from npl_freertos_callout_reset add 6df27f0 NimBLE host: Modify `ble_gap_wl_set` to support clearing complete whitelist No new revisions were added by this update. Summary of changes: nimble/host/src/ble_gap.c | 5 - nimble/host/test/src/ble_gap_test.c | 5 +++-- 2 files changed, 3 insertions(+), 7 deletions(-)
[GitHub] [mynewt-nimble] jimmo commented on pull request #998: nimble/porting: Make os_mbuf/os_mpool work on 64-bit.
jimmo commented on pull request #998: URL: https://github.com/apache/mynewt-nimble/pull/998#issuecomment-878271358 > Yes, lets fix it in core and then resync here. > In general I think we should simply start using uintptr where needed (although mynewt was/is 32bit os only). Thanks -- I'm not too familiar with mynewt (outside of NimBLE). Do you want me to follow this up or is this best left up to the maintainers? > Could you explain why is this needed? (AFAIR initially it was like that to allow multiple initialization while executing tests) I'm not too fussed either way, but I noticed that nothing in NimBLE calls os_mempool_module_init and there's no declaration for it in any header files. So this change seems like the safest way to prevent implementors missing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-newt] vrahane commented on pull request #441: mfg: Add a base address field
vrahane commented on pull request #441: URL: https://github.com/apache/mynewt-newt/pull/441#issuecomment-878448471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-core] sjanc opened a new pull request #2640: baselibc: Fix build with -Werror=array-parameter enabled
sjanc opened a new pull request #2640: URL: https://github.com/apache/mynewt-core/pull/2640 repos/apache-mynewt-core/libc/baselibc/src/jrand48.c:8:29: error: argument 1 of type ‘short unsigned int[3]’ with mismatched bound [-Werror=array-parameter=] 8 | long jrand48(unsigned short xsubi[3]) | ~~~^~~~ In file included from repos/apache-mynewt-core/libc/baselibc/src/jrand48.c:5: repos/apache-mynewt-core/libc/baselibc/include/stdlib.h:66:23: note: previously declared as ‘short unsigned int *’ 66 | __extern long jrand48(unsigned short *); | ^~~~ cc1: all warnings being treated as errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc opened a new pull request #999: nimble/host: Fix txom leaks in ble_sm_tx and ble_l2cap_sig_tx
sjanc opened a new pull request #999: URL: https://github.com/apache/mynewt-nimble/pull/999 Those functions are expected to always consume txom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #898: NimBLE host: Modify `ble_gap_wl_set` to help remove all addresses from controller whitelist
sjanc merged pull request #898: URL: https://github.com/apache/mynewt-nimble/pull/898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #998: nimble/porting: Make os_mbuf/os_mpool work on 64-bit.
sjanc commented on a change in pull request #998: URL: https://github.com/apache/mynewt-nimble/pull/998#discussion_r667912101 ## File path: porting/nimble/src/os_mempool.c ## @@ -38,7 +38,8 @@ #define OS_MEMPOOL_TRUE_BLOCK_SIZE(mp) OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size) #endif -STAILQ_HEAD(, os_mempool) g_os_mempool_list; +STAILQ_HEAD(, os_mempool) g_os_mempool_list = +STAILQ_HEAD_INITIALIZER(g_os_mempool_list); Review comment: Could you explain why is this needed? (AFAIR initially it was like that to allow multiple initialization while executing tests) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-newt] vikrant-proxy opened a new pull request #440: mfg: account for updated bootloader path in mfg command
vikrant-proxy opened a new pull request #440: URL: https://github.com/apache/mynewt-newt/pull/440 Bootloader binaries seem to have moved to `app/@mcuboot`, which causes `mfg` command to fail, see https://github.com/apache/mynewt-newt/issues/439. This PR attempts to account for this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-newt] vrahane edited a comment on pull request #441: mfg: Add a base address field
vrahane edited a comment on pull request #441: URL: https://github.com/apache/mynewt-newt/pull/441#issuecomment-878454380 I think this change is reasonable, it is required for nrf53 netcore for sure. Wonder if there is a way to make this mandatory somehow for BSPs with dual core with dedicated flash for both instead of making it optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-newt] vikrant-proxy opened a new pull request #441: mfg: Add a base address field
vikrant-proxy opened a new pull request #441: URL: https://github.com/apache/mynewt-newt/pull/441 Chips with > 1 core, like `nrf53` have the second core mapped to a different address space (not based at 0x0). This PR adds a base address field that can be provided in the `mfg.yml` in an attempt to get `mfg` to create appropriately sized binaries. Without this change, the manufacturing image tends to become very large in size as the base address for that core is not 0x0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #986: Blestress fixes
sjanc commented on a change in pull request #986:
URL: https://github.com/apache/mynewt-nimble/pull/986#discussion_r667918856
##
File path: apps/blestress/src/tx_stress.c
##
@@ -848,6 +848,16 @@ tx_stress_9_gap_event(struct ble_gap_event *event, void
*arg)
{
ble_addr_t addr;
int test;
+struct ble_gap_conn_params conn_params = {
+.scan_itvl = 0x0010,
+.scan_window = 0x0010,
+.itvl_min = BLE_GAP_INITIAL_CONN_ITVL_MIN,
+.itvl_max = BLE_GAP_INITIAL_CONN_ITVL_MAX,
+.latency = 0,
+.supervision_timeout = 0x0C80,
+.min_ce_len = 0x0010,
+.max_ce_len = 0x0300,
+};
Review comment:
are those connections maintained in test for at least this timeout after
last one is created?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
